diff mbox series

[2/3] docker: EDK2 build job depends on EDK2 container

Message ID 20210303130646.1494015-3-philmd@redhat.com
State New
Headers show
Series gitlab: Add missing job -> container dependencies | expand

Commit Message

Philippe Mathieu-Daudé March 3, 2021, 1:06 p.m. UTC 
Add missing dependency build-edk2 -> docker-edk2.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 .gitlab-ci.d/edk2.yml | 1 +
 1 file changed, 1 insertion(+)

Comments

Daniel P. Berrangé March 3, 2021, 1:17 p.m. UTC | #1 
On Wed, Mar 03, 2021 at 02:06:45PM +0100, Philippe Mathieu-Daudé wrote:
> Add missing dependency build-edk2 -> docker-edk2.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  .gitlab-ci.d/edk2.yml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitlab-ci.d/edk2.yml b/.gitlab-ci.d/edk2.yml
> index e1e04524166..ba7280605c4 100644
> --- a/.gitlab-ci.d/edk2.yml
> +++ b/.gitlab-ci.d/edk2.yml
> @@ -25,6 +25,7 @@ docker-edk2:
>  
>  build-edk2:
>   stage: build
> + needs: ['docker-edk2']
>   rules: # Only run this job when ...
>   - changes: # ... roms/edk2/ is modified (submodule updated)
>     - roms/edk2/*

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
Laszlo Ersek March 3, 2021, 2:12 p.m. UTC | #2 
On 03/03/21 14:06, Philippe Mathieu-Daudé wrote:
> Add missing dependency build-edk2 -> docker-edk2.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  .gitlab-ci.d/edk2.yml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitlab-ci.d/edk2.yml b/.gitlab-ci.d/edk2.yml
> index e1e04524166..ba7280605c4 100644
> --- a/.gitlab-ci.d/edk2.yml
> +++ b/.gitlab-ci.d/edk2.yml
> @@ -25,6 +25,7 @@ docker-edk2:
>  
>  build-edk2:
>   stage: build
> + needs: ['docker-edk2']
>   rules: # Only run this job when ...
>   - changes: # ... roms/edk2/ is modified (submodule updated)
>     - roms/edk2/*
> 

Acked-by: Laszlo Ersek <lersek@redhat.com>
Willian Rampazzo March 3, 2021, 2:48 p.m. UTC | #3 
On Wed, Mar 3, 2021 at 10:10 AM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> Add missing dependency build-edk2 -> docker-edk2.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  .gitlab-ci.d/edk2.yml | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Willian Rampazzo <willianr@redhat.com>
diff mbox series

Patch

diff --git a/.gitlab-ci.d/edk2.yml b/.gitlab-ci.d/edk2.yml
index e1e04524166..ba7280605c4 100644
--- a/.gitlab-ci.d/edk2.yml
+++ b/.gitlab-ci.d/edk2.yml
@@ -25,6 +25,7 @@  docker-edk2:
 
 build-edk2:
  stage: build
+ needs: ['docker-edk2']
  rules: # Only run this job when ...
  - changes: # ... roms/edk2/ is modified (submodule updated)
    - roms/edk2/*