| Message ID | 20210226163301.419727-4-danielhb413@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | send QAPI_EVENT_MEM_UNPLUG_ERROR for ppc64 unplugs | expand |
On Fri, 26 Feb 2021 13:32:59 -0300 Daniel Henrique Barboza <danielhb413@gmail.com> wrote: > Both CPU hotunplug and PC_DIMM unplug reports an user warning, > mentioning that the hotunplug is in progress, if consecutive > 'device_del' are issued in quick succession. > > Do the same for PHBs in spapr_phb_unplug_request(). > > Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com> > --- Reviewed-by: Greg Kurz <groug@kaod.org> > hw/ppc/spapr.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 149dc2113f..6ef72ee7bd 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -4030,6 +4030,10 @@ static void spapr_phb_unplug_request(HotplugHandler *hotplug_dev, > if (!spapr_drc_unplug_requested(drc)) { > spapr_drc_unplug_request(drc); > spapr_hotplug_req_remove_by_index(drc); > + } else { > + error_setg(errp, > + "PCI Host Bridge unplug already in progress for device %s", > + dev->id); > } > } >
On Fri, Feb 26, 2021 at 01:32:59PM -0300, Daniel Henrique Barboza wrote: > Both CPU hotunplug and PC_DIMM unplug reports an user warning, > mentioning that the hotunplug is in progress, if consecutive > 'device_del' are issued in quick succession. > > Do the same for PHBs in spapr_phb_unplug_request(). > > Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com> LGTM, and doesn't have strong dependencies on the other patches, so applied to ppc-for-6.0. > --- > hw/ppc/spapr.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 149dc2113f..6ef72ee7bd 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -4030,6 +4030,10 @@ static void spapr_phb_unplug_request(HotplugHandler *hotplug_dev, > if (!spapr_drc_unplug_requested(drc)) { > spapr_drc_unplug_request(drc); > spapr_hotplug_req_remove_by_index(drc); > + } else { > + error_setg(errp, > + "PCI Host Bridge unplug already in progress for device %s", > + dev->id); > } > } >
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 149dc2113f..6ef72ee7bd 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -4030,6 +4030,10 @@ static void spapr_phb_unplug_request(HotplugHandler *hotplug_dev, if (!spapr_drc_unplug_requested(drc)) { spapr_drc_unplug_request(drc); spapr_hotplug_req_remove_by_index(drc); + } else { + error_setg(errp, + "PCI Host Bridge unplug already in progress for device %s", + dev->id); } }
Both CPU hotunplug and PC_DIMM unplug reports an user warning, mentioning that the hotunplug is in progress, if consecutive 'device_del' are issued in quick succession. Do the same for PHBs in spapr_phb_unplug_request(). Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com> --- hw/ppc/spapr.c | 4 ++++ 1 file changed, 4 insertions(+)