diff mbox series

configs: stm32mp1: enable uefi related commands

Message ID 20210225193754.1898064-1-ilias.apalodimas@linaro.org
State Superseded
Headers show
Series configs: stm32mp1: enable uefi related commands | expand

Commit Message

Ilias Apalodimas Feb. 25, 2021, 7:37 p.m. UTC
The board can boot with UEFI. With the latest changes in U-Boot's
EFI subsystem we also have support for EFI runtime variables, without
SetVariable support.  We can also store the EFI variables in a file on the
ESP partition and preserve them across reboots.
The env and efidebug commands are missing in order to configure
EFI variables and the efibootmgr though.  Since U-Boot's default config
enables other EFI related commands (e.g bootefi), let's add the env related
and efidebug commands and allow users to do that

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
 configs/stm32mp15_trusted_defconfig | 3 +++
 1 file changed, 3 insertions(+)

Comments

Patrick DELAUNAY Feb. 26, 2021, 12:38 p.m. UTC | #1
Hi Ilias

On 2/25/21 8:37 PM, Ilias Apalodimas wrote:
> The board can boot with UEFI. With the latest changes in U-Boot's
> EFI subsystem we also have support for EFI runtime variables, without
> SetVariable support.  We can also store the EFI variables in a file on the
> ESP partition and preserve them across reboots.
> The env and efidebug commands are missing in order to configure
> EFI variables and the efibootmgr though.  Since U-Boot's default config
> enables other EFI related commands (e.g bootefi), let's add the env related
> and efidebug commands and allow users to do that
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> ---
>   configs/stm32mp15_trusted_defconfig | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/configs/stm32mp15_trusted_defconfig b/configs/stm32mp15_trusted_defconfig
> index da31b74cdeb6..107041119f1d 100644
> --- a/configs/stm32mp15_trusted_defconfig
> +++ b/configs/stm32mp15_trusted_defconfig
> @@ -17,6 +17,7 @@ CONFIG_BOOTCOMMAND="run bootcmd_stm32mp"
>   CONFIG_SYS_PROMPT="STM32MP> "
>   CONFIG_CMD_ADTIMG=y
>   CONFIG_CMD_ERASEENV=y
> +CONFIG_CMD_NVEDIT_EFI=y
>   CONFIG_CMD_MEMINFO=y
>   CONFIG_CMD_MEMTEST=y
>   CONFIG_CMD_ADC=y
> @@ -32,6 +33,7 @@ CONFIG_CMD_USB=y
>   CONFIG_CMD_USB_MASS_STORAGE=y
>   CONFIG_CMD_BMP=y
>   CONFIG_CMD_CACHE=y
> +CONFIG_CMD_EFIDEBUG=y
>   CONFIG_CMD_TIME=y
>   CONFIG_CMD_TIMER=y
>   CONFIG_CMD_PMIC=y
> @@ -144,4 +146,5 @@ CONFIG_BMP_32BPP=y
>   CONFIG_WDT=y
>   CONFIG_WDT_STM32MP=y
>   CONFIG_ERRNO_STR=y
> +# CONFIG_HEXDUMP is not set
>   CONFIG_FDT_FIXUP_PARTITIONS=y


I am ok with tha added configs.


But can you update also the stm32_basic_defconfig:

for STMicroelectronics boards, we want to have the the same

configuation between basic and trusted boot chain

(except SPL or OP-TEE related config).


Thanks


Patrick
Ilias Apalodimas Feb. 26, 2021, 12:44 p.m. UTC | #2
On Fri, Feb 26, 2021 at 01:38:21PM +0100, Patrick DELAUNAY wrote:
> Hi Ilias
> 
> On 2/25/21 8:37 PM, Ilias Apalodimas wrote:
> > The board can boot with UEFI. With the latest changes in U-Boot's
> > EFI subsystem we also have support for EFI runtime variables, without
> > SetVariable support.  We can also store the EFI variables in a file on the
> > ESP partition and preserve them across reboots.
> > The env and efidebug commands are missing in order to configure
> > EFI variables and the efibootmgr though.  Since U-Boot's default config
> > enables other EFI related commands (e.g bootefi), let's add the env related
> > and efidebug commands and allow users to do that
> > 
> > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> > ---
> >   configs/stm32mp15_trusted_defconfig | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/configs/stm32mp15_trusted_defconfig b/configs/stm32mp15_trusted_defconfig
> > index da31b74cdeb6..107041119f1d 100644
> > --- a/configs/stm32mp15_trusted_defconfig
> > +++ b/configs/stm32mp15_trusted_defconfig
> > @@ -17,6 +17,7 @@ CONFIG_BOOTCOMMAND="run bootcmd_stm32mp"
> >   CONFIG_SYS_PROMPT="STM32MP> "
> >   CONFIG_CMD_ADTIMG=y
> >   CONFIG_CMD_ERASEENV=y
> > +CONFIG_CMD_NVEDIT_EFI=y
> >   CONFIG_CMD_MEMINFO=y
> >   CONFIG_CMD_MEMTEST=y
> >   CONFIG_CMD_ADC=y
> > @@ -32,6 +33,7 @@ CONFIG_CMD_USB=y
> >   CONFIG_CMD_USB_MASS_STORAGE=y
> >   CONFIG_CMD_BMP=y
> >   CONFIG_CMD_CACHE=y
> > +CONFIG_CMD_EFIDEBUG=y
> >   CONFIG_CMD_TIME=y
> >   CONFIG_CMD_TIMER=y
> >   CONFIG_CMD_PMIC=y
> > @@ -144,4 +146,5 @@ CONFIG_BMP_32BPP=y
> >   CONFIG_WDT=y
> >   CONFIG_WDT_STM32MP=y
> >   CONFIG_ERRNO_STR=y
> > +# CONFIG_HEXDUMP is not set
> >   CONFIG_FDT_FIXUP_PARTITIONS=y
> 
> 
> I am ok with tha added configs.
> 
> 
> But can you update also the stm32_basic_defconfig:
> 
> for STMicroelectronics boards, we want to have the the same
> 
> configuation between basic and trusted boot chain
> 
> (except SPL or OP-TEE related config).

Yea sure, 

Cheers
/Ilias
> 
> 
> Thanks
> 
> 
> Patrick
>
diff mbox series

Patch

diff --git a/configs/stm32mp15_trusted_defconfig b/configs/stm32mp15_trusted_defconfig
index da31b74cdeb6..107041119f1d 100644
--- a/configs/stm32mp15_trusted_defconfig
+++ b/configs/stm32mp15_trusted_defconfig
@@ -17,6 +17,7 @@  CONFIG_BOOTCOMMAND="run bootcmd_stm32mp"
 CONFIG_SYS_PROMPT="STM32MP> "
 CONFIG_CMD_ADTIMG=y
 CONFIG_CMD_ERASEENV=y
+CONFIG_CMD_NVEDIT_EFI=y
 CONFIG_CMD_MEMINFO=y
 CONFIG_CMD_MEMTEST=y
 CONFIG_CMD_ADC=y
@@ -32,6 +33,7 @@  CONFIG_CMD_USB=y
 CONFIG_CMD_USB_MASS_STORAGE=y
 CONFIG_CMD_BMP=y
 CONFIG_CMD_CACHE=y
+CONFIG_CMD_EFIDEBUG=y
 CONFIG_CMD_TIME=y
 CONFIG_CMD_TIMER=y
 CONFIG_CMD_PMIC=y
@@ -144,4 +146,5 @@  CONFIG_BMP_32BPP=y
 CONFIG_WDT=y
 CONFIG_WDT_STM32MP=y
 CONFIG_ERRNO_STR=y
+# CONFIG_HEXDUMP is not set
 CONFIG_FDT_FIXUP_PARTITIONS=y