| Message ID | 20210225205150.728050-1-marex@denx.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | spi: imx: Implement set_speed | expand |
Hi Marek, On Fri, Feb 26, 2021 at 4:52 AM Marek Vasut <marex@denx.de> wrote: > > The set_speed() callback should configure the bus speed, make it so. > This patch is not flagged as v3 since previously there were 2 versions already on the ML. Did you mistakenly send this? > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Jagan Teki <jagan@amarulasolutions.com> > Cc: Stefano Babic <sbabic@denx.de> > --- > drivers/spi/mxc_spi.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c > index bb68eb90e91..bce5356b294 100644 > --- a/drivers/spi/mxc_spi.c > +++ b/drivers/spi/mxc_spi.c > @@ -662,7 +662,10 @@ static int mxc_spi_release_bus(struct udevice *dev) > > static int mxc_spi_set_speed(struct udevice *bus, uint speed) > { > - /* Nothing to do */ > + struct mxc_spi_slave *mxcs = dev_get_platdata(bus); This patch is the same as the previous v1 patch here: https://lists.denx.de/pipermail/u-boot/2021-February/439840.html And you already sent a v2 that was reviewed. https://lists.denx.de/pipermail/u-boot/2021-February/439863.html > + > + mxcs->max_hz = speed; > + > return 0; > } Regards, Bin
On 2/26/21 12:41 AM, Bin Meng wrote: > Hi Marek, Hello Bin, > On Fri, Feb 26, 2021 at 4:52 AM Marek Vasut <marex@denx.de> wrote: >> >> The set_speed() callback should configure the bus speed, make it so. >> > > This patch is not flagged as v3 since previously there were 2 versions > already on the ML. Did you mistakenly send this? No, I sent it yet again because I still do not see this patch upstream. [...]
Hi Marek, On Fri, Feb 26, 2021 at 8:14 AM Marek Vasut <marex@denx.de> wrote: > > On 2/26/21 12:41 AM, Bin Meng wrote: > > Hi Marek, > > Hello Bin, > > > On Fri, Feb 26, 2021 at 4:52 AM Marek Vasut <marex@denx.de> wrote: > >> > >> The set_speed() callback should configure the bus speed, make it so. > >> > > > > This patch is not flagged as v3 since previously there were 2 versions > > already on the ML. Did you mistakenly send this? > > No, I sent it yet again because I still do not see this patch upstream. > Okay, but you ended up sending a wrong version :) Better to tag the patch as [RESEND] to avoid misunderstanding. > [...] Regards, Bin
On 2/26/21 2:28 AM, Bin Meng wrote: > Hi Marek, Hello Bin, > On Fri, Feb 26, 2021 at 8:14 AM Marek Vasut <marex@denx.de> wrote: >> >> On 2/26/21 12:41 AM, Bin Meng wrote: >>> Hi Marek, >> >> Hello Bin, >> >>> On Fri, Feb 26, 2021 at 4:52 AM Marek Vasut <marex@denx.de> wrote: >>>> >>>> The set_speed() callback should configure the bus speed, make it so. >>>> >>> >>> This patch is not flagged as v3 since previously there were 2 versions >>> already on the ML. Did you mistakenly send this? >> >> No, I sent it yet again because I still do not see this patch upstream. >> > > Okay, but you ended up sending a wrong version :) Okay :) > Better to tag the > patch as [RESEND] to avoid misunderstanding. Thank you for your feedback.
diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c index bb68eb90e91..bce5356b294 100644 --- a/drivers/spi/mxc_spi.c +++ b/drivers/spi/mxc_spi.c @@ -662,7 +662,10 @@ static int mxc_spi_release_bus(struct udevice *dev) static int mxc_spi_set_speed(struct udevice *bus, uint speed) { - /* Nothing to do */ + struct mxc_spi_slave *mxcs = dev_get_platdata(bus); + + mxcs->max_hz = speed; + return 0; }
The set_speed() callback should configure the bus speed, make it so. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Jagan Teki <jagan@amarulasolutions.com> Cc: Stefano Babic <sbabic@denx.de> --- drivers/spi/mxc_spi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)