diff mbox series

[RESEND] ARM: imx: Add missing FEC ethernet quirk for MX8M

Message ID 20210225210226.730071-1-marex@denx.de
State Accepted
Commit fb4c3387bcc467277eb9297a92e92520b3829b3f
Delegated to: Stefano Babic
Headers show
Series [RESEND] ARM: imx: Add missing FEC ethernet quirk for MX8M | expand

Commit Message

Marek Vasut Feb. 25, 2021, 9:02 p.m. UTC
The MX8M also contains a gigabit MAC, so define FEC_QUIRK_ENET_MAC.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Stefano Babic <sbabic@denx.de>
---
 arch/arm/include/asm/arch-imx8m/imx-regs.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Fabio Estevam Feb. 25, 2021, 9:22 p.m. UTC | #1
Hi Marek,

On Thu, Feb 25, 2021 at 6:02 PM Marek Vasut <marex@denx.de> wrote:
>
> The MX8M also contains a gigabit MAC, so define FEC_QUIRK_ENET_MAC.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>

Thanks for the fix:

Reviewed-by: Fabio Estevam <festevam@gmail.com>
Marek Vasut Feb. 25, 2021, 11:21 p.m. UTC | #2
On 2/25/21 10:22 PM, Fabio Estevam wrote:
> Hi Marek,
> 
> On Thu, Feb 25, 2021 at 6:02 PM Marek Vasut <marex@denx.de> wrote:
>>
>> The MX8M also contains a gigabit MAC, so define FEC_QUIRK_ENET_MAC.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Fabio Estevam <festevam@gmail.com>
>> Cc: Peng Fan <peng.fan@nxp.com>
>> Cc: Stefano Babic <sbabic@denx.de>
> 
> Thanks for the fix:
> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>

Sure, thanks for the RB.

There is similar fix for the other IMX8Q/X by Oleksandr too. It should 
be applied as well.
Fabio Estevam Feb. 25, 2021, 11:29 p.m. UTC | #3
On Thu, Feb 25, 2021 at 8:21 PM Marek Vasut <marex@denx.de> wrote:

> There is similar fix for the other IMX8Q/X by Oleksandr too. It should
> be applied as well.

Yes, I reviewed that one too. I think Stefano will apply it for the
upcoming 2021.04 release.

Thanks
Marek Vasut Feb. 25, 2021, 11:34 p.m. UTC | #4
On 2/26/21 12:29 AM, Fabio Estevam wrote:
> On Thu, Feb 25, 2021 at 8:21 PM Marek Vasut <marex@denx.de> wrote:
> 
>> There is similar fix for the other IMX8Q/X by Oleksandr too. It should
>> be applied as well.
> 
> Yes, I reviewed that one too. I think Stefano will apply it for the
> upcoming 2021.04 release.

Yes
Stefano Babic March 1, 2021, 11:55 a.m. UTC | #5
> The MX8M also contains a gigabit MAC, so define FEC_QUIRK_ENET_MAC.
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/arch/arm/include/asm/arch-imx8m/imx-regs.h b/arch/arm/include/asm/arch-imx8m/imx-regs.h
index f5711155b70..3f500146185 100644
--- a/arch/arm/include/asm/arch-imx8m/imx-regs.h
+++ b/arch/arm/include/asm/arch-imx8m/imx-regs.h
@@ -63,6 +63,7 @@ 
 #define DDR_CSD1_BASE_ADDR	0x40000000
 
 #define IOMUXC_GPR_GPR1_GPR_ENET_QOS_INTF_SEL_MASK 0x70000
+#define FEC_QUIRK_ENET_MAC
 
 #if !defined(__ASSEMBLY__)
 #include <asm/types.h>