| Message ID | 20210223103542.1386572-2-sjg@chromium.org |
|---|---|
| State | Accepted |
| Delegated to: | Bin Meng |
| Headers | show |
| Series | [1/3] x86: Fix member check in intel_gnvs | expand |
On Tue, Feb 23, 2021 at 6:35 PM Simon Glass <sjg@chromium.org> wrote: > > This option is better placed in the x86 code since it is not generic > enough to be in the core code. Move it. > > Reported-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > arch/x86/Kconfig | 9 +++++++++ > drivers/core/Kconfig | 9 --------- > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index eddf2a774ef..c8ce2fcb88d 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -1001,6 +1001,15 @@ config PCIEX_LENGTH_128MB > config PCIEX_LENGTH_64MB > bool > > +config INTEL_ACPIGEN > + bool "Support ACPI table generation for Intel SoCs" > + depends on ACPIGEN > + help > + This option adds some functions used for programatic generation of typo: programmatic Will fix when applying > + ACPI tables on Intel SoCs. This provides features for writing CPU > + information such as P states and T stages. Also included is a way > + to create a GNVS table and set it up. > + > config INTEL_GMA_ACPI > bool "Generate ACPI table for Intel GMA graphics" > help Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Thu, Feb 25, 2021 at 9:25 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > On Tue, Feb 23, 2021 at 6:35 PM Simon Glass <sjg@chromium.org> wrote: > > > > This option is better placed in the x86 code since it is not generic > > enough to be in the core code. Move it. > > > > Reported-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > > Signed-off-by: Simon Glass <sjg@chromium.org> > > --- > > > > arch/x86/Kconfig | 9 +++++++++ > > drivers/core/Kconfig | 9 --------- > > 2 files changed, 9 insertions(+), 9 deletions(-) > > > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > > index eddf2a774ef..c8ce2fcb88d 100644 > > --- a/arch/x86/Kconfig > > +++ b/arch/x86/Kconfig > > @@ -1001,6 +1001,15 @@ config PCIEX_LENGTH_128MB > > config PCIEX_LENGTH_64MB > > bool > > > > +config INTEL_ACPIGEN > > + bool "Support ACPI table generation for Intel SoCs" > > + depends on ACPIGEN > > + help > > + This option adds some functions used for programatic generation of > > typo: programmatic > > Will fix when applying Fixed the typo, and > > > + ACPI tables on Intel SoCs. This provides features for writing CPU > > + information such as P states and T stages. Also included is a way > > + to create a GNVS table and set it up. > > + > > config INTEL_GMA_ACPI > > bool "Generate ACPI table for Intel GMA graphics" > > help > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> applied to u-boot-x86, thanks!
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index eddf2a774ef..c8ce2fcb88d 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -1001,6 +1001,15 @@ config PCIEX_LENGTH_128MB config PCIEX_LENGTH_64MB bool +config INTEL_ACPIGEN + bool "Support ACPI table generation for Intel SoCs" + depends on ACPIGEN + help + This option adds some functions used for programatic generation of + ACPI tables on Intel SoCs. This provides features for writing CPU + information such as P states and T stages. Also included is a way + to create a GNVS table and set it up. + config INTEL_GMA_ACPI bool "Generate ACPI table for Intel GMA graphics" help diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig index 00554af4995..1eccac28c62 100644 --- a/drivers/core/Kconfig +++ b/drivers/core/Kconfig @@ -329,15 +329,6 @@ config ACPIGEN things like generating device-specific tables and returning the ACPI name of a device. -config INTEL_ACPIGEN - bool "Support ACPI table generation for Intel SoCs" - depends on ACPIGEN - help - This option adds some functions used for programatic generation of - ACPI tables on Intel SoCs. This provides features for writing CPU - information such as P states and T stages. Also included is a way - to create a GNVS table and set it up. - config BOUNCE_BUFFER bool "Include bounce buffer API" help
This option is better placed in the x86 code since it is not generic enough to be in the core code. Move it. Reported-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Signed-off-by: Simon Glass <sjg@chromium.org> --- arch/x86/Kconfig | 9 +++++++++ drivers/core/Kconfig | 9 --------- 2 files changed, 9 insertions(+), 9 deletions(-)