Message ID | 20210124161943.13106-1-agriveaux@deutnet.info |
---|---|
State | Rejected |
Delegated to: | Andre Przywara |
Headers | show |
Series | sunxi: board: Splitting CHIP defconfig for nand. | expand |
On 24/01/2021 16:19, Alexandre GRIVEAUX wrote: Hi Alexandre, (CCing: Kory, plus using Maxime's and Boris' newer emails) > This patch split CHIP defconfig to add nand 4G and 8G support. > > Some CONFIG was put at the end of defconfig to ease comparison between: > - CHIP Pro > - CHIP with Toshiba 4G > - CHIP with Hynix 8G > > Witch are essentialy the same board with differents nand and memory. > > Values was taken from now defunct compagny script "chip-update-firmware.sh" Mmh, I am puzzled how this is supposed to work? I thought that the NAND in the non-Pro version was not supported (MLC?). So booting via USB was the only option? Has this changed? Can someone confirm that this works? Cheers, Andre > Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info> > --- > ...CHIP_defconfig => CHIP_Hynix_8G_defconfig} | 21 +++++++++--- > configs/CHIP_Toshiba_4G_defconfig | 32 +++++++++++++++++++ > 2 files changed, 49 insertions(+), 4 deletions(-) > rename configs/{CHIP_defconfig => CHIP_Hynix_8G_defconfig} (50%) > create mode 100644 configs/CHIP_Toshiba_4G_defconfig > > diff --git a/configs/CHIP_defconfig b/configs/CHIP_Hynix_8G_defconfig > similarity index 50% > rename from configs/CHIP_defconfig > rename to configs/CHIP_Hynix_8G_defconfig > index a70ee31d40..4d04a2798e 100644 > --- a/configs/CHIP_defconfig > +++ b/configs/CHIP_Hynix_8G_defconfig > @@ -4,16 +4,29 @@ CONFIG_SPL=y > CONFIG_MACH_SUN5I=y > CONFIG_DRAM_TIMINGS_DDR3_800E_1066G_1333J=y > CONFIG_USB0_VBUS_PIN="PB10" > -CONFIG_VIDEO_COMPOSITE=y > CONFIG_DEFAULT_DEVICE_TREE="sun5i-r8-chip" > CONFIG_SPL_I2C_SUPPORT=y > -CONFIG_CMD_DFU=y > -CONFIG_CMD_USB_MASS_STORAGE=y > -CONFIG_DFU_RAM=y > +# CONFIG_CMD_FLASH is not set > +CONFIG_CMD_MTDPARTS=y > +CONFIG_MTDIDS_DEFAULT="nand0=sunxi-nand.0" > +CONFIG_MTDPARTS_DEFAULT="mtdparts=sunxi-nand.0:256k(spl),256k(spl-backup),2m(uboot),2m(uboot-backup),-(UBI)" > +CONFIG_ENV_IS_IN_UBI=y > +CONFIG_ENV_UBI_PART="UBI" > +CONFIG_ENV_UBI_VOLUME="uboot-env" > # CONFIG_MMC is not set > +CONFIG_MTD=y > +CONFIG_MTD_RAW_NAND=y > +CONFIG_SYS_NAND_BLOCK_SIZE=0x400000 > +CONFIG_SYS_NAND_PAGE_SIZE=0x4000 > +CONFIG_SYS_NAND_OOBSIZE=0x680 > CONFIG_AXP_ALDO3_VOLT=3300 > CONFIG_AXP_ALDO4_VOLT=3300 > CONFIG_CONS_INDEX=2 > CONFIG_USB_EHCI_HCD=y > CONFIG_USB_OHCI_HCD=y > CONFIG_USB_MUSB_GADGET=y > +CONFIG_USB_FUNCTION_MASS_STORAGE=y > +CONFIG_VIDEO_COMPOSITE=y > +CONFIG_CMD_DFU=y > +CONFIG_CMD_USB_MASS_STORAGE=y > +CONFIG_DFU_RAM=y > diff --git a/configs/CHIP_Toshiba_4G_defconfig b/configs/CHIP_Toshiba_4G_defconfig > new file mode 100644 > index 0000000000..bbc6cd9744 > --- /dev/null > +++ b/configs/CHIP_Toshiba_4G_defconfig > @@ -0,0 +1,32 @@ > +CONFIG_ARM=y > +CONFIG_ARCH_SUNXI=y > +CONFIG_SPL=y > +CONFIG_MACH_SUN5I=y > +CONFIG_DRAM_TIMINGS_DDR3_800E_1066G_1333J=y > +CONFIG_USB0_VBUS_PIN="PB10" > +CONFIG_DEFAULT_DEVICE_TREE="sun5i-r8-chip" > +CONFIG_SPL_I2C_SUPPORT=y > +# CONFIG_CMD_FLASH is not set > +CONFIG_CMD_MTDPARTS=y > +CONFIG_MTDIDS_DEFAULT="nand0=sunxi-nand.0" > +CONFIG_MTDPARTS_DEFAULT="mtdparts=sunxi-nand.0:256k(spl),256k(spl-backup),2m(uboot),2m(uboot-backup),-(UBI)" > +CONFIG_ENV_IS_IN_UBI=y > +CONFIG_ENV_UBI_PART="UBI" > +CONFIG_ENV_UBI_VOLUME="uboot-env" > +# CONFIG_MMC is not set > +CONFIG_MTD=y > +CONFIG_MTD_RAW_NAND=y > +CONFIG_SYS_NAND_BLOCK_SIZE=0x400000 > +CONFIG_SYS_NAND_PAGE_SIZE=0x4000 > +CONFIG_SYS_NAND_OOBSIZE=0x500 > +CONFIG_AXP_ALDO3_VOLT=3300 > +CONFIG_AXP_ALDO4_VOLT=3300 > +CONFIG_CONS_INDEX=2 > +CONFIG_USB_EHCI_HCD=y > +CONFIG_USB_OHCI_HCD=y > +CONFIG_USB_MUSB_GADGET=y > +CONFIG_USB_FUNCTION_MASS_STORAGE=y > +CONFIG_VIDEO_COMPOSITE=y > +CONFIG_CMD_DFU=y > +CONFIG_CMD_USB_MASS_STORAGE=y > +CONFIG_DFU_RAM=y >
On Fri, Feb 19, 2021 at 06:00:13PM +0000, André Przywara wrote: > On 24/01/2021 16:19, Alexandre GRIVEAUX wrote: > > Hi Alexandre, > > (CCing: Kory, plus using Maxime's and Boris' newer emails) > > > This patch split CHIP defconfig to add nand 4G and 8G support. > > > > Some CONFIG was put at the end of defconfig to ease comparison between: > > - CHIP Pro > > - CHIP with Toshiba 4G > > - CHIP with Hynix 8G > > > > Witch are essentialy the same board with differents nand and memory. > > > > Values was taken from now defunct compagny script "chip-update-firmware.sh" > > Mmh, I am puzzled how this is supposed to work? I thought that the NAND > in the non-Pro version was not supported (MLC?). So booting via USB was > the only option? > Has this changed? > > Can someone confirm that this works? The CHIP-Pro is indeed different, it's using a different SoC and NAND (SLC) chip. All the variants of the CHIP use an MLC NAND that isn't supported at all by U-Boot. I would discourage you from merging any MLC NAND related patch until some form of MLC support is merged into U-Boot. Maxime
diff --git a/configs/CHIP_defconfig b/configs/CHIP_Hynix_8G_defconfig similarity index 50% rename from configs/CHIP_defconfig rename to configs/CHIP_Hynix_8G_defconfig index a70ee31d40..4d04a2798e 100644 --- a/configs/CHIP_defconfig +++ b/configs/CHIP_Hynix_8G_defconfig @@ -4,16 +4,29 @@ CONFIG_SPL=y CONFIG_MACH_SUN5I=y CONFIG_DRAM_TIMINGS_DDR3_800E_1066G_1333J=y CONFIG_USB0_VBUS_PIN="PB10" -CONFIG_VIDEO_COMPOSITE=y CONFIG_DEFAULT_DEVICE_TREE="sun5i-r8-chip" CONFIG_SPL_I2C_SUPPORT=y -CONFIG_CMD_DFU=y -CONFIG_CMD_USB_MASS_STORAGE=y -CONFIG_DFU_RAM=y +# CONFIG_CMD_FLASH is not set +CONFIG_CMD_MTDPARTS=y +CONFIG_MTDIDS_DEFAULT="nand0=sunxi-nand.0" +CONFIG_MTDPARTS_DEFAULT="mtdparts=sunxi-nand.0:256k(spl),256k(spl-backup),2m(uboot),2m(uboot-backup),-(UBI)" +CONFIG_ENV_IS_IN_UBI=y +CONFIG_ENV_UBI_PART="UBI" +CONFIG_ENV_UBI_VOLUME="uboot-env" # CONFIG_MMC is not set +CONFIG_MTD=y +CONFIG_MTD_RAW_NAND=y +CONFIG_SYS_NAND_BLOCK_SIZE=0x400000 +CONFIG_SYS_NAND_PAGE_SIZE=0x4000 +CONFIG_SYS_NAND_OOBSIZE=0x680 CONFIG_AXP_ALDO3_VOLT=3300 CONFIG_AXP_ALDO4_VOLT=3300 CONFIG_CONS_INDEX=2 CONFIG_USB_EHCI_HCD=y CONFIG_USB_OHCI_HCD=y CONFIG_USB_MUSB_GADGET=y +CONFIG_USB_FUNCTION_MASS_STORAGE=y +CONFIG_VIDEO_COMPOSITE=y +CONFIG_CMD_DFU=y +CONFIG_CMD_USB_MASS_STORAGE=y +CONFIG_DFU_RAM=y diff --git a/configs/CHIP_Toshiba_4G_defconfig b/configs/CHIP_Toshiba_4G_defconfig new file mode 100644 index 0000000000..bbc6cd9744 --- /dev/null +++ b/configs/CHIP_Toshiba_4G_defconfig @@ -0,0 +1,32 @@ +CONFIG_ARM=y +CONFIG_ARCH_SUNXI=y +CONFIG_SPL=y +CONFIG_MACH_SUN5I=y +CONFIG_DRAM_TIMINGS_DDR3_800E_1066G_1333J=y +CONFIG_USB0_VBUS_PIN="PB10" +CONFIG_DEFAULT_DEVICE_TREE="sun5i-r8-chip" +CONFIG_SPL_I2C_SUPPORT=y +# CONFIG_CMD_FLASH is not set +CONFIG_CMD_MTDPARTS=y +CONFIG_MTDIDS_DEFAULT="nand0=sunxi-nand.0" +CONFIG_MTDPARTS_DEFAULT="mtdparts=sunxi-nand.0:256k(spl),256k(spl-backup),2m(uboot),2m(uboot-backup),-(UBI)" +CONFIG_ENV_IS_IN_UBI=y +CONFIG_ENV_UBI_PART="UBI" +CONFIG_ENV_UBI_VOLUME="uboot-env" +# CONFIG_MMC is not set +CONFIG_MTD=y +CONFIG_MTD_RAW_NAND=y +CONFIG_SYS_NAND_BLOCK_SIZE=0x400000 +CONFIG_SYS_NAND_PAGE_SIZE=0x4000 +CONFIG_SYS_NAND_OOBSIZE=0x500 +CONFIG_AXP_ALDO3_VOLT=3300 +CONFIG_AXP_ALDO4_VOLT=3300 +CONFIG_CONS_INDEX=2 +CONFIG_USB_EHCI_HCD=y +CONFIG_USB_OHCI_HCD=y +CONFIG_USB_MUSB_GADGET=y +CONFIG_USB_FUNCTION_MASS_STORAGE=y +CONFIG_VIDEO_COMPOSITE=y +CONFIG_CMD_DFU=y +CONFIG_CMD_USB_MASS_STORAGE=y +CONFIG_DFU_RAM=y
This patch split CHIP defconfig to add nand 4G and 8G support. Some CONFIG was put at the end of defconfig to ease comparison between: - CHIP Pro - CHIP with Toshiba 4G - CHIP with Hynix 8G Witch are essentialy the same board with differents nand and memory. Values was taken from now defunct compagny script "chip-update-firmware.sh" Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info> --- ...CHIP_defconfig => CHIP_Hynix_8G_defconfig} | 21 +++++++++--- configs/CHIP_Toshiba_4G_defconfig | 32 +++++++++++++++++++ 2 files changed, 49 insertions(+), 4 deletions(-) rename configs/{CHIP_defconfig => CHIP_Hynix_8G_defconfig} (50%) create mode 100644 configs/CHIP_Toshiba_4G_defconfig