| Message ID | 87eehc9f4n.fsf@oldenburg.str.redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | build-many-glibcs.py: Use make -O for more consistent log output | expand |
On 2/19/21 11:49 AM, Florian Weimer via Libc-alpha wrote: > The -O option avoids interleaving (e.g.) compiler error messages > with other build messages, and makes attribute of messages to > commands easier. > > According to my tests, the impact on build time is within the noise. > > --- > scripts/build-many-glibcs.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py > index 071f338cbb..8d97320f6d 100755 > --- a/scripts/build-many-glibcs.py > +++ b/scripts/build-many-glibcs.py > @@ -670,7 +670,7 @@ class Context(object): > > def do_build(self): > """Do the actual build.""" > - cmd = ['make', '-j%d' % self.parallelism] > + cmd = ['make', '-O', '-j%d' % self.parallelism] > subprocess.run(cmd, cwd=self.builddir, check=True) > > def build_host_libraries(self): > LGTM. Defaults to deinterlacing the output from the entire recipe (target). Reviewed-by: Carlos O'Donell <carlos@redhat.com>
diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py index 071f338cbb..8d97320f6d 100755 --- a/scripts/build-many-glibcs.py +++ b/scripts/build-many-glibcs.py @@ -670,7 +670,7 @@ class Context(object): def do_build(self): """Do the actual build.""" - cmd = ['make', '-j%d' % self.parallelism] + cmd = ['make', '-O', '-j%d' % self.parallelism] subprocess.run(cmd, cwd=self.builddir, check=True) def build_host_libraries(self):