| Message ID | 1314706823-16357-1-git-send-email-fabio.estevam@freescale.com |
|---|---|
| State | Superseded |
| Delegated to: | Stefano Babic |
| Headers | show |
On 08/30/2011 02:20 PM, Fabio Estevam wrote: > Avoid the usage of extern in C file as pointed out by checkpatch. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- Applied to u-boot-imx, as a fix, thanks. Best regards, Stefano Babic
On 09/02/2011 09:14 AM, Stefano Babic wrote: > On 08/30/2011 02:20 PM, Fabio Estevam wrote: >> Avoid the usage of extern in C file as pointed out by checkpatch. >> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> >> --- > Hi Fabio, > Applied to u-boot-imx, as a fix, thanks. Sorry, it is not. Your patch introduces warnings for the tx25 board: Configuring for tx25 board... tx25.c: In function 'board_init': tx25.c:145: warning: implicit declaration of function 'mx25_uart1_init_pins' Best regards, Stefano Babic
diff --git a/arch/arm/include/asm/arch-mx27/imx-regs.h b/arch/arm/include/asm/arch-mx27/imx-regs.h index b4b2fe6..0c1cda9 100644 --- a/arch/arm/include/asm/arch-mx27/imx-regs.h +++ b/arch/arm/include/asm/arch-mx27/imx-regs.h @@ -27,6 +27,7 @@ #ifndef __ASSEMBLY__ extern void imx_gpio_mode (int gpio_mode); +extern void mx25_uart1_init_pins(void); #ifdef CONFIG_MXC_UART extern void mx27_uart1_init_pins(void); diff --git a/board/karo/tx25/tx25.c b/board/karo/tx25/tx25.c index 25b99e8..c34672a 100644 --- a/board/karo/tx25/tx25.c +++ b/board/karo/tx25/tx25.c @@ -141,8 +141,6 @@ void tx25_fec_init(void) int board_init() { #ifdef CONFIG_MXC_UART - extern void mx25_uart1_init_pins(void); - mx25_uart1_init_pins(); #endif /* board id for linux */
Avoid the usage of extern in C file as pointed out by checkpatch. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- Changes since v1: - No changes arch/arm/include/asm/arch-mx27/imx-regs.h | 1 + board/karo/tx25/tx25.c | 2 -- 2 files changed, 1 insertions(+), 2 deletions(-)