| Message ID | 20210122110234.2825685-1-geert@linux-m68k.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [resend] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it | expand |
On 1/22/21 3:02 AM, Geert Uytterhoeven wrote: > EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the > user may not want to enable. Fix this by making the test depend on > EXT4_FS instead. > > Fixes: 1cbeab1b242d16fd ("ext4: add kunit test for decoding extended timestamps") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Reviewed-by: Randy Dunlap <rdunlap@infradead.org> Thanks. > --- > Discussion after previous submission at > https://lore.kernel.org/linux-ext4/20201020073740.29081-1-geert@linux-m68k.org/ > --- > fs/ext4/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig > index 619dd35ddd48a973..86699c8cab281cbc 100644 > --- a/fs/ext4/Kconfig > +++ b/fs/ext4/Kconfig > @@ -103,8 +103,7 @@ config EXT4_DEBUG > > config EXT4_KUNIT_TESTS > tristate "KUnit tests for ext4" if !KUNIT_ALL_TESTS > - select EXT4_FS > - depends on KUNIT > + depends on EXT4_FS && KUNIT > default KUNIT_ALL_TESTS > help > This builds the ext4 KUnit tests. >
On Fri, Jan 22, 2021 at 12:02:34PM +0100, Geert Uytterhoeven wrote: > EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the > user may not want to enable. Fix this by making the test depend on > EXT4_FS instead. > > Fixes: 1cbeab1b242d16fd ("ext4: add kunit test for decoding extended timestamps") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Applied, thanks. - Ted
diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig index 619dd35ddd48a973..86699c8cab281cbc 100644 --- a/fs/ext4/Kconfig +++ b/fs/ext4/Kconfig @@ -103,8 +103,7 @@ config EXT4_DEBUG config EXT4_KUNIT_TESTS tristate "KUnit tests for ext4" if !KUNIT_ALL_TESTS - select EXT4_FS - depends on KUNIT + depends on EXT4_FS && KUNIT default KUNIT_ALL_TESTS help This builds the ext4 KUnit tests.
EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the user may not want to enable. Fix this by making the test depend on EXT4_FS instead. Fixes: 1cbeab1b242d16fd ("ext4: add kunit test for decoding extended timestamps") Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- Discussion after previous submission at https://lore.kernel.org/linux-ext4/20201020073740.29081-1-geert@linux-m68k.org/ --- fs/ext4/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)