| Message ID | 20210208145153.422093-1-geert+renesas@glider.be |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: GPIO_MXS should not default to y, unconditionally | expand |
On Mon, Feb 8, 2021 at 3:51 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > Merely enabling CONFIG_COMPILE_TEST should not enable additional code. > To fix this, restrict the automatic enabling of GPIO_MXS to ARCH_MXS, > and ask the user in case of compile-testing. > > Fixes: 6876ca311bfca5d7 ("gpio: mxs: add COMPILE_TEST support for GPIO_MXS") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/gpio/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index 5fdf526fe973da38..412728ff2ab45c0d 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -442,8 +442,9 @@ config GPIO_MXC > select GENERIC_IRQ_CHIP > > config GPIO_MXS > - def_bool y > + bool "Freescale MXS GPIO support" if COMPILE_TEST > depends on ARCH_MXS || COMPILE_TEST > + default y if ARCH_MXS > select GPIO_GENERIC > select GENERIC_IRQ_CHIP > > -- > 2.25.1 > Applied, thanks! Bartosz
On Mon, Feb 8, 2021 at 3:51 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > Merely enabling CONFIG_COMPILE_TEST should not enable additional code. > To fix this, restrict the automatic enabling of GPIO_MXS to ARCH_MXS, > and ask the user in case of compile-testing. > > Fixes: 6876ca311bfca5d7 ("gpio: mxs: add COMPILE_TEST support for GPIO_MXS") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 5fdf526fe973da38..412728ff2ab45c0d 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -442,8 +442,9 @@ config GPIO_MXC select GENERIC_IRQ_CHIP config GPIO_MXS - def_bool y + bool "Freescale MXS GPIO support" if COMPILE_TEST depends on ARCH_MXS || COMPILE_TEST + default y if ARCH_MXS select GPIO_GENERIC select GENERIC_IRQ_CHIP
Merely enabling CONFIG_COMPILE_TEST should not enable additional code. To fix this, restrict the automatic enabling of GPIO_MXS to ARCH_MXS, and ask the user in case of compile-testing. Fixes: 6876ca311bfca5d7 ("gpio: mxs: add COMPILE_TEST support for GPIO_MXS") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/gpio/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)