mbox series

[v5,0/2] PCI: qcom: fix PCIe support on sm8250

Message ID 20210117013114.441973-1-dmitry.baryshkov@linaro.org
Headers show
Series PCI: qcom: fix PCIe support on sm8250 | expand

Message

Dmitry Baryshkov Jan. 17, 2021, 1:31 a.m. UTC
SM8250 platform requires additional clock to be enabled for PCIe to
function. In case it is disabled, PCIe access will result in IOMMU
timeouts. Add device tree binding and driver support for this clock.

Canges since v4:
 - Remove QCOM_PCIE_2_7_0_MAX_CLOCKS define and has_sf_tbu variable.

Changes since v3:
 - Merge clock handling back into qcom_pcie_get_resources_2_7_0().
   Define res->num_clks to the amount of clocks used for this particular
   platform.

Changes since v2:
 - Split this clock handling from qcom_pcie_get_resources_2_7_0()
 - Change comment to point that the clock is required rather than
   optional

Changes since v1:
 - Added Fixes: tags, as respective patches have hit the upstream Linux
   tree.

Comments

Dmitry Baryshkov Jan. 26, 2021, 8:11 p.m. UTC | #1
Rob, Lorenzo, gracious poke for this patchset.


On 17/01/2021 04:31, Dmitry Baryshkov wrote:
> SM8250 platform requires additional clock to be enabled for PCIe to
> function. In case it is disabled, PCIe access will result in IOMMU
> timeouts. Add device tree binding and driver support for this clock.
> 
> Canges since v4:
>   - Remove QCOM_PCIE_2_7_0_MAX_CLOCKS define and has_sf_tbu variable.
> 
> Changes since v3:
>   - Merge clock handling back into qcom_pcie_get_resources_2_7_0().
>     Define res->num_clks to the amount of clocks used for this particular
>     platform.
> 
> Changes since v2:
>   - Split this clock handling from qcom_pcie_get_resources_2_7_0()
>   - Change comment to point that the clock is required rather than
>     optional
> 
> Changes since v1:
>   - Added Fixes: tags, as respective patches have hit the upstream Linux
>     tree.
> 
>
Dmitry Baryshkov Feb. 4, 2021, 3:06 p.m. UTC | #2
On Tue, 26 Jan 2021 at 23:11, Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> Rob, Lorenzo, gracious poke for this patchset.

Dear colleagues, another gracious ping. I'm not insisting on getting
this into 5.12 (it would be good though), but I'd kindly ask for these
patches to be reviewed/acked.

> On 17/01/2021 04:31, Dmitry Baryshkov wrote:
> > SM8250 platform requires additional clock to be enabled for PCIe to
> > function. In case it is disabled, PCIe access will result in IOMMU
> > timeouts. Add device tree binding and driver support for this clock.
> >
> > Canges since v4:
> >   - Remove QCOM_PCIE_2_7_0_MAX_CLOCKS define and has_sf_tbu variable.
> >
> > Changes since v3:
> >   - Merge clock handling back into qcom_pcie_get_resources_2_7_0().
> >     Define res->num_clks to the amount of clocks used for this particular
> >     platform.
> >
> > Changes since v2:
> >   - Split this clock handling from qcom_pcie_get_resources_2_7_0()
> >   - Change comment to point that the clock is required rather than
> >     optional
> >
> > Changes since v1:
> >   - Added Fixes: tags, as respective patches have hit the upstream Linux
> >     tree.
> >
> >
>
>
> --
> With best wishes
> Dmitry
Lorenzo Pieralisi Feb. 4, 2021, 5:02 p.m. UTC | #3
[+Stanimir]

On Thu, Feb 04, 2021 at 06:06:16PM +0300, Dmitry Baryshkov wrote:
> On Tue, 26 Jan 2021 at 23:11, Dmitry Baryshkov
> <dmitry.baryshkov@linaro.org> wrote:
> >
> > Rob, Lorenzo, gracious poke for this patchset.
> 
> Dear colleagues, another gracious ping. I'm not insisting on getting
> this into 5.12 (it would be good though), but I'd kindly ask for these
> patches to be reviewed/acked.

I need an ACK from the maintainer(s) to pull them.

Thanks,
Lorenzo

> > On 17/01/2021 04:31, Dmitry Baryshkov wrote:
> > > SM8250 platform requires additional clock to be enabled for PCIe to
> > > function. In case it is disabled, PCIe access will result in IOMMU
> > > timeouts. Add device tree binding and driver support for this clock.
> > >
> > > Canges since v4:
> > >   - Remove QCOM_PCIE_2_7_0_MAX_CLOCKS define and has_sf_tbu variable.
> > >
> > > Changes since v3:
> > >   - Merge clock handling back into qcom_pcie_get_resources_2_7_0().
> > >     Define res->num_clks to the amount of clocks used for this particular
> > >     platform.
> > >
> > > Changes since v2:
> > >   - Split this clock handling from qcom_pcie_get_resources_2_7_0()
> > >   - Change comment to point that the clock is required rather than
> > >     optional
> > >
> > > Changes since v1:
> > >   - Added Fixes: tags, as respective patches have hit the upstream Linux
> > >     tree.
> > >
> > >
> >
> >
> > --
> > With best wishes
> > Dmitry
> 
> 
> 
> -- 
> With best wishes
> Dmitry
Lorenzo Pieralisi Feb. 5, 2021, 5:10 p.m. UTC | #4
On Sun, 17 Jan 2021 04:31:12 +0300, Dmitry Baryshkov wrote:
> SM8250 platform requires additional clock to be enabled for PCIe to
> function. In case it is disabled, PCIe access will result in IOMMU
> timeouts. Add device tree binding and driver support for this clock.
> 
> Canges since v4:
>  - Remove QCOM_PCIE_2_7_0_MAX_CLOCKS define and has_sf_tbu variable.
> 
> [...]

Applied to pci/qcom, thanks!

[1/2] dt-bindings: pci: qcom: Document ddrss_sf_tbu clock for sm8250
      https://git.kernel.org/lpieralisi/pci/c/a8069a4831
[2/2] PCI: qcom: add support for ddrss_sf_tbu clock
      https://git.kernel.org/lpieralisi/pci/c/f5d48a3328

Thanks,
Lorenzo
Dmitry Baryshkov Feb. 5, 2021, 5:12 p.m. UTC | #5
On Fri, 5 Feb 2021 at 20:11, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
>
> On Sun, 17 Jan 2021 04:31:12 +0300, Dmitry Baryshkov wrote:
> > SM8250 platform requires additional clock to be enabled for PCIe to
> > function. In case it is disabled, PCIe access will result in IOMMU
> > timeouts. Add device tree binding and driver support for this clock.
> >
> > Canges since v4:
> >  - Remove QCOM_PCIE_2_7_0_MAX_CLOCKS define and has_sf_tbu variable.
> >
> > [...]
>
> Applied to pci/qcom, thanks!

Thank you!

>
> [1/2] dt-bindings: pci: qcom: Document ddrss_sf_tbu clock for sm8250
>       https://git.kernel.org/lpieralisi/pci/c/a8069a4831
> [2/2] PCI: qcom: add support for ddrss_sf_tbu clock
>       https://git.kernel.org/lpieralisi/pci/c/f5d48a3328