Message ID | 20110825191843.1413.61848.stgit@ginnungagap.bsc.es |
---|---|
State | New |
Headers | show |
On Thu, Aug 25, 2011 at 09:18:43PM +0200, Lluís wrote: > Note that this refers to the backend-specific state (whether the output must be > generated), not the event "disabled" property (which always uses the "nop" > backend). > > Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu> > --- > scripts/tracetool | 9 ++------- > trace-events | 3 --- > 2 files changed, 2 insertions(+), 10 deletions(-) At this point the quickstart in docs/tracing.txt may be confusing since QEMU runs as normal but no events are recorded :). Please add a step before launching QEMU that creates a simple events file, like: bdrv_aio_readv bdrv_aio_writev This way people looking at the quickstart know they need to choose events that they would like to record and use -trace events=my-events. Stefan
diff --git a/scripts/tracetool b/scripts/tracetool index e2cf117..c740080 100755 --- a/scripts/tracetool +++ b/scripts/tracetool @@ -221,15 +221,10 @@ EOF linetoc_simple() { - local name state + local name name=$(get_name "$1") - if has_property "$1" "disable"; then - state="0" - else - state="1" - fi cat <<EOF -{.tp_name = "$name", .state=$state}, +{.tp_name = "$name", .state=0}, EOF simple_event_num=$((simple_event_num + 1)) } diff --git a/trace-events b/trace-events index bb9de79..6d7d346 100644 --- a/trace-events +++ b/trace-events @@ -17,9 +17,6 @@ # Example: qemu_malloc(size_t size) "size %zu" # # The "disable" keyword will build without the trace event. -# In case of 'simple' trace backend, it will allow the trace event to be -# compiled, but this would be turned off by default. It can be toggled on via -# the monitor. # # The <name> must be a valid as a C function name. #
Note that this refers to the backend-specific state (whether the output must be generated), not the event "disabled" property (which always uses the "nop" backend). Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu> --- scripts/tracetool | 9 ++------- trace-events | 3 --- 2 files changed, 2 insertions(+), 10 deletions(-)