| Message ID | 20210121172829.1643620-3-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | gitlab-ci: Test linux-user on CentOS 7 | expand |
Hi, On 1/21/21 2:28 PM, Philippe Mathieu-Daudé wrote: > Add a configuration tested by Peter Maydell (see [1] and [2]) > but not covered in our CI [3]: > > [705/2910] Compiling C object libqemu-arm-linux-user.fa.p/linux-user_strace.c.o > FAILED: libqemu-arm-linux-user.fa.p/linux-user_strace.c.o > ../linux-user/strace.c: In function 'do_print_sockopt': > ../linux-user/strace.c:2831:14: error: 'IPV6_ADDR_PREFERENCES' undeclared (first use in this function) > case IPV6_ADDR_PREFERENCES: Why the following builder did not catch that issue? build-user: <<: *native_build_job_definition variables: IMAGE: debian-all-test-cross CONFIGURE_ARGS: --disable-tools --disable-system MAKE_CHECK_ARGS: check-tcg > ^ > > This job currently takes 31 minutes 32 seconds ([4]). > > [1] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05086.html > [2] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05379.html > [3] https://gitlab.com/philmd/qemu/-/jobs/977408284 > [4] https://gitlab.com/philmd/qemu/-/jobs/978223286 > > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > .gitlab-ci.yml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index de3a3d25b58..af4d74757d8 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -411,6 +411,13 @@ build-user-plugins: > MAKE_CHECK_ARGS: check-tcg > timeout: 1h 30m > > +build-user-centos7: > + <<: *native_build_job_definition > + variables: > + IMAGE: centos7 > + CONFIGURE_ARGS: --disable-system --disable-tools --disable-docs > + MAKE_CHECK_ARGS: check-tcg > + > build-some-softmmu-plugins: > <<: *native_build_job_definition > variables:
On Thu, Jan 21, 2021 at 6:45 PM Wainer dos Santos Moschetta <wainersm@redhat.com> wrote: > On 1/21/21 2:28 PM, Philippe Mathieu-Daudé wrote: > > Add a configuration tested by Peter Maydell (see [1] and [2]) > > but not covered in our CI [3]: > > > > [705/2910] Compiling C object libqemu-arm-linux-user.fa.p/linux-user_strace.c.o > > FAILED: libqemu-arm-linux-user.fa.p/linux-user_strace.c.o > > ../linux-user/strace.c: In function 'do_print_sockopt': > > ../linux-user/strace.c:2831:14: error: 'IPV6_ADDR_PREFERENCES' undeclared (first use in this function) > > case IPV6_ADDR_PREFERENCES: > > Why the following builder did not catch that issue? > > build-user: > <<: *native_build_job_definition > variables: > IMAGE: debian-all-test-cross > CONFIGURE_ARGS: --disable-tools --disable-system > MAKE_CHECK_ARGS: check-tcg It uses a different base image, debian-all-test-cross, which is based on Debian 10. Packages are more recent than CentOS 7. QEMU aims to support the 2 latest releases from major distribs. CentOS 7 is likely the oldest.
On 21/01/2021 18.28, Philippe Mathieu-Daudé wrote: > Add a configuration tested by Peter Maydell (see [1] and [2]) > but not covered in our CI [3]: > > [705/2910] Compiling C object libqemu-arm-linux-user.fa.p/linux-user_strace.c.o > FAILED: libqemu-arm-linux-user.fa.p/linux-user_strace.c.o > ../linux-user/strace.c: In function 'do_print_sockopt': > ../linux-user/strace.c:2831:14: error: 'IPV6_ADDR_PREFERENCES' undeclared (first use in this function) > case IPV6_ADDR_PREFERENCES: > ^ > > This job currently takes 31 minutes 32 seconds ([4]). > > [1] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05086.html > [2] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05379.html > [3] https://gitlab.com/philmd/qemu/-/jobs/977408284 > [4] https://gitlab.com/philmd/qemu/-/jobs/978223286 > > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > .gitlab-ci.yml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index de3a3d25b58..af4d74757d8 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -411,6 +411,13 @@ build-user-plugins: > MAKE_CHECK_ARGS: check-tcg > timeout: 1h 30m > > +build-user-centos7: > + <<: *native_build_job_definition > + variables: > + IMAGE: centos7 > + CONFIGURE_ARGS: --disable-system --disable-tools --disable-docs > + MAKE_CHECK_ARGS: check-tcg > + > build-some-softmmu-plugins: > <<: *native_build_job_definition > variables: > Reviewed-by: Thomas Huth <thuth@redhat.com>
On 1/21/21 3:20 PM, Philippe Mathieu-Daudé wrote: > On Thu, Jan 21, 2021 at 6:45 PM Wainer dos Santos Moschetta > <wainersm@redhat.com> wrote: >> On 1/21/21 2:28 PM, Philippe Mathieu-Daudé wrote: >>> Add a configuration tested by Peter Maydell (see [1] and [2]) >>> but not covered in our CI [3]: >>> >>> [705/2910] Compiling C object libqemu-arm-linux-user.fa.p/linux-user_strace.c.o >>> FAILED: libqemu-arm-linux-user.fa.p/linux-user_strace.c.o >>> ../linux-user/strace.c: In function 'do_print_sockopt': >>> ../linux-user/strace.c:2831:14: error: 'IPV6_ADDR_PREFERENCES' undeclared (first use in this function) >>> case IPV6_ADDR_PREFERENCES: >> Why the following builder did not catch that issue? >> >> build-user: >> <<: *native_build_job_definition >> variables: >> IMAGE: debian-all-test-cross >> CONFIGURE_ARGS: --disable-tools --disable-system >> MAKE_CHECK_ARGS: check-tcg > It uses a different base image, debian-all-test-cross, which is based > on Debian 10. > > Packages are more recent than CentOS 7. > QEMU aims to support the 2 latest releases from major distribs. > CentOS 7 is likely the oldest. Oh sorry, my emails filters aren't working fine so I missed Daniel's reply on talking about it. Thanks for explaining again. :) - Wainer >
On 1/21/21 2:28 PM, Philippe Mathieu-Daudé wrote: > Add a configuration tested by Peter Maydell (see [1] and [2]) > but not covered in our CI [3]: > > [705/2910] Compiling C object libqemu-arm-linux-user.fa.p/linux-user_strace.c.o > FAILED: libqemu-arm-linux-user.fa.p/linux-user_strace.c.o > ../linux-user/strace.c: In function 'do_print_sockopt': > ../linux-user/strace.c:2831:14: error: 'IPV6_ADDR_PREFERENCES' undeclared (first use in this function) > case IPV6_ADDR_PREFERENCES: > ^ > > This job currently takes 31 minutes 32 seconds ([4]). > > [1] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05086.html > [2] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05379.html > [3] https://gitlab.com/philmd/qemu/-/jobs/977408284 > [4] https://gitlab.com/philmd/qemu/-/jobs/978223286 > > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > .gitlab-ci.yml | 7 +++++++ > 1 file changed, 7 insertions(+) Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com> > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index de3a3d25b58..af4d74757d8 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -411,6 +411,13 @@ build-user-plugins: > MAKE_CHECK_ARGS: check-tcg > timeout: 1h 30m > > +build-user-centos7: > + <<: *native_build_job_definition > + variables: > + IMAGE: centos7 > + CONFIGURE_ARGS: --disable-system --disable-tools --disable-docs > + MAKE_CHECK_ARGS: check-tcg > + > build-some-softmmu-plugins: > <<: *native_build_job_definition > variables:
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index de3a3d25b58..af4d74757d8 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -411,6 +411,13 @@ build-user-plugins: MAKE_CHECK_ARGS: check-tcg timeout: 1h 30m +build-user-centos7: + <<: *native_build_job_definition + variables: + IMAGE: centos7 + CONFIGURE_ARGS: --disable-system --disable-tools --disable-docs + MAKE_CHECK_ARGS: check-tcg + build-some-softmmu-plugins: <<: *native_build_job_definition variables:
Add a configuration tested by Peter Maydell (see [1] and [2]) but not covered in our CI [3]: [705/2910] Compiling C object libqemu-arm-linux-user.fa.p/linux-user_strace.c.o FAILED: libqemu-arm-linux-user.fa.p/linux-user_strace.c.o ../linux-user/strace.c: In function 'do_print_sockopt': ../linux-user/strace.c:2831:14: error: 'IPV6_ADDR_PREFERENCES' undeclared (first use in this function) case IPV6_ADDR_PREFERENCES: ^ This job currently takes 31 minutes 32 seconds ([4]). [1] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05086.html [2] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05379.html [3] https://gitlab.com/philmd/qemu/-/jobs/977408284 [4] https://gitlab.com/philmd/qemu/-/jobs/978223286 Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- .gitlab-ci.yml | 7 +++++++ 1 file changed, 7 insertions(+)