| Message ID | 20210120214547.89770-5-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/5] lib/cmdline_kunit: add a new test case for get_options() | expand |
On Wed, Jan 20, 2021 at 10:45 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > Remove trailing comma in terminator entries to avoid potential > expanding an array behind it. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Thu, Jan 21, 2021 at 02:17:47PM +0100, Linus Walleij wrote: > On Wed, Jan 20, 2021 at 10:45 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > Remove trailing comma in terminator entries to avoid potential > > expanding an array behind it. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Thanks! Bart, I would like to send this series as a part of my Intel GPIO PR or tell me if you wish another approach.
On Thu, Jan 21, 2021 at 6:08 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Thu, Jan 21, 2021 at 02:17:47PM +0100, Linus Walleij wrote: > > On Wed, Jan 20, 2021 at 10:45 PM Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> wrote: > > > > > Remove trailing comma in terminator entries to avoid potential > > > expanding an array behind it. > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Thanks! > > Bart, I would like to send this series as a part of my Intel GPIO PR or tell me > if you wish another approach. > > -- > With Best Regards, > Andy Shevchenko > > No that's fine. Bart
On Wed, Jan 20, 2021 at 10:45 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > Remove trailing comma in terminator entries to avoid potential > expanding an array behind it. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/gpio/gpio-aggregator.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c > index 40a081b095fb..0cab833fbd81 100644 > --- a/drivers/gpio/gpio-aggregator.c > +++ b/drivers/gpio/gpio-aggregator.c > @@ -244,7 +244,7 @@ static DRIVER_ATTR_WO(delete_device); > static struct attribute *gpio_aggregator_attrs[] = { > &driver_attr_new_device.attr, > &driver_attr_delete_device.attr, > - NULL, > + NULL > }; > ATTRIBUTE_GROUPS(gpio_aggregator); > > @@ -518,7 +518,7 @@ static const struct of_device_id gpio_aggregator_dt_ids[] = { > * Add GPIO-operated devices controlled from userspace below, > * or use "driver_override" in sysfs > */ > - {}, > + {} > }; > MODULE_DEVICE_TABLE(of, gpio_aggregator_dt_ids); > #endif > -- > 2.29.2 > Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
On Wed, Jan 20, 2021 at 10:45 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > Remove trailing comma in terminator entries to avoid potential > expanding an array behind it. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c index 40a081b095fb..0cab833fbd81 100644 --- a/drivers/gpio/gpio-aggregator.c +++ b/drivers/gpio/gpio-aggregator.c @@ -244,7 +244,7 @@ static DRIVER_ATTR_WO(delete_device); static struct attribute *gpio_aggregator_attrs[] = { &driver_attr_new_device.attr, &driver_attr_delete_device.attr, - NULL, + NULL }; ATTRIBUTE_GROUPS(gpio_aggregator); @@ -518,7 +518,7 @@ static const struct of_device_id gpio_aggregator_dt_ids[] = { * Add GPIO-operated devices controlled from userspace below, * or use "driver_override" in sysfs */ - {}, + {} }; MODULE_DEVICE_TABLE(of, gpio_aggregator_dt_ids); #endif
Remove trailing comma in terminator entries to avoid potential expanding an array behind it. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/gpio-aggregator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)