| Message ID | 20210116145343.1.I87d41cd95212f8a8f7c601b00cd64d5192a73f8e@changeid |
|---|---|
| State | Superseded |
| Delegated to: | Bin Meng |
| Headers | show |
| Series | x86: Minor improvements mostly for image loading | expand |
Hi Simon, On Sun, Jan 17, 2021 at 5:54 AM Simon Glass <sjg@chromium.org> wrote: > > Use a driver name in line with the compatible string so that of-platdata > can use this driver. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > arch/x86/cpu/acpi_gpe.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/cpu/acpi_gpe.c b/arch/x86/cpu/acpi_gpe.c > index 83128c33c2c..da01e71335f 100644 > --- a/arch/x86/cpu/acpi_gpe.c > +++ b/arch/x86/cpu/acpi_gpe.c > @@ -4,6 +4,8 @@ > * Written by Simon Glass <sjg@chromium.org> > */ > > +#define LOG_CATEGORY UCLASS_IRQ > + > #include <common.h> > #include <dm.h> > #include <irq.h> > @@ -102,8 +104,8 @@ static const struct udevice_id acpi_gpe_ids[] = { > { } > }; > > -U_BOOT_DRIVER(acpi_gpe_drv) = { > - .name = "acpi_gpe", > +U_BOOT_DRIVER(intel_acpi_gpe) = { Why adding an intel_ prefix? > + .name = "intel_acpi_gpe", > .id = UCLASS_IRQ, > .of_match = acpi_gpe_ids, > .ops = &acpi_gpe_ops, > -- Regards, Bin
Hi Bin, On Wed, 20 Jan 2021 at 20:19, Bin Meng <bmeng.cn@gmail.com> wrote: > > Hi Simon, > > On Sun, Jan 17, 2021 at 5:54 AM Simon Glass <sjg@chromium.org> wrote: > > > > Use a driver name in line with the compatible string so that of-platdata > > can use this driver. > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > --- > > > > arch/x86/cpu/acpi_gpe.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/arch/x86/cpu/acpi_gpe.c b/arch/x86/cpu/acpi_gpe.c > > index 83128c33c2c..da01e71335f 100644 > > --- a/arch/x86/cpu/acpi_gpe.c > > +++ b/arch/x86/cpu/acpi_gpe.c > > @@ -4,6 +4,8 @@ > > * Written by Simon Glass <sjg@chromium.org> > > */ > > > > +#define LOG_CATEGORY UCLASS_IRQ > > + > > #include <common.h> > > #include <dm.h> > > #include <irq.h> > > @@ -102,8 +104,8 @@ static const struct udevice_id acpi_gpe_ids[] = { > > { } > > }; > > > > -U_BOOT_DRIVER(acpi_gpe_drv) = { > > - .name = "acpi_gpe", > > +U_BOOT_DRIVER(intel_acpi_gpe) = { > > Why adding an intel_ prefix? This is to match the compatible string intel,acpi-gpe so that of--platdata works correctly. > > > + .name = "intel_acpi_gpe", > > .id = UCLASS_IRQ, > > .of_match = acpi_gpe_ids, > > .ops = &acpi_gpe_ops, > > -- Regards, Simon
On Thu, Jan 21, 2021 at 11:26 AM Simon Glass <sjg@chromium.org> wrote: > > Hi Bin, > > On Wed, 20 Jan 2021 at 20:19, Bin Meng <bmeng.cn@gmail.com> wrote: > > > > Hi Simon, > > > > On Sun, Jan 17, 2021 at 5:54 AM Simon Glass <sjg@chromium.org> wrote: > > > > > > Use a driver name in line with the compatible string so that of-platdata > > > can use this driver. > > > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > > --- > > > > > > arch/x86/cpu/acpi_gpe.c | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/x86/cpu/acpi_gpe.c b/arch/x86/cpu/acpi_gpe.c > > > index 83128c33c2c..da01e71335f 100644 > > > --- a/arch/x86/cpu/acpi_gpe.c > > > +++ b/arch/x86/cpu/acpi_gpe.c > > > @@ -4,6 +4,8 @@ > > > * Written by Simon Glass <sjg@chromium.org> > > > */ > > > > > > +#define LOG_CATEGORY UCLASS_IRQ > > > + > > > #include <common.h> > > > #include <dm.h> > > > #include <irq.h> > > > @@ -102,8 +104,8 @@ static const struct udevice_id acpi_gpe_ids[] = { > > > { } > > > }; > > > > > > -U_BOOT_DRIVER(acpi_gpe_drv) = { > > > - .name = "acpi_gpe", > > > +U_BOOT_DRIVER(intel_acpi_gpe) = { > > > > Why adding an intel_ prefix? > > This is to match the compatible string intel,acpi-gpe so that > of--platdata works correctly. Ah, yes, so, Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff --git a/arch/x86/cpu/acpi_gpe.c b/arch/x86/cpu/acpi_gpe.c index 83128c33c2c..da01e71335f 100644 --- a/arch/x86/cpu/acpi_gpe.c +++ b/arch/x86/cpu/acpi_gpe.c @@ -4,6 +4,8 @@ * Written by Simon Glass <sjg@chromium.org> */ +#define LOG_CATEGORY UCLASS_IRQ + #include <common.h> #include <dm.h> #include <irq.h> @@ -102,8 +104,8 @@ static const struct udevice_id acpi_gpe_ids[] = { { } }; -U_BOOT_DRIVER(acpi_gpe_drv) = { - .name = "acpi_gpe", +U_BOOT_DRIVER(intel_acpi_gpe) = { + .name = "intel_acpi_gpe", .id = UCLASS_IRQ, .of_match = acpi_gpe_ids, .ops = &acpi_gpe_ops,
Use a driver name in line with the compatible string so that of-platdata can use this driver. Signed-off-by: Simon Glass <sjg@chromium.org> --- arch/x86/cpu/acpi_gpe.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)