| Message ID | 20210104101054.5392-1-jubalh@iodoru.org |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/1] package/libstrophe: bump to version 0.10.1 | expand |
Hello Michael, On Mon, 4 Jan 2021 11:10:54 +0100 Michael Vetter <jubalh@iodoru.org> wrote: > Changes: > * Fixed compilation error when LibreSSL is used > * Fixed crash when NULL is provided as password > > Signed-off-by: Michael Vetter <jubalh@iodoru.org> Thanks a lot for the patch, but it doesn't work here, I don't get the same hash as you do for the download. Could you check this on your side ? Here is what I get: ERROR: libstrophe-0.10.1.tar.gz has wrong sha256 hash: ERROR: expected: 4918c47029ecdea2deab4b0f9336ca4a8bb12c28b72b2cec397d98664b94c771 ERROR: got : 5bf0bbc555cb6059008f1b748370d4d2ee1e1fabd3eeab68475263556405ba39 ERROR: Incomplete download, or man-in-the-middle (MITM) attack Best regards, Thomas
Hello Thomas, On Tue, 19 Jan 2021 22:14:30 +0100 Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > Hello Michael, > > On Mon, 4 Jan 2021 11:10:54 +0100 > Michael Vetter <jubalh@iodoru.org> wrote: > > > Changes: > > * Fixed compilation error when LibreSSL is used > > * Fixed crash when NULL is provided as password > > > > Signed-off-by: Michael Vetter <jubalh@iodoru.org> > > Thanks a lot for the patch, but it doesn't work here, I don't get the > same hash as you do for the download. Could you check this on your > side ? > > Here is what I get: > > ERROR: libstrophe-0.10.1.tar.gz has wrong sha256 hash: > ERROR: expected: > 4918c47029ecdea2deab4b0f9336ca4a8bb12c28b72b2cec397d98664b94c771 > ERROR: got : > 5bf0bbc555cb6059008f1b748370d4d2ee1e1fabd3eeab68475263556405ba39 > ERROR: Incomplete download, or man-in-the-middle (MITM) attack I'm sorry about that. We had some disagreement at JasPer and we removed an existing tag and created the same tag on a different commit. Thus generating a different tarball under the same tag.. I thought I only did the buildroot update after this, but maybe I remember wrong. Would you mind changing the commit to use the new hash? Or should I send a new patch? Best, Michael
diff --git a/package/libstrophe/libstrophe.hash b/package/libstrophe/libstrophe.hash index 5f3b098c89..6aca289fb5 100644 --- a/package/libstrophe/libstrophe.hash +++ b/package/libstrophe/libstrophe.hash @@ -1,4 +1,4 @@ # Locally calculated -sha256 8d804e4c74cea1133203cc95a59a88f700fbdaead076e7959b495d734dd7936d libstrophe-0.10.0.tar.gz +sha256 4918c47029ecdea2deab4b0f9336ca4a8bb12c28b72b2cec397d98664b94c771 libstrophe-0.10.1.tar.gz sha256 82476f36ffd5e895a176013c0812166ba7b7d99f3d536fc7f5ed2e33e9f74a08 MIT-LICENSE.txt sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 GPL-LICENSE.txt diff --git a/package/libstrophe/libstrophe.mk b/package/libstrophe/libstrophe.mk index 81fc1b9f97..e078eb25cd 100644 --- a/package/libstrophe/libstrophe.mk +++ b/package/libstrophe/libstrophe.mk @@ -4,7 +4,7 @@ # ################################################################################ -LIBSTROPHE_VERSION = 0.10.0 +LIBSTROPHE_VERSION = 0.10.1 LIBSTROPHE_SITE = $(call github,strophe,libstrophe,$(LIBSTROPHE_VERSION)) LIBSTROPHE_DEPENDENCIES = openssl host-pkgconf # Doesn't ship configure
Changes: * Fixed compilation error when LibreSSL is used * Fixed crash when NULL is provided as password Signed-off-by: Michael Vetter <jubalh@iodoru.org> --- package/libstrophe/libstrophe.hash | 2 +- package/libstrophe/libstrophe.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)