| Message ID | 20210115153901.31052-1-zajec5@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/3] dt-bindings: mtd: move partition binding to its own file | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | success |
Hi Rafał, Rafał Miłecki <zajec5@gmail.com> wrote on Fri, 15 Jan 2021 16:39:01 +0100: > From: Rafał Miłecki <rafal@milecki.pl> > > BCM4908 partitioning is based on fixed layout but allows specifying > multiple firmware partitions. It requires detecting which firmware > partition was used for booting current kernel. > > To support such cases without duplicating a lot of code (without copying > most of the ofpart.c code) support for post-parsing callback was added. > > BCM4908 callback simply reads offset of currently used firmware > partition from the DT. Bootloader specifies it using the "brcm_blparms" > property. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> The approach looks fine by me, let's see what other maintainers think. Cheers, Miquèl
On Tue, Jan 19, 2021 at 5:01 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > > The approach looks fine by me, let's see what other maintainers think. Same, looks good to me! :-)
On Fri, 15 Jan 2021 16:38:59 +0100, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > Single partition binding is quite common and may be: > 1. Used by multiple parsers > 2. Extended for more specific cases > > Move it to separated file to avoid code duplication. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > .../mtd/partitions/fixed-partitions.yaml | 33 +------------ > .../bindings/mtd/partitions/partition.yaml | 47 +++++++++++++++++++ > 2 files changed, 48 insertions(+), 32 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mtd/partitions/partition.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml b/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml index 6d4a3450e064..ea4cace6a955 100644 --- a/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml +++ b/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml @@ -27,38 +27,7 @@ properties: patternProperties: "@[0-9a-f]+$": - description: node describing a single flash partition - type: object - - properties: - reg: - description: partition's offset and size within the flash - maxItems: 1 - - label: - description: The label / name for this partition. If omitted, the label - is taken from the node name (excluding the unit address). - - read-only: - description: This parameter, if present, is a hint that this partition - should only be mounted read-only. This is usually used for flash - partitions containing early-boot firmware images or data which should - not be clobbered. - type: boolean - - lock: - description: Do not unlock the partition at initialization time (not - supported on all devices) - type: boolean - - slc-mode: - description: This parameter, if present, allows one to emulate SLC mode - on a partition attached to an MLC NAND thus making this partition - immune to paired-pages corruptions - type: boolean - - required: - - reg + $ref: "partition.yaml#" required: - "#address-cells" diff --git a/Documentation/devicetree/bindings/mtd/partitions/partition.yaml b/Documentation/devicetree/bindings/mtd/partitions/partition.yaml new file mode 100644 index 000000000000..e1ac08064425 --- /dev/null +++ b/Documentation/devicetree/bindings/mtd/partitions/partition.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mtd/partitions/partition.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Partition + +description: | + This binding describes a single flash partition. Each partition must have its + relative offset and size specified. Depending on partition function extra + properties can be used. + +maintainers: + - Rafał Miłecki <rafal@milecki.pl> + +properties: + reg: + description: partition's offset and size within the flash + maxItems: 1 + + label: + description: The label / name for this partition. If omitted, the label + is taken from the node name (excluding the unit address). + + read-only: + description: This parameter, if present, is a hint that this partition + should only be mounted read-only. This is usually used for flash + partitions containing early-boot firmware images or data which should + not be clobbered. + type: boolean + + lock: + description: Do not unlock the partition at initialization time (not + supported on all devices) + type: boolean + + slc-mode: + description: This parameter, if present, allows one to emulate SLC mode + on a partition attached to an MLC NAND thus making this partition + immune to paired-pages corruptions + type: boolean + +required: + - reg + +additionalProperties: true