| Message ID | 20210118094635.750975-1-buildroot@heine.tech |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/grpc: drop host gcc 4.8 workaround | expand |
On Mon, 18 Jan 2021 10:46:33 +0100 Michael Nosthoff via buildroot <buildroot@busybox.net> wrote: > Due to libabseil dependencies the host gcc is at least 4.9. > So the fix for host gcc 4.8 is no longer needed. > > Signed-off-by: Michael Nosthoff <buildroot@heine.tech> > --- > package/grpc/grpc.mk | 8 -------- > 1 file changed, 8 deletions(-) Well spotted, applied to master, thanks. Thomas
diff --git a/package/grpc/grpc.mk b/package/grpc/grpc.mk index 8585b6bdc3..f7ddffd386 100644 --- a/package/grpc/grpc.mk +++ b/package/grpc/grpc.mk @@ -72,13 +72,5 @@ HOST_GRPC_CONF_OPTS = \ -DgRPC_SSL_PROVIDER=package \ -DgRPC_ZLIB_PROVIDER=package -# With gcc 4.8 (at least on ubuntu) there is a bug in LTO which breaks -# the linkage of the grpc_cpp_plugin with libprotobuf and pthread. This -# additional flag fixes this. -ifeq ($(BR2_HOST_GCC_AT_LEAST_4_9),) -HOST_GRPC_CONF_OPTS += \ - -DCMAKE_EXE_LINKER_FLAGS="$(HOST_LDFLAGS) -Wl,--no-as-needed" -endif - $(eval $(cmake-package)) $(eval $(host-cmake-package))
Due to libabseil dependencies the host gcc is at least 4.9. So the fix for host gcc 4.8 is no longer needed. Signed-off-by: Michael Nosthoff <buildroot@heine.tech> --- package/grpc/grpc.mk | 8 -------- 1 file changed, 8 deletions(-)