Message ID | 1608718963-21818-9-git-send-email-yoshihiro.shimoda.uh@renesas.com |
---|---|
State | New |
Headers | show |
Series | treewide: bd9571mwv: Add support for BD9574MWF | expand |
On Wed, Dec 23, 2020 at 11:22 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > Add support for BD9574MWF which is similar chip with BD9571MWV. > Note that BD9574MWF has additional features "RECOV_GPOUT", > "FREQSEL" and "RTC_IN", but supports GPIO function only. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Reviewed-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> This looks like it compile-time depends on the other patches right? Yours, Linus Walleij
Hi Linus, > From: Linus Walleij, Sent: Monday, December 28, 2020 6:16 AM > > > Add support for BD9574MWF which is similar chip with BD9571MWV. > > Note that BD9574MWF has additional features "RECOV_GPOUT", > > "FREQSEL" and "RTC_IN", but supports GPIO function only. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Reviewed-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > > Acked-by: Linus Walleij <linus.walleij@linaro.org> Thank you for your Acked-by! I'll add your Acked-by in the next patch version as v9. > This looks like it compile-time depends on the other patches right? You're correct. Best regards, Yoshihiro Shimoda
diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio-bd9571mwv.c index 0e5395f..df6102b 100644 --- a/drivers/gpio/gpio-bd9571mwv.c +++ b/drivers/gpio/gpio-bd9571mwv.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-only /* - * ROHM BD9571MWV-M GPIO driver + * ROHM BD9571MWV-M and BD9574MWF-M GPIO driver * * Copyright (C) 2017 Marek Vasut <marek.vasut+renesas@gmail.com> * @@ -10,6 +10,7 @@ */ #include <linux/gpio/driver.h> +#include <linux/mfd/rohm-generic.h> #include <linux/module.h> #include <linux/platform_device.h> @@ -118,7 +119,8 @@ static int bd9571mwv_gpio_probe(struct platform_device *pdev) } static const struct platform_device_id bd9571mwv_gpio_id_table[] = { - { "bd9571mwv-gpio", }, + { "bd9571mwv-gpio", ROHM_CHIP_TYPE_BD9571 }, + { "bd9574mwf-gpio", ROHM_CHIP_TYPE_BD9574 }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(platform, bd9571mwv_gpio_id_table);