diff mbox series

[3/3] x86: coral: Update the boot script

Message ID 20201109071220.3.I474343b4fba2d055f266958b219e3e3e941c790b@changeid
State Accepted
Commit 1b6314be50df11d9c07ba3c13618bac9df838d07
Delegated to: Bin Meng
Headers show
Series [1/3] x86: coral: Update smbios tables to latest definition | expand

Commit Message

Simon Glass Nov. 9, 2020, 2:12 p.m. UTC
Make use of the new bootargs substitution mechanism and zboot command
syntax.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 include/configs/chromebook_coral.h | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

Comments

Bin Meng Dec. 16, 2020, 3:26 a.m. UTC | #1
On Mon, Nov 9, 2020 at 10:12 PM Simon Glass <sjg@chromium.org> wrote:
>
> Make use of the new bootargs substitution mechanism and zboot command
> syntax.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>  include/configs/chromebook_coral.h | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Bin Meng Dec. 16, 2020, 5:52 a.m. UTC | #2
On Wed, Dec 16, 2020 at 11:26 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Mon, Nov 9, 2020 at 10:12 PM Simon Glass <sjg@chromium.org> wrote:
> >
> > Make use of the new bootargs substitution mechanism and zboot command
> > syntax.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> >
> >  include/configs/chromebook_coral.h | 11 +++++++----
> >  1 file changed, 7 insertions(+), 4 deletions(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

applied to u-boot-x86, thanks!
diff mbox series

Patch

diff --git a/include/configs/chromebook_coral.h b/include/configs/chromebook_coral.h
index d4d32758e99..6e8e8ec1709 100644
--- a/include/configs/chromebook_coral.h
+++ b/include/configs/chromebook_coral.h
@@ -15,10 +15,13 @@ 
 	"read mmc 2:2 100000 0 80; setexpr loader *001004f0; " \
 	"setexpr size *00100518; setexpr blocks $size / 200; " \
 	"read mmc 2:2 100000 80 $blocks; setexpr setup $loader - 1000; " \
-	"setexpr cmdline $loader - 2000; " \
-	"part uuid mmc 2:2 uuid; setenv bootargs_U $uuid; " \
-	"zboot start 100000 0 0 0 $setup $cmdline; " \
-	"zboot load; zboot setup; zboot dump; zboot go"
+	"setexpr cmdline_ptr $loader - 2000; " \
+	"setexpr.s cmdline *$cmdline_ptr; " \
+	"setexpr cmdline gsub %U \\\\${uuid}; " \
+	"if part uuid mmc 2:2 uuid; then " \
+	"zboot start 100000 0 0 0 $setup cmdline; " \
+	"zboot load; zboot setup; zboot dump; zboot go;" \
+	"fi"
 
 #include <configs/x86-common.h>
 #include <configs/x86-chromebook.h>