mbox series

[0/5] Fanotify cleanup and test for v5.9 regression

Message ID 20201204095930.866421-1-amir73il@gmail.com
Headers show
Series Fanotify cleanup and test for v5.9 regression | expand

Message

Amir Goldstein Dec. 4, 2020, 9:59 a.m. UTC 
Hi Petr,

Here are my followup patches to your great cleanup and
a new test for a bug fix that is already included in v5.9.y.

Note that I resurrected the helper from your V5 patches that
you turned into a macro following Cyril's comment.
I hope you both find the result satisfying.

There are no direct calls to fanotify_init() after those
cleanups (except for the intended use in fanotify14).

FYI, I have another test (inotify) for another v5.9 regression.
The fix is queued for upstream, but did reach upstream yet, so
I will post that test later.

Thanks,
Amir.

Amir Goldstein (5):
  syscalls/fanotify: Generalize check for FAN_REPORT_FID support
  syscalls/fanotify: Use generic checks for fanotify_init flags
  syscalls/fanotify09: Read variable length events
  syscalls/fanotify09: Add test case with two non-dir children
  syscalls/fanotify09: Add test case for events with filename info

 testcases/kernel/syscalls/fanotify/fanotify.h |  46 +++--
 .../kernel/syscalls/fanotify/fanotify01.c     |   4 +-
 .../kernel/syscalls/fanotify/fanotify09.c     | 167 +++++++++++++-----
 .../kernel/syscalls/fanotify/fanotify10.c     |  26 ++-
 .../kernel/syscalls/fanotify/fanotify11.c     |  21 +--
 .../kernel/syscalls/fanotify/fanotify13.c     |   2 +-
 .../kernel/syscalls/fanotify/fanotify15.c     |   2 +-
 .../kernel/syscalls/fanotify/fanotify16.c     |  14 +-
 8 files changed, 180 insertions(+), 102 deletions(-)

Comments

Petr Vorel Dec. 4, 2020, 2:27 p.m. UTC | #1 
Hi Amir,

> Hi Petr,

> Here are my followup patches to your great cleanup and
> a new test for a bug fix that is already included in v5.9.y.

> Note that I resurrected the helper from your V5 patches that
> you turned into a macro following Cyril's comment.
> I hope you both find the result satisfying.
Nice clean patchset, as usually. Thank you.
I'll do some testing on Monday.
@Jan, if you have time please have a quick look into the patchset.

> There are no direct calls to fanotify_init() after those
> cleanups (except for the intended use in fanotify14).
+1

> FYI, I have another test (inotify) for another v5.9 regression.
> The fix is queued for upstream, but did reach upstream yet, so
> I will post that test later.
+1

> Thanks,
> Amir.

Kind regards,
Petr