| Message ID | 20201125150043.22532.87498.stgit@dceara.remote.csb |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Enable LeakSanitizer when running tests with AddressSanitizer. | expand |
On Wed, Nov 25, 2020 at 8:31 PM Dumitru Ceara <dceara@redhat.com> wrote: > > Recent commits cleaned up most of the minor leaks that would've made > tests with AddressSanitizer memory leak checking enabled fail. It > should be safe (and useful) to check for memory leaks by default. > > Signed-off-by: Dumitru Ceara <dceara@redhat.com> Thanks Dumitru. This will be very useful. I applied this patch to master. Once we have github actions patch merged, we can make use of this. Thanks Numan > --- > tests/atlocal.in | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/tests/atlocal.in b/tests/atlocal.in > index 4517ebf..d9a4c91 100644 > --- a/tests/atlocal.in > +++ b/tests/atlocal.in > @@ -205,8 +205,5 @@ export OVS_CTL_TIMEOUT > > # Add some default flags to make the tests run better under Address > # Sanitizer, if it was used for the build. > -# > -# We disable leak detection because otherwise minor leaks that don't > -# matter break everything. > -ASAN_OPTIONS=detect_leaks=0:abort_on_error=true:log_path=asan:$ASAN_OPTIONS > +ASAN_OPTIONS=detect_leaks=1:abort_on_error=true:log_path=asan:$ASAN_OPTIONS > export ASAN_OPTIONS > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/tests/atlocal.in b/tests/atlocal.in index 4517ebf..d9a4c91 100644 --- a/tests/atlocal.in +++ b/tests/atlocal.in @@ -205,8 +205,5 @@ export OVS_CTL_TIMEOUT # Add some default flags to make the tests run better under Address # Sanitizer, if it was used for the build. -# -# We disable leak detection because otherwise minor leaks that don't -# matter break everything. -ASAN_OPTIONS=detect_leaks=0:abort_on_error=true:log_path=asan:$ASAN_OPTIONS +ASAN_OPTIONS=detect_leaks=1:abort_on_error=true:log_path=asan:$ASAN_OPTIONS export ASAN_OPTIONS
Recent commits cleaned up most of the minor leaks that would've made tests with AddressSanitizer memory leak checking enabled fail. It should be safe (and useful) to check for memory leaks by default. Signed-off-by: Dumitru Ceara <dceara@redhat.com> --- tests/atlocal.in | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)