| Message ID | 20201126112915.525285-7-marcandre.lureau@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Remove GCC < 4.8 checks | expand |
On Thu, 26 Nov 2020 at 11:30, <marcandre.lureau@redhat.com> wrote: > > From: Marc-André Lureau <marcandre.lureau@redhat.com> > > Since commit efc6c07 ("configure: Add a test for the minimum compiler > version"), QEMU explicitely depends on GCC >= 4.8. > > (clang >= 3.8 advertizes itself as GCC >= 4.2 compatible) > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > tests/tcg/arm/fcvt.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/tests/tcg/arm/fcvt.c b/tests/tcg/arm/fcvt.c > index 617626bc63..7ac47b564e 100644 > --- a/tests/tcg/arm/fcvt.c > +++ b/tests/tcg/arm/fcvt.c > @@ -73,11 +73,9 @@ static void print_int64(int i, int64_t num) > > #ifndef SNANF > /* Signaling NaN macros, if supported. */ > -# if __GNUC_PREREQ(3, 3) > -# define SNANF (__builtin_nansf ("")) > -# define SNAN (__builtin_nans ("")) > -# define SNANL (__builtin_nansl ("")) > -# endif > +# define SNANF (__builtin_nansf ("")) > +# define SNAN (__builtin_nans ("")) > +# define SNANL (__builtin_nansl ("")) > #endif Please fix the commit message to talk about clang 3.4, not 3.8, but otherwise Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
Peter Maydell <peter.maydell@linaro.org> writes: > On Thu, 26 Nov 2020 at 11:30, <marcandre.lureau@redhat.com> wrote: >> >> From: Marc-André Lureau <marcandre.lureau@redhat.com> >> >> Since commit efc6c07 ("configure: Add a test for the minimum compiler >> version"), QEMU explicitely depends on GCC >= 4.8. technically the tests/tcg tests don't depend on the same compilers as the main QEMU build. However as the cross compiler case is most likely covered by our much more modern docker images and the buildin arm-on-arm will re-use the host compiler this is fine. Acked-by: Alex Bennée <alex.bennee@linaro.org>
diff --git a/tests/tcg/arm/fcvt.c b/tests/tcg/arm/fcvt.c index 617626bc63..7ac47b564e 100644 --- a/tests/tcg/arm/fcvt.c +++ b/tests/tcg/arm/fcvt.c @@ -73,11 +73,9 @@ static void print_int64(int i, int64_t num) #ifndef SNANF /* Signaling NaN macros, if supported. */ -# if __GNUC_PREREQ(3, 3) -# define SNANF (__builtin_nansf ("")) -# define SNAN (__builtin_nans ("")) -# define SNANL (__builtin_nansl ("")) -# endif +# define SNANF (__builtin_nansf ("")) +# define SNAN (__builtin_nans ("")) +# define SNANL (__builtin_nansl ("")) #endif float single_numbers[] = { -SNANF,