| Message ID | 20201123083555.42776-1-zhengliang6@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: arizona: disable pm_runtime in case of failure | expand |
On Mon, Nov 23, 2020 at 8:39 AM Zheng Liang <zhengliang6@huawei.com> wrote: > > pm_runtime_enable will increase power disable depth. Thus a > pairing decrement is needed on the error handling path to keep > it balanced. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zheng Liang <zhengliang6@huawei.com> > --- > drivers/gpio/gpio-arizona.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/gpio-arizona.c b/drivers/gpio/gpio-arizona.c > index 5bda38e0780f..2bc173c352ce 100644 > --- a/drivers/gpio/gpio-arizona.c > +++ b/drivers/gpio/gpio-arizona.c > @@ -192,6 +192,7 @@ static int arizona_gpio_probe(struct platform_device *pdev) > ret = devm_gpiochip_add_data(&pdev->dev, &arizona_gpio->gpio_chip, > arizona_gpio); > if (ret < 0) { > + pm_runtime_disable(&pdev->dev); > dev_err(&pdev->dev, "Could not register gpiochip, %d\n", > ret); > return ret; > -- > 2.17.1 > This looks like stable material. Can you add a Fixes: tag? Bartosz
diff --git a/drivers/gpio/gpio-arizona.c b/drivers/gpio/gpio-arizona.c index 5bda38e0780f..2bc173c352ce 100644 --- a/drivers/gpio/gpio-arizona.c +++ b/drivers/gpio/gpio-arizona.c @@ -192,6 +192,7 @@ static int arizona_gpio_probe(struct platform_device *pdev) ret = devm_gpiochip_add_data(&pdev->dev, &arizona_gpio->gpio_chip, arizona_gpio); if (ret < 0) { + pm_runtime_disable(&pdev->dev); dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret); return ret;
pm_runtime_enable will increase power disable depth. Thus a pairing decrement is needed on the error handling path to keep it balanced. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zheng Liang <zhengliang6@huawei.com> --- drivers/gpio/gpio-arizona.c | 1 + 1 file changed, 1 insertion(+)