| Message ID | 20201119114149.4117-1-brgl@bgdev.pl |
|---|---|
| Headers | show |
| Series | rtc: remove all uses of devm_rtc_device_register() | expand |
On 19/11/2020 12:40:50+0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > So we now have two functions whose names are easy to confuse. I spent some > time and simply converted all RTC drivers to using the preferred interface. > > Obviously these have only been compile-tested. I hope I didn't broke too > many drivers in the process. Most of the conversions was easy, sometime > it required removing unnecessary goto labels. There's also one patch > using a different devres helpers in here. > I'm not going to apply this series as this is not how I wanted to proceed (else this would have been done a while ago). > Bartosz Golaszewski (59): > rtc: da9055: stop using deprecated RTC API > rtc: m41t94: stop using deprecated RTC API > rtc: ds1390: stop using deprecated RTC API > rtc: ds3232: stop using deprecated RTC API > rtc: rx6110: stop using deprecated RTC API > rtc: palmas: stop using deprecated RTC API > rtc: bq32k: stop using deprecated RTC API > rtc: m48t35: stop using deprecated RTC API > rtc: pcf50633: stop using deprecated RTC API > rtc: pcf8583: stop using deprecated RTC API > rtc: efi: stop using deprecated RTC API > rtc: pcf8523: stop using deprecated RTC API > rtc: stm32: stop using deprecated RTC API > rtc: max8925: stop using deprecated RTC API > rtc: max8907: stop using deprecated RTC API > rtc: pxa: stop using deprecated RTC API > rtc: hym8563: stop using deprecated RTC API > rtc: max6916: stop using deprecated RTC API > rtc: max8998: stop using deprecated RTC API > rtc: s5m: use devm_i2c_new_dummy_device() > rtc: s5m: stop using deprecated RTC API > rtc: moxart: stop using deprecated RTC API > rtc: hid: stop using deprecated RTC API > rtc: generic: stop using deprecated RTC API > rtc: lpc24xx: stop using deprecated RTC API > rtc: spear: stop using deprecated RTC API > rtc: max77686: stop using deprecated RTC API > rtc: ds1286: stop using deprecated RTC API > rtc: twl: stop using deprecated RTC API > rtc: s3c: stop using deprecated RTC API > rtc: mcp795: stop using deprecated RTC API > rtc: x1205: stop using deprecated RTC API > rtc: max6902: stop using deprecated RTC API > rtc: max6900: stop using deprecated RTC API > rtc: rx8025: stop using deprecated RTC API > rtc: asm9260: stop using deprecated RTC API > rtc: opal: stop using deprecated RTC API > rtc: rc5t583: stop using deprecated RTC API > rtc: wm8350: stop using deprecated RTC API > rtc: r7301: stop using deprecated RTC API > rtc: max8997: stop using deprecated RTC API > rtc: isl12022: stop using deprecated RTC API > rtc: tps80031: stop using deprecated RTC API > rtc: rs5c372: stop using deprecated RTC API > rtc: mt7622: stop using deprecated RTC API > rtc: ds1302: stop using deprecated RTC API > rtc: bq4802: stop using deprecated RTC API > rtc: rs5c313: stop using deprecated RTC API > rtc: em3027: stop using deprecated RTC API > rtc: v3020: stop using deprecated RTC API > rtc: ds1216: stop using deprecated RTC API > rtc: rx4581: stop using deprecated RTC API > rtc: m41t93: stop using deprecated RTC API > rtc: fm3130: stop using deprecated RTC API > rtc: rtd119x: stop using deprecated RTC API > rtc: msm6242: stop using deprecated RTC API > rtc: as3722: stop using deprecated RTC API > rtc: lp8788: stop using deprecated RTC API > rtc: remove devm_rtc_device_register() > > .../driver-api/driver-model/devres.rst | 1 - > drivers/rtc/class.c | 36 ------------- > drivers/rtc/rtc-as3722.c | 14 +++--- > drivers/rtc/rtc-asm9260.c | 10 ++-- > drivers/rtc/rtc-bq32k.c | 8 +-- > drivers/rtc/rtc-bq4802.c | 30 +++++------ > drivers/rtc/rtc-da9055.c | 19 +++---- > drivers/rtc/rtc-ds1216.c | 8 +-- > drivers/rtc/rtc-ds1286.c | 15 +++--- > drivers/rtc/rtc-ds1302.c | 14 +++--- > drivers/rtc/rtc-ds1390.c | 13 +++-- > drivers/rtc/rtc-ds3232.c | 7 +-- > drivers/rtc/rtc-efi.c | 6 +-- > drivers/rtc/rtc-em3027.c | 6 +-- > drivers/rtc/rtc-fm3130.c | 22 +++----- > drivers/rtc/rtc-generic.c | 6 +-- > drivers/rtc/rtc-hid-sensor-time.c | 21 ++++---- > drivers/rtc/rtc-hym8563.c | 6 +-- > drivers/rtc/rtc-isl12022.c | 11 ++-- > drivers/rtc/rtc-lp8788.c | 11 ++-- > drivers/rtc/rtc-lpc24xx.c | 10 ++-- > drivers/rtc/rtc-m41t93.c | 6 +-- > drivers/rtc/rtc-m41t94.c | 8 +-- > drivers/rtc/rtc-m48t35.c | 10 ++-- > drivers/rtc/rtc-max6900.c | 6 +-- > drivers/rtc/rtc-max6902.c | 7 +-- > drivers/rtc/rtc-max6916.c | 6 +-- > drivers/rtc/rtc-max77686.c | 13 ++--- > drivers/rtc/rtc-max8907.c | 14 +++--- > drivers/rtc/rtc-max8925.c | 14 +++--- > drivers/rtc/rtc-max8997.c | 21 ++++---- > drivers/rtc/rtc-max8998.c | 13 ++--- > drivers/rtc/rtc-mcp795.c | 7 +-- > drivers/rtc/rtc-moxart.c | 12 ++--- > drivers/rtc/rtc-msm6242.c | 7 +-- > drivers/rtc/rtc-mt7622.c | 10 ++-- > drivers/rtc/rtc-opal.c | 6 +-- > drivers/rtc/rtc-palmas.c | 15 +++--- > drivers/rtc/rtc-pcf50633.c | 8 +-- > drivers/rtc/rtc-pcf8523.c | 7 +-- > drivers/rtc/rtc-pcf8583.c | 10 ++-- > drivers/rtc/rtc-pxa.c | 13 ++--- > drivers/rtc/rtc-r7301.c | 7 +-- > drivers/rtc/rtc-rc5t583.c | 14 +++--- > drivers/rtc/rtc-rs5c313.c | 9 ++-- > drivers/rtc/rtc-rs5c372.c | 36 +++++-------- > drivers/rtc/rtc-rtd119x.c | 13 +++-- > drivers/rtc/rtc-rx4581.c | 7 +-- > drivers/rtc/rtc-rx6110.c | 12 ++--- > drivers/rtc/rtc-rx8025.c | 11 ++-- > drivers/rtc/rtc-s3c.c | 10 ++-- > drivers/rtc/rtc-s5m.c | 50 ++++++++----------- > drivers/rtc/rtc-spear.c | 10 ++-- > drivers/rtc/rtc-stm32.c | 18 ++++--- > drivers/rtc/rtc-tps80031.c | 15 +++--- > drivers/rtc/rtc-twl.c | 12 ++--- > drivers/rtc/rtc-v3020.c | 9 +++- > drivers/rtc/rtc-wm8350.c | 14 +++--- > drivers/rtc/rtc-x1205.c | 7 ++- > include/linux/rtc.h | 4 -- > 60 files changed, 346 insertions(+), 399 deletions(-) > > -- > 2.29.1 >
On Thu, Nov 19, 2020 at 12:48 PM Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > > On 19/11/2020 12:40:50+0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > So we now have two functions whose names are easy to confuse. I spent some > > time and simply converted all RTC drivers to using the preferred interface. > > > > Obviously these have only been compile-tested. I hope I didn't broke too > > many drivers in the process. Most of the conversions was easy, sometime > > it required removing unnecessary goto labels. There's also one patch > > using a different devres helpers in here. > > > > I'm not going to apply this series as this is not how I wanted to > proceed (else this would have been done a while ago). > What's the plan then? Bartosz
From: Bartosz Golaszewski <bgolaszewski@baylibre.com> So we now have two functions whose names are easy to confuse. I spent some time and simply converted all RTC drivers to using the preferred interface. Obviously these have only been compile-tested. I hope I didn't broke too many drivers in the process. Most of the conversions was easy, sometime it required removing unnecessary goto labels. There's also one patch using a different devres helpers in here. Bartosz Golaszewski (59): rtc: da9055: stop using deprecated RTC API rtc: m41t94: stop using deprecated RTC API rtc: ds1390: stop using deprecated RTC API rtc: ds3232: stop using deprecated RTC API rtc: rx6110: stop using deprecated RTC API rtc: palmas: stop using deprecated RTC API rtc: bq32k: stop using deprecated RTC API rtc: m48t35: stop using deprecated RTC API rtc: pcf50633: stop using deprecated RTC API rtc: pcf8583: stop using deprecated RTC API rtc: efi: stop using deprecated RTC API rtc: pcf8523: stop using deprecated RTC API rtc: stm32: stop using deprecated RTC API rtc: max8925: stop using deprecated RTC API rtc: max8907: stop using deprecated RTC API rtc: pxa: stop using deprecated RTC API rtc: hym8563: stop using deprecated RTC API rtc: max6916: stop using deprecated RTC API rtc: max8998: stop using deprecated RTC API rtc: s5m: use devm_i2c_new_dummy_device() rtc: s5m: stop using deprecated RTC API rtc: moxart: stop using deprecated RTC API rtc: hid: stop using deprecated RTC API rtc: generic: stop using deprecated RTC API rtc: lpc24xx: stop using deprecated RTC API rtc: spear: stop using deprecated RTC API rtc: max77686: stop using deprecated RTC API rtc: ds1286: stop using deprecated RTC API rtc: twl: stop using deprecated RTC API rtc: s3c: stop using deprecated RTC API rtc: mcp795: stop using deprecated RTC API rtc: x1205: stop using deprecated RTC API rtc: max6902: stop using deprecated RTC API rtc: max6900: stop using deprecated RTC API rtc: rx8025: stop using deprecated RTC API rtc: asm9260: stop using deprecated RTC API rtc: opal: stop using deprecated RTC API rtc: rc5t583: stop using deprecated RTC API rtc: wm8350: stop using deprecated RTC API rtc: r7301: stop using deprecated RTC API rtc: max8997: stop using deprecated RTC API rtc: isl12022: stop using deprecated RTC API rtc: tps80031: stop using deprecated RTC API rtc: rs5c372: stop using deprecated RTC API rtc: mt7622: stop using deprecated RTC API rtc: ds1302: stop using deprecated RTC API rtc: bq4802: stop using deprecated RTC API rtc: rs5c313: stop using deprecated RTC API rtc: em3027: stop using deprecated RTC API rtc: v3020: stop using deprecated RTC API rtc: ds1216: stop using deprecated RTC API rtc: rx4581: stop using deprecated RTC API rtc: m41t93: stop using deprecated RTC API rtc: fm3130: stop using deprecated RTC API rtc: rtd119x: stop using deprecated RTC API rtc: msm6242: stop using deprecated RTC API rtc: as3722: stop using deprecated RTC API rtc: lp8788: stop using deprecated RTC API rtc: remove devm_rtc_device_register() .../driver-api/driver-model/devres.rst | 1 - drivers/rtc/class.c | 36 ------------- drivers/rtc/rtc-as3722.c | 14 +++--- drivers/rtc/rtc-asm9260.c | 10 ++-- drivers/rtc/rtc-bq32k.c | 8 +-- drivers/rtc/rtc-bq4802.c | 30 +++++------ drivers/rtc/rtc-da9055.c | 19 +++---- drivers/rtc/rtc-ds1216.c | 8 +-- drivers/rtc/rtc-ds1286.c | 15 +++--- drivers/rtc/rtc-ds1302.c | 14 +++--- drivers/rtc/rtc-ds1390.c | 13 +++-- drivers/rtc/rtc-ds3232.c | 7 +-- drivers/rtc/rtc-efi.c | 6 +-- drivers/rtc/rtc-em3027.c | 6 +-- drivers/rtc/rtc-fm3130.c | 22 +++----- drivers/rtc/rtc-generic.c | 6 +-- drivers/rtc/rtc-hid-sensor-time.c | 21 ++++---- drivers/rtc/rtc-hym8563.c | 6 +-- drivers/rtc/rtc-isl12022.c | 11 ++-- drivers/rtc/rtc-lp8788.c | 11 ++-- drivers/rtc/rtc-lpc24xx.c | 10 ++-- drivers/rtc/rtc-m41t93.c | 6 +-- drivers/rtc/rtc-m41t94.c | 8 +-- drivers/rtc/rtc-m48t35.c | 10 ++-- drivers/rtc/rtc-max6900.c | 6 +-- drivers/rtc/rtc-max6902.c | 7 +-- drivers/rtc/rtc-max6916.c | 6 +-- drivers/rtc/rtc-max77686.c | 13 ++--- drivers/rtc/rtc-max8907.c | 14 +++--- drivers/rtc/rtc-max8925.c | 14 +++--- drivers/rtc/rtc-max8997.c | 21 ++++---- drivers/rtc/rtc-max8998.c | 13 ++--- drivers/rtc/rtc-mcp795.c | 7 +-- drivers/rtc/rtc-moxart.c | 12 ++--- drivers/rtc/rtc-msm6242.c | 7 +-- drivers/rtc/rtc-mt7622.c | 10 ++-- drivers/rtc/rtc-opal.c | 6 +-- drivers/rtc/rtc-palmas.c | 15 +++--- drivers/rtc/rtc-pcf50633.c | 8 +-- drivers/rtc/rtc-pcf8523.c | 7 +-- drivers/rtc/rtc-pcf8583.c | 10 ++-- drivers/rtc/rtc-pxa.c | 13 ++--- drivers/rtc/rtc-r7301.c | 7 +-- drivers/rtc/rtc-rc5t583.c | 14 +++--- drivers/rtc/rtc-rs5c313.c | 9 ++-- drivers/rtc/rtc-rs5c372.c | 36 +++++-------- drivers/rtc/rtc-rtd119x.c | 13 +++-- drivers/rtc/rtc-rx4581.c | 7 +-- drivers/rtc/rtc-rx6110.c | 12 ++--- drivers/rtc/rtc-rx8025.c | 11 ++-- drivers/rtc/rtc-s3c.c | 10 ++-- drivers/rtc/rtc-s5m.c | 50 ++++++++----------- drivers/rtc/rtc-spear.c | 10 ++-- drivers/rtc/rtc-stm32.c | 18 ++++--- drivers/rtc/rtc-tps80031.c | 15 +++--- drivers/rtc/rtc-twl.c | 12 ++--- drivers/rtc/rtc-v3020.c | 9 +++- drivers/rtc/rtc-wm8350.c | 14 +++--- drivers/rtc/rtc-x1205.c | 7 ++- include/linux/rtc.h | 4 -- 60 files changed, 346 insertions(+), 399 deletions(-)