| Message ID | 20201030053153.5319-7-vadivel.muruganx.ramuthevar@linux.intel.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | spi: cadence-quadspi: Add QSPI controller support for Intel LGM SoC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 7 lines checked |
On Fri, Oct 30, 2020 at 01:31:53PM +0800, Ramuthevar,Vadivel MuruganX wrote: > From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> > > Add compatible for Intel LGM SoC. > > Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> > --- > Documentation/devicetree/bindings/spi/cadence-quadspi.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml b/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml > index ec22b040d804..58ecdab939df 100644 > --- a/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml > +++ b/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml > @@ -19,6 +19,7 @@ properties: > - enum: > - ti,k2g-qspi > - ti,am654-ospi > + - intel,lgm-qspi As this change shows, you don't need 'oneOf' for Intel... > - const: cdns,qspi-nor > > reg: > -- > 2.11.0 >
Hi Rob, On 5/11/2020 6:03 am, Rob Herring wrote: > On Fri, Oct 30, 2020 at 01:31:53PM +0800, Ramuthevar,Vadivel MuruganX wrote: >> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> >> >> Add compatible for Intel LGM SoC. >> >> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> >> --- >> Documentation/devicetree/bindings/spi/cadence-quadspi.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml b/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml >> index ec22b040d804..58ecdab939df 100644 >> --- a/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml >> +++ b/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml >> @@ -19,6 +19,7 @@ properties: >> - enum: >> - ti,k2g-qspi >> - ti,am654-ospi >> + - intel,lgm-qspi > > As this change shows, you don't need 'oneOf' for Intel... As we you have suggested in the previous mail, I framed like below with 'oneOf' properties: compatible: oneOf: - items: - enum: - ti,k2g-qspi - ti,am654-ospi - const: cdns,qspi-nor - items: - enum: - intel,lgm-qspi - cadence,qspi #compatible for generic in future use - const: cdns,qspi-nor so that ignoring error message warning can be avoided as well, Thanks! Regards Vadivel > >> - const: cdns,qspi-nor >> >> reg: >> -- >> 2.11.0 >>
On Sun, Nov 8, 2020 at 7:49 PM Ramuthevar, Vadivel MuruganX <vadivel.muruganx.ramuthevar@linux.intel.com> wrote: > > Hi Rob, > > On 5/11/2020 6:03 am, Rob Herring wrote: > > On Fri, Oct 30, 2020 at 01:31:53PM +0800, Ramuthevar,Vadivel MuruganX wrote: > >> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> > >> > >> Add compatible for Intel LGM SoC. > >> > >> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> > >> --- > >> Documentation/devicetree/bindings/spi/cadence-quadspi.yaml | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml b/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml > >> index ec22b040d804..58ecdab939df 100644 > >> --- a/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml > >> +++ b/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml > >> @@ -19,6 +19,7 @@ properties: > >> - enum: > >> - ti,k2g-qspi > >> - ti,am654-ospi > >> + - intel,lgm-qspi > > > > As this change shows, you don't need 'oneOf' for Intel... > As we you have suggested in the previous mail, I framed like below with > 'oneOf' > > properties: > compatible: > oneOf: > - items: > - enum: > - ti,k2g-qspi > - ti,am654-ospi > - const: cdns,qspi-nor > > - items: > - enum: > - intel,lgm-qspi > - cadence,qspi #compatible for generic in future use Why are you not using the documented vendor prefix 'cdns'? In any case, adding this is pointless. Your 'generic' compatible is below. And you still don't need 'oneOf' here. The enum contents here can be in the first 'enum'. > - const: cdns,qspi-nor > > so that ignoring error message warning can be avoided as well, Thanks! In the example? Fix the example! Rob
Hi Rob, On 9/11/2020 11:15 pm, Rob Herring wrote: > On Sun, Nov 8, 2020 at 7:49 PM Ramuthevar, Vadivel MuruganX > <vadivel.muruganx.ramuthevar@linux.intel.com> wrote: >> >> Hi Rob, >> >> On 5/11/2020 6:03 am, Rob Herring wrote: >>> On Fri, Oct 30, 2020 at 01:31:53PM +0800, Ramuthevar,Vadivel MuruganX wrote: >>>> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> >>>> >>>> Add compatible for Intel LGM SoC. >>>> >>>> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> >>>> --- >>>> Documentation/devicetree/bindings/spi/cadence-quadspi.yaml | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml b/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml >>>> index ec22b040d804..58ecdab939df 100644 >>>> --- a/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml >>>> +++ b/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml >>>> @@ -19,6 +19,7 @@ properties: >>>> - enum: >>>> - ti,k2g-qspi >>>> - ti,am654-ospi >>>> + - intel,lgm-qspi >>> >>> As this change shows, you don't need 'oneOf' for Intel... >> As we you have suggested in the previous mail, I framed like below with >> 'oneOf' >> >> properties: >> compatible: >> oneOf: >> - items: >> - enum: >> - ti,k2g-qspi >> - ti,am654-ospi >> - const: cdns,qspi-nor >> >> - items: >> - enum: >> - intel,lgm-qspi >> - cadence,qspi #compatible for generic in future use > > Why are you not using the documented vendor prefix 'cdns'? old document file name is cadence-quadspi.txt, so thought of keeping the same name. Thank you for the suggestion, Sure, I will use it. > > In any case, adding this is pointless. Your 'generic' compatible is below. > > And you still don't need 'oneOf' here. The enum contents here can be > in the first 'enum'. Ok, Noted. Regards Vadivel > >> - const: cdns,qspi-nor >> >> so that ignoring error message warning can be avoided as well, Thanks! > > In the example? Fix the example! > > > Rob >
diff --git a/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml b/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml index ec22b040d804..58ecdab939df 100644 --- a/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml +++ b/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml @@ -19,6 +19,7 @@ properties: - enum: - ti,k2g-qspi - ti,am654-ospi + - intel,lgm-qspi - const: cdns,qspi-nor reg: