diff mbox series

[v2,2/3] acpi: Add missing ARM acpi_table header

Message ID d7d569b1cad18e4cdf6272c9d393a27d267f1852.camel@nedap.com
State Accepted
Delegated to: Tom Rini
Headers show
Series None | expand

Commit Message

Harm Berntsen Nov. 6, 2020, 12:24 p.m. UTC
The pci_mmc.c driver can generate ACPI info and therefore includes
asm/acpi_table.h by proxy. This file does not exist for the ARM
architecture and thus code compilation failed when using this 
driver on ARM.

Signed-off-by: Harm Berntsen <harm.berntsen@nedap.com>
CC: Simon Glass <sjg@chromium.org>
---
Changes for v2:
Different approach, the previous commit (acpi: Only include asm header
when available) used ifdefs to conditionally include acpi_table.h.
Based on Simon's suggestion this patch adds an empty file to fix the
issue.

 arch/arm/include/asm/acpi_table.h | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/include/asm/acpi_table.h

Comments

Simon Glass Nov. 6, 2020, 6:50 p.m. UTC | #1
On Fri, 6 Nov 2020 at 05:24, Harm Berntsen <harm.berntsen@nedap.com> wrote:
>
> The pci_mmc.c driver can generate ACPI info and therefore includes
> asm/acpi_table.h by proxy. This file does not exist for the ARM
> architecture and thus code compilation failed when using this
> driver on ARM.
>
> Signed-off-by: Harm Berntsen <harm.berntsen@nedap.com>
> CC: Simon Glass <sjg@chromium.org>
> ---
> Changes for v2:
> Different approach, the previous commit (acpi: Only include asm header
> when available) used ifdefs to conditionally include acpi_table.h.
> Based on Simon's suggestion this patch adds an empty file to fix the
> issue.
>
>  arch/arm/include/asm/acpi_table.h | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/include/asm/acpi_table.h


Reviewed-by: Simon Glass <sjg@chromium.org>
>
>
Tom Rini Jan. 19, 2021, 1:03 p.m. UTC | #2
On Fri, Nov 06, 2020 at 12:24:17PM +0000, Harm Berntsen wrote:

> The pci_mmc.c driver can generate ACPI info and therefore includes
> asm/acpi_table.h by proxy. This file does not exist for the ARM
> architecture and thus code compilation failed when using this 
> driver on ARM.
> 
> Signed-off-by: Harm Berntsen <harm.berntsen@nedap.com>
> CC: Simon Glass <sjg@chromium.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/arch/arm/include/asm/acpi_table.h
b/arch/arm/include/asm/acpi_table.h
new file mode 100644
index 0000000000..e69de29bb2