| Message ID | 20201030202131.796967-15-ehabkost@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | qdev/qom: Remove explicit type names from error_setg() calls | expand |
On Fri, 30 Oct 2020 16:21:25 -0400 Eduardo Habkost <ehabkost@redhat.com> wrote: > object_property_parse() will add a > "Property '<TYPE>.<PROP>' can't take value '<VALUE>'" > prefix automatically for us. > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > Cc: Paolo Bonzini <pbonzini@redhat.com> > Cc: Richard Henderson <rth@twiddle.net> > Cc: Eduardo Habkost <ehabkost@redhat.com> > Cc: qemu-devel@nongnu.org > --- > target/i386/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index 0d8606958e..2c00f94308 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -4529,7 +4529,7 @@ static void x86_cpuid_set_vendor(Object *obj, const char *value, > int i; > > if (strlen(value) != CPUID_VENDOR_SZ) { > - error_setg(errp, QERR_PROPERTY_VALUE_BAD, "", "vendor", value); > + error_setg(errp, "invalid vendor ID"); > return; > } >
diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 0d8606958e..2c00f94308 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -4529,7 +4529,7 @@ static void x86_cpuid_set_vendor(Object *obj, const char *value, int i; if (strlen(value) != CPUID_VENDOR_SZ) { - error_setg(errp, QERR_PROPERTY_VALUE_BAD, "", "vendor", value); + error_setg(errp, "invalid vendor ID"); return; }
object_property_parse() will add a "Property '<TYPE>.<PROP>' can't take value '<VALUE>'" prefix automatically for us. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Richard Henderson <rth@twiddle.net> Cc: Eduardo Habkost <ehabkost@redhat.com> Cc: qemu-devel@nongnu.org --- target/i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)