| Message ID | 20201030124454.854286-1-mst@redhat.com |
|---|---|
| State | New |
| Headers | show |
Patchew URL: https://patchew.org/QEMU/20201030124454.854286-1-mst@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201030124454.854286-1-mst@redhat.com Subject: [PULL 00/15] pc,pci,vhost,virtio: misc fixes === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20201030124454.854286-1-mst@redhat.com -> patchew/20201030124454.854286-1-mst@redhat.com Switched to a new branch 'test' 39f4788 intel_iommu: Fix two misuse of "0x%u" prints 74f2dcec virtio: skip guest index check on device load 09b8db3 vhost-blk: set features before setting inflight feature c4153ec pci: Disallow improper BAR registration for type 1 a3f7935 pci: Change error_report to assert(3) f4ae4c4 pci: advertise a page aligned ATS f7c0efa pc: Implement -no-hpet as sugar for -machine hpet=on dc519f1 vhost: Don't special case vq->used_phys in vhost_get_log_size() ba55ed1 pci: Assert irqnum is between 0 and bus->nirqs in pci_bus_change_irq_level 8a29952 hw/pci: Extract pci_bus_change_irq_level() from pci_change_irq_level() 9f715d8 hw/virtio/vhost-vdpa: Fix Coverity CID 1432864 6b2610b acpi/crs: Support ranges > 32b for hosts e078a8b acpi/crs: Prevent bad ranges for host bridges 2f40e4c vhost-vsock: set vhostfd to non-blocking mode 3e6364c vhost-vdpa: negotiate VIRTIO_NET_F_STATUS with driver === OUTPUT BEGIN === 1/15 Checking commit 3e6364c17855 (vhost-vdpa: negotiate VIRTIO_NET_F_STATUS with driver) 2/15 Checking commit 2f40e4cb435e (vhost-vsock: set vhostfd to non-blocking mode) 3/15 Checking commit e078a8b3da52 (acpi/crs: Prevent bad ranges for host bridges) 4/15 Checking commit 6b2610b14d1c (acpi/crs: Support ranges > 32b for hosts) 5/15 Checking commit 9f715d839623 (hw/virtio/vhost-vdpa: Fix Coverity CID 1432864) 6/15 Checking commit 8a29952670fa (hw/pci: Extract pci_bus_change_irq_level() from pci_change_irq_level()) 7/15 Checking commit ba55ed16b392 (pci: Assert irqnum is between 0 and bus->nirqs in pci_bus_change_irq_level) 8/15 Checking commit dc519f19095f (vhost: Don't special case vq->used_phys in vhost_get_log_size()) 9/15 Checking commit f7c0efad3f32 (pc: Implement -no-hpet as sugar for -machine hpet=on) WARNING: Block comments use a leading /* on a separate line #53: FILE: hw/i386/pc.c:1152: + /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7 WARNING: Block comments should align the * on each line #54: FILE: hw/i386/pc.c:1153: + /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7 + * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23, total: 0 errors, 2 warnings, 127 lines checked Patch 9/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/15 Checking commit f4ae4c4df1e6 (pci: advertise a page aligned ATS) 11/15 Checking commit a3f79352c50f (pci: Change error_report to assert(3)) 12/15 Checking commit c4153ecc2f8c (pci: Disallow improper BAR registration for type 1) 13/15 Checking commit 09b8db37041f (vhost-blk: set features before setting inflight feature) ERROR: trailing whitespace #45: FILE: hw/virtio/vhost.c:1651: + $ ERROR: trailing whitespace #50: FILE: hw/virtio/vhost.c:1656: + $ total: 2 errors, 0 warnings, 43 lines checked Patch 13/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/15 Checking commit 74f2dceca92c (virtio: skip guest index check on device load) 15/15 Checking commit 39f4788eefc0 (intel_iommu: Fix two misuse of "0x%u" prints) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201030124454.854286-1-mst@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
The following changes since commit 802427bcdae1ad2eceea8a8877ecad835e3f8fde: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20201027-1' into staging (2020-10-29 11:40:04 +0000) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to 73beb01ec54969f76ab32d1e0605a759b6c95ab0: intel_iommu: Fix two misuse of "0x%u" prints (2020-10-30 06:48:53 -0400) ---------------------------------------------------------------- pc,pci,vhost,virtio: misc fixes Just a bunch of bugfixes all over the place. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> ---------------------------------------------------------------- Ben Widawsky (4): acpi/crs: Prevent bad ranges for host bridges acpi/crs: Support ranges > 32b for hosts pci: Change error_report to assert(3) pci: Disallow improper BAR registration for type 1 Eduardo Habkost (1): pc: Implement -no-hpet as sugar for -machine hpet=on Felipe Franciosi (1): virtio: skip guest index check on device load Greg Kurz (1): vhost: Don't special case vq->used_phys in vhost_get_log_size() Jason Wang (1): pci: advertise a page aligned ATS Jin Yu (1): vhost-blk: set features before setting inflight feature Mark Cave-Ayland (1): pci: Assert irqnum is between 0 and bus->nirqs in pci_bus_change_irq_level Peter Xu (1): intel_iommu: Fix two misuse of "0x%u" prints Philippe Mathieu-Daudé (2): hw/virtio/vhost-vdpa: Fix Coverity CID 1432864 hw/pci: Extract pci_bus_change_irq_level() from pci_change_irq_level() Si-Wei Liu (1): vhost-vdpa: negotiate VIRTIO_NET_F_STATUS with driver Stefano Garzarella (1): vhost-vsock: set vhostfd to non-blocking mode include/hw/i386/pc.h | 1 + include/hw/i386/x86.h | 3 --- include/hw/virtio/vhost.h | 1 + hw/block/vhost-user-blk.c | 6 +++++ hw/i386/acpi-build.c | 12 +++++++-- hw/i386/intel_iommu.c | 4 +-- hw/i386/pc.c | 63 ++++++++++++++++++++++++++++++++--------------- hw/i386/pc_piix.c | 2 +- hw/pci/pci.c | 23 +++++++++++------ hw/pci/pcie.c | 5 ++-- hw/virtio/vhost-vdpa.c | 4 +-- hw/virtio/vhost-vsock.c | 10 ++++++++ hw/virtio/vhost.c | 28 +++++++++++++-------- hw/virtio/virtio.c | 13 +++++----- net/vhost-vdpa.c | 1 + softmmu/vl.c | 4 +-- 16 files changed, 123 insertions(+), 57 deletions(-)