diff mbox series

[v1] distro_bootcmd: set devtype for dhcp boot

Message ID 20201029105919.18025-1-igor.opaniuk@gmail.com
State Accepted
Commit c9cb6a6002fc91b045ac84b6d8fe0b34213dd320
Delegated to: Tom Rini
Headers show
Series [v1] distro_bootcmd: set devtype for dhcp boot | expand

Commit Message

Igor Opaniuk Oct. 29, 2020, 10:59 a.m. UTC
From: Igor Opaniuk <igor.opaniuk@toradex.com>

Set $devtype for DHCP boot, which can be handy for the boot.scr
for detection of devtype used (for example, when the same boot.scr is
used for both mmc/dhcp boot):

if test ${devtype} = "dhcp"; then
	...
fi

Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
---

 include/config_distro_bootcmd.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Oleksandr Suvorov Oct. 29, 2020, 11:45 a.m. UTC | #1
On Thu, Oct 29, 2020 at 12:59 PM Igor Opaniuk <igor.opaniuk@gmail.com> wrote:
>
> From: Igor Opaniuk <igor.opaniuk@toradex.com>
>
> Set $devtype for DHCP boot, which can be handy for the boot.scr
> for detection of devtype used (for example, when the same boot.scr is
> used for both mmc/dhcp boot):
>
> if test ${devtype} = "dhcp"; then
>         ...
> fi
>
> Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>

Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

> ---
>
>  include/config_distro_bootcmd.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/config_distro_bootcmd.h b/include/config_distro_bootcmd.h
> index ff29ef5a90..f5d113513a 100644
> --- a/include/config_distro_bootcmd.h
> +++ b/include/config_distro_bootcmd.h
> @@ -367,6 +367,7 @@
>  #endif
>  #define BOOTENV_DEV_DHCP(devtypeu, devtypel, instance) \
>         "bootcmd_dhcp=" \
> +               "setenv devtype " #devtypel "; " \
>                 BOOTENV_RUN_NET_USB_START \
>                 BOOTENV_RUN_PCI_ENUM \
>                 "if dhcp ${scriptaddr} ${boot_script_dhcp}; then " \
> --
> 2.17.1
>
Igor Opaniuk Dec. 15, 2020, 3:09 p.m. UTC | #2
Hi Tom,

On Thu, Oct 29, 2020 at 12:59 PM Igor Opaniuk <igor.opaniuk@gmail.com> wrote:
>
> From: Igor Opaniuk <igor.opaniuk@toradex.com>
>
> Set $devtype for DHCP boot, which can be handy for the boot.scr
> for detection of devtype used (for example, when the same boot.scr is
> used for both mmc/dhcp boot):
>
> if test ${devtype} = "dhcp"; then
>         ...
> fi
>
> Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
> ---
>
>  include/config_distro_bootcmd.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/config_distro_bootcmd.h b/include/config_distro_bootcmd.h
> index ff29ef5a90..f5d113513a 100644
> --- a/include/config_distro_bootcmd.h
> +++ b/include/config_distro_bootcmd.h
> @@ -367,6 +367,7 @@
>  #endif
>  #define BOOTENV_DEV_DHCP(devtypeu, devtypel, instance) \
>         "bootcmd_dhcp=" \
> +               "setenv devtype " #devtypel "; " \
>                 BOOTENV_RUN_NET_USB_START \
>                 BOOTENV_RUN_PCI_ENUM \
>                 "if dhcp ${scriptaddr} ${boot_script_dhcp}; then " \
> --
> 2.17.1
>

Any chance this can be pulled in for v2021.01 ?
Thanks
Tom Rini Dec. 16, 2020, 1:13 p.m. UTC | #3
On Thu, Oct 29, 2020 at 12:59:19PM +0200, Igor Opaniuk wrote:

> From: Igor Opaniuk <igor.opaniuk@toradex.com>
> 
> Set $devtype for DHCP boot, which can be handy for the boot.scr
> for detection of devtype used (for example, when the same boot.scr is
> used for both mmc/dhcp boot):
> 
> if test ${devtype} = "dhcp"; then
> 	...
> fi
> 
> Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
> Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/include/config_distro_bootcmd.h b/include/config_distro_bootcmd.h
index ff29ef5a90..f5d113513a 100644
--- a/include/config_distro_bootcmd.h
+++ b/include/config_distro_bootcmd.h
@@ -367,6 +367,7 @@ 
 #endif
 #define BOOTENV_DEV_DHCP(devtypeu, devtypel, instance) \
 	"bootcmd_dhcp=" \
+		"setenv devtype " #devtypel "; " \
 		BOOTENV_RUN_NET_USB_START \
 		BOOTENV_RUN_PCI_ENUM \
 		"if dhcp ${scriptaddr} ${boot_script_dhcp}; then " \