| Message ID | 20201027123722.2935-2-aladyshev22@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] ARM: dts: aspeed: amd-ethanolx: Update KCS nodes to use v2 binding | expand |
On Tue, 27 Oct 2020 at 12:41, Konstantin Aladyshev <aladyshev22@gmail.com> wrote: > > The KCS interface on the LPC channel 3 in the controller > is used for the in-band BMC<->BIOS IPMI communication. > 0xCA2 is a default host CPU LPC IO address for this > interface. > > Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com> I don't have any docs on the platform so I'll wait for a review from Supreeth before applying this one. It's a correct use of the bindings: Reviewed-by: Joel Stanley <joel@jms.id.au> > --- > arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts > index 89ddc3847222..2a86bda8afd8 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts > @@ -147,6 +147,11 @@ > aspeed,lpc-io-reg = <0x62>; > }; > > +&kcs3 { > + status = "okay"; > + aspeed,lpc-io-reg = <0xCA2>; > +}; > + > &kcs4 { > status = "okay"; > aspeed,lpc-io-reg = <0x97DE>; > -- > 2.17.1 >
Thanks Konstantin for this patch. Thanks Joel for reviewing this. On 10/28/20 12:28 AM, Joel Stanley wrote: > [CAUTION: External Email] > > On Tue, 27 Oct 2020 at 12:41, Konstantin Aladyshev > <aladyshev22@gmail.com> wrote: >> >> The KCS interface on the LPC channel 3 in the controller >> is used for the in-band BMC<->BIOS IPMI communication. >> 0xCA2 is a default host CPU LPC IO address for this >> interface. >> >> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com> > > I don't have any docs on the platform so I'll wait for a review from > Supreeth before applying this one. Done. > > It's a correct use of the bindings: > > Reviewed-by: Joel Stanley <joel@jms.id.au> Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@amd.com> > >> --- >> arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts >> index 89ddc3847222..2a86bda8afd8 100644 >> --- a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts >> +++ b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts >> @@ -147,6 +147,11 @@ >> aspeed,lpc-io-reg = <0x62>; >> }; >> >> +&kcs3 { >> + status = "okay"; >> + aspeed,lpc-io-reg = <0xCA2>; >> +}; >> + >> &kcs4 { >> status = "okay"; >> aspeed,lpc-io-reg = <0x97DE>; >> -- >> 2.17.1 >>
diff --git a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts index 89ddc3847222..2a86bda8afd8 100644 --- a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts +++ b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts @@ -147,6 +147,11 @@ aspeed,lpc-io-reg = <0x62>; }; +&kcs3 { + status = "okay"; + aspeed,lpc-io-reg = <0xCA2>; +}; + &kcs4 { status = "okay"; aspeed,lpc-io-reg = <0x97DE>;
The KCS interface on the LPC channel 3 in the controller is used for the in-band BMC<->BIOS IPMI communication. 0xCA2 is a default host CPU LPC IO address for this interface. Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com> --- arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 5 +++++ 1 file changed, 5 insertions(+)