| Message ID | 20201026054614.17114-1-po-hsu.lin@canonical.com |
|---|---|
| Headers | show |
| Series | [F,SRU,1/1] selftests: rtnetlink: load fou module for kci_test_encap_fou() test | expand |
On 26.10.20 06:46, Po-Hsu Lin wrote: > BugLink: https://bugs.launchpad.net/bugs/1891421 > > == SRU Justification == > The kci_test_encap_fou() from kci_test_encap() in rtnetlink.sh of > kselftests/net will fail with non-zero return value, and print: > "FAIL: can't add fou port 7777, skipping test" > > How to reproduce this: > devdummy="test-dummy0" > testns="testns" > ip netns add "$testns" > ip netns exec "$testns" ip link set lo up > ip netns exec "$testns" ip link add name "$devdummy" type dummy > ip netns exec "$testns" ip link set "$devdummy" up > ip netns exec "$testns" ip fou add port 7777 ipproto 47 > RTNETLINK answers: No such file or directory > Error talking to the kernel > > This test would require the fou module to be loaded before it gets > started. > > == Fix > * 26ebd6fed9bb ("selftests: rtnetlink: load fou module for > kci_test_encap_fou() test") > > This patch needs to be backported for series after Xenial. > > == Test == > Patch tested directly on the kernel tree, the test will now pass as > expected. > > == Regression Potential == > Low, change limited to the testing tool. > > Po-Hsu Lin (1): > selftests: rtnetlink: load fou module for kci_test_encap_fou() test > > tools/testing/selftests/net/config | 1 + > tools/testing/selftests/net/rtnetlink.sh | 5 +++++ > 2 files changed, 6 insertions(+) > Acked-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com> On Mon, Oct 26, 2020 at 01:46:09PM +0800, Po-Hsu Lin wrote: > BugLink: https://bugs.launchpad.net/bugs/1891421 > > == SRU Justification == > The kci_test_encap_fou() from kci_test_encap() in rtnetlink.sh of > kselftests/net will fail with non-zero return value, and print: > "FAIL: can't add fou port 7777, skipping test" > > How to reproduce this: > devdummy="test-dummy0" > testns="testns" > ip netns add "$testns" > ip netns exec "$testns" ip link set lo up > ip netns exec "$testns" ip link add name "$devdummy" type dummy > ip netns exec "$testns" ip link set "$devdummy" up > ip netns exec "$testns" ip fou add port 7777 ipproto 47 > RTNETLINK answers: No such file or directory > Error talking to the kernel > > This test would require the fou module to be loaded before it gets > started. > > == Fix > * 26ebd6fed9bb ("selftests: rtnetlink: load fou module for > kci_test_encap_fou() test") > > This patch needs to be backported for series after Xenial. > > == Test == > Patch tested directly on the kernel tree, the test will now pass as > expected. > > == Regression Potential == > Low, change limited to the testing tool. > > Po-Hsu Lin (1): > selftests: rtnetlink: load fou module for kci_test_encap_fou() test > > tools/testing/selftests/net/config | 1 + > tools/testing/selftests/net/rtnetlink.sh | 5 +++++ > 2 files changed, 6 insertions(+) > > -- > 2.7.4 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On 26.10.2020 7.46, Po-Hsu Lin wrote: > BugLink: https://bugs.launchpad.net/bugs/1891421 > > == SRU Justification == > The kci_test_encap_fou() from kci_test_encap() in rtnetlink.sh of > kselftests/net will fail with non-zero return value, and print: > "FAIL: can't add fou port 7777, skipping test" > > How to reproduce this: > devdummy="test-dummy0" > testns="testns" > ip netns add "$testns" > ip netns exec "$testns" ip link set lo up > ip netns exec "$testns" ip link add name "$devdummy" type dummy > ip netns exec "$testns" ip link set "$devdummy" up > ip netns exec "$testns" ip fou add port 7777 ipproto 47 > RTNETLINK answers: No such file or directory > Error talking to the kernel > > This test would require the fou module to be loaded before it gets > started. > > == Fix > * 26ebd6fed9bb ("selftests: rtnetlink: load fou module for > kci_test_encap_fou() test") > > This patch needs to be backported for series after Xenial. > > == Test == > Patch tested directly on the kernel tree, the test will now pass as > expected. > > == Regression Potential == > Low, change limited to the testing tool. > > Po-Hsu Lin (1): > selftests: rtnetlink: load fou module for kci_test_encap_fou() test > > tools/testing/selftests/net/config | 1 + > tools/testing/selftests/net/rtnetlink.sh | 5 +++++ > 2 files changed, 6 insertions(+) > applied to oem-5.6, thanks
BugLink: https://bugs.launchpad.net/bugs/1891421 == SRU Justification == The kci_test_encap_fou() from kci_test_encap() in rtnetlink.sh of kselftests/net will fail with non-zero return value, and print: "FAIL: can't add fou port 7777, skipping test" How to reproduce this: devdummy="test-dummy0" testns="testns" ip netns add "$testns" ip netns exec "$testns" ip link set lo up ip netns exec "$testns" ip link add name "$devdummy" type dummy ip netns exec "$testns" ip link set "$devdummy" up ip netns exec "$testns" ip fou add port 7777 ipproto 47 RTNETLINK answers: No such file or directory Error talking to the kernel This test would require the fou module to be loaded before it gets started. == Fix * 26ebd6fed9bb ("selftests: rtnetlink: load fou module for kci_test_encap_fou() test") This patch needs to be backported for series after Xenial. == Test == Patch tested directly on the kernel tree, the test will now pass as expected. == Regression Potential == Low, change limited to the testing tool. Po-Hsu Lin (1): selftests: rtnetlink: load fou module for kci_test_encap_fou() test tools/testing/selftests/net/config | 1 + tools/testing/selftests/net/rtnetlink.sh | 5 +++++ 2 files changed, 6 insertions(+)