diff mbox series

[7/8] ext4: delete invalid code inside ext4_xattr_block_set()

Message ID 1603271728-7198-7-git-send-email-brookxu@tencent.com
State Superseded
Headers show
Series [1/8] ext4: use ext4_assert() to replace J_ASSERT() | expand

Commit Message

brookxu Oct. 21, 2020, 9:15 a.m. UTC 
From: Chunguang Xu <brookxu@tencent.com>

Delete invalid code inside ext4_xattr_block_set().

Signed-off-by: Chunguang Xu <brookxu@tencent.com>
---
 fs/ext4/xattr.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Andreas Dilger Oct. 23, 2020, 11:10 p.m. UTC | #1 
On Oct 21, 2020, at 3:15 AM, Chunguang Xu <brookxu.cn@gmail.com> wrote:
> 
> From: Chunguang Xu <brookxu@tencent.com>
> 
> Delete invalid code inside ext4_xattr_block_set().
> 
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>

I would maybe write "inactive code", but seems OK either way

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> fs/ext4/xattr.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
> index 6127e94..4e3b1f8 100644
> --- a/fs/ext4/xattr.c
> +++ b/fs/ext4/xattr.c
> @@ -1927,7 +1927,6 @@ struct ext4_xattr_block_find {
> 	} else {
> 		/* Allocate a buffer where we construct the new block. */
> 		s->base = kzalloc(sb->s_blocksize, GFP_NOFS);
> -		/* assert(header == s->base) */
> 		error = -ENOMEM;
> 		if (s->base == NULL)
> 			goto cleanup;
> --
> 1.8.3.1
> 


Cheers, Andreas
diff mbox series

Patch

diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index 6127e94..4e3b1f8 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -1927,7 +1927,6 @@  struct ext4_xattr_block_find {
 	} else {
 		/* Allocate a buffer where we construct the new block. */
 		s->base = kzalloc(sb->s_blocksize, GFP_NOFS);
-		/* assert(header == s->base) */
 		error = -ENOMEM;
 		if (s->base == NULL)
 			goto cleanup;