Message ID | 1313078831-2511-7-git-send-email-holt@sgi.com |
---|---|
State | Superseded, archived |
Delegated to: | David Miller |
Headers | show |
On 08/11/2011 06:07 PM, Robin Holt wrote: > Allow the p1010 processor to select the flexcan network driver. > > Signed-off-by: Robin Holt <holt@sgi.com> > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>, > Acked-by: Wolfgang Grandegger <wg@grandegger.com>, > Cc: U Bhaskar-B22300 <B22300@freescale.com> > Cc: socketcan-core@lists.berlios.de, > Cc: netdev@vger.kernel.org, > Cc: PPC list <linuxppc-dev@lists.ozlabs.org> > Cc: Kumar Gala <galak@kernel.crashing.org> > --- > arch/powerpc/boot/dts/p1010rdb.dts | 8 ++++++++ > arch/powerpc/platforms/85xx/Kconfig | 2 ++ > 2 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/boot/dts/p1010rdb.dts b/arch/powerpc/boot/dts/p1010rdb.dts > index d6c669c..df89b60 100644 > --- a/arch/powerpc/boot/dts/p1010rdb.dts > +++ b/arch/powerpc/boot/dts/p1010rdb.dts > @@ -171,6 +171,14 @@ > }; > }; > > + can@1c000 { > + clock-frequency = <0x0bebc1fc>; > + }; clock-frequency = <200000000>; // filled in by boot-loader Is better readable and makes clear that the value is filled in by the boot loader. Usually we specify "<0>" in that case but it will *not* work with your board because U-Boot fills into the property "clock_freq" the CCB-frequency, which is twice as much. This needs to be fixed. > + can1: can@1d000 { What is the "can1:" good for? > + clock-frequency = <0x0bebc1fc>; See above. Wolfgang. > usb@22000 { > phy_type = "utmi"; > }; > diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig > index 498534c..c4304ae 100644 > --- a/arch/powerpc/platforms/85xx/Kconfig > +++ b/arch/powerpc/platforms/85xx/Kconfig > @@ -70,6 +70,8 @@ config MPC85xx_RDB > config P1010_RDB > bool "Freescale P1010RDB" > select DEFAULT_UIMAGE > + select HAVE_CAN_FLEXCAN if NET && CAN > + select PPC_CLOCK if CAN_FLEXCAN > help > This option enables support for the MPC85xx RDB (P1010 RDB) board > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Aug 11, 2011 at 06:35:08PM +0200, Wolfgang Grandegger wrote: > On 08/11/2011 06:07 PM, Robin Holt wrote: > > Allow the p1010 processor to select the flexcan network driver. > > > > Signed-off-by: Robin Holt <holt@sgi.com> > > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>, > > Acked-by: Wolfgang Grandegger <wg@grandegger.com>, > > Cc: U Bhaskar-B22300 <B22300@freescale.com> > > Cc: socketcan-core@lists.berlios.de, > > Cc: netdev@vger.kernel.org, > > Cc: PPC list <linuxppc-dev@lists.ozlabs.org> > > Cc: Kumar Gala <galak@kernel.crashing.org> > > --- > > arch/powerpc/boot/dts/p1010rdb.dts | 8 ++++++++ > > arch/powerpc/platforms/85xx/Kconfig | 2 ++ > > 2 files changed, 10 insertions(+), 0 deletions(-) > > > > diff --git a/arch/powerpc/boot/dts/p1010rdb.dts b/arch/powerpc/boot/dts/p1010rdb.dts > > index d6c669c..df89b60 100644 > > --- a/arch/powerpc/boot/dts/p1010rdb.dts > > +++ b/arch/powerpc/boot/dts/p1010rdb.dts > > @@ -171,6 +171,14 @@ > > }; > > }; > > > > + can@1c000 { > > + clock-frequency = <0x0bebc1fc>; > > + }; > > > clock-frequency = <200000000>; // filled in by boot-loader > > Is better readable and makes clear that the value is filled in by the > boot loader. Usually we specify "<0>" in that case but it will *not* > work with your board because U-Boot fills into the property "clock_freq" > the CCB-frequency, which is twice as much. This needs to be fixed. I guess the question then is, should I not add the clock-frequency to this file and let this fall back upon the boot-loader? Until the boot loader is up-to-speed, my test .dts file will need to define it. Thanks, Robin > > > + can1: can@1d000 { > > What is the "can1:" good for? > > > + clock-frequency = <0x0bebc1fc>; > > See above. > > Wolfgang. > > > > > > usb@22000 { > > phy_type = "utmi"; > > }; > > diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig > > index 498534c..c4304ae 100644 > > --- a/arch/powerpc/platforms/85xx/Kconfig > > +++ b/arch/powerpc/platforms/85xx/Kconfig > > @@ -70,6 +70,8 @@ config MPC85xx_RDB > > config P1010_RDB > > bool "Freescale P1010RDB" > > select DEFAULT_UIMAGE > > + select HAVE_CAN_FLEXCAN if NET && CAN > > + select PPC_CLOCK if CAN_FLEXCAN > > help > > This option enables support for the MPC85xx RDB (P1010 RDB) board > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Aug 11, 2011, at 11:07 AM, Robin Holt wrote: > Allow the p1010 processor to select the flexcan network driver. > > Signed-off-by: Robin Holt <holt@sgi.com> > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>, > Acked-by: Wolfgang Grandegger <wg@grandegger.com>, > Cc: U Bhaskar-B22300 <B22300@freescale.com> > Cc: socketcan-core@lists.berlios.de, > Cc: netdev@vger.kernel.org, > Cc: PPC list <linuxppc-dev@lists.ozlabs.org> > Cc: Kumar Gala <galak@kernel.crashing.org> > --- > arch/powerpc/boot/dts/p1010rdb.dts | 8 ++++++++ > arch/powerpc/platforms/85xx/Kconfig | 2 ++ > 2 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/boot/dts/p1010rdb.dts b/arch/powerpc/boot/dts/p1010rdb.dts > index d6c669c..df89b60 100644 > --- a/arch/powerpc/boot/dts/p1010rdb.dts > +++ b/arch/powerpc/boot/dts/p1010rdb.dts > @@ -171,6 +171,14 @@ > }; > }; > > + can@1c000 { > + clock-frequency = <0x0bebc1fc>; > + }; > + > + can1: can@1d000 { > + clock-frequency = <0x0bebc1fc>; > + }; > + set them to 0, as we expect u-boot to fill them in. > usb@22000 { > phy_type = "utmi"; > }; > diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig > index 498534c..c4304ae 100644 > --- a/arch/powerpc/platforms/85xx/Kconfig > +++ b/arch/powerpc/platforms/85xx/Kconfig > @@ -70,6 +70,8 @@ config MPC85xx_RDB > config P1010_RDB > bool "Freescale P1010RDB" > select DEFAULT_UIMAGE > + select HAVE_CAN_FLEXCAN if NET && CAN > + select PPC_CLOCK if CAN_FLEXCAN Can you move this to arch/powerpc/Kconfig & FSL_SOC instead. > help > This option enables support for the MPC85xx RDB (P1010 RDB) board > > -- > 1.7.2.1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Aug 11, 2011 at 12:41:34PM -0500, Kumar Gala wrote: > > On Aug 11, 2011, at 11:07 AM, Robin Holt wrote: > > > Allow the p1010 processor to select the flexcan network driver. > > > > Signed-off-by: Robin Holt <holt@sgi.com> > > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>, > > Acked-by: Wolfgang Grandegger <wg@grandegger.com>, > > Cc: U Bhaskar-B22300 <B22300@freescale.com> > > Cc: socketcan-core@lists.berlios.de, > > Cc: netdev@vger.kernel.org, > > Cc: PPC list <linuxppc-dev@lists.ozlabs.org> > > Cc: Kumar Gala <galak@kernel.crashing.org> > > --- > > arch/powerpc/boot/dts/p1010rdb.dts | 8 ++++++++ > > arch/powerpc/platforms/85xx/Kconfig | 2 ++ > > 2 files changed, 10 insertions(+), 0 deletions(-) > > > > diff --git a/arch/powerpc/boot/dts/p1010rdb.dts b/arch/powerpc/boot/dts/p1010rdb.dts > > index d6c669c..df89b60 100644 > > --- a/arch/powerpc/boot/dts/p1010rdb.dts > > +++ b/arch/powerpc/boot/dts/p1010rdb.dts > > @@ -171,6 +171,14 @@ > > }; > > }; > > > > + can@1c000 { > > + clock-frequency = <0x0bebc1fc>; > > + }; > > + > > + can1: can@1d000 { > > + clock-frequency = <0x0bebc1fc>; > > + }; > > + > > set them to 0, as we expect u-boot to fill them in. Done. > > > usb@22000 { > > phy_type = "utmi"; > > }; > > diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig > > index 498534c..c4304ae 100644 > > --- a/arch/powerpc/platforms/85xx/Kconfig > > +++ b/arch/powerpc/platforms/85xx/Kconfig > > @@ -70,6 +70,8 @@ config MPC85xx_RDB > > config P1010_RDB > > bool "Freescale P1010RDB" > > select DEFAULT_UIMAGE > > + select HAVE_CAN_FLEXCAN if NET && CAN > > + select PPC_CLOCK if CAN_FLEXCAN > > Can you move this to arch/powerpc/Kconfig & FSL_SOC instead. I am not sure. FSL_SOC seems to come with any of the freescale system on a chip. I would not be that worried, about the flexcan build as I think that is sufficiently agostic where we will not see problems, but now we could end up with build failures on any of the other configs which select CAN_FLEXCAN. I would normally want to do all those builds, but there is no way I would know how to do that with my limited knowledge of powerpc and freescale. If you are comfortable with that, I will happily make the change. Thanks, Robin -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/powerpc/boot/dts/p1010rdb.dts b/arch/powerpc/boot/dts/p1010rdb.dts index d6c669c..df89b60 100644 --- a/arch/powerpc/boot/dts/p1010rdb.dts +++ b/arch/powerpc/boot/dts/p1010rdb.dts @@ -171,6 +171,14 @@ }; }; + can@1c000 { + clock-frequency = <0x0bebc1fc>; + }; + + can1: can@1d000 { + clock-frequency = <0x0bebc1fc>; + }; + usb@22000 { phy_type = "utmi"; }; diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig index 498534c..c4304ae 100644 --- a/arch/powerpc/platforms/85xx/Kconfig +++ b/arch/powerpc/platforms/85xx/Kconfig @@ -70,6 +70,8 @@ config MPC85xx_RDB config P1010_RDB bool "Freescale P1010RDB" select DEFAULT_UIMAGE + select HAVE_CAN_FLEXCAN if NET && CAN + select PPC_CLOCK if CAN_FLEXCAN help This option enables support for the MPC85xx RDB (P1010 RDB) board