diff mbox series

nokia_rx51: disable obsolete VIDEO config

Message ID 20201018191827.9603-10-agust@denx.de
State Superseded
Delegated to: Anatolij Gustschin
Headers show
Series nokia_rx51: disable obsolete VIDEO config | expand

Commit Message

Anatolij Gustschin Oct. 18, 2020, 7:18 p.m. UTC
DM_VIDEO conversion deadline has passed, disable VIDEO config.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
Cc: Pali Rohár <pali@kernel.org>
---
 configs/nokia_rx51_defconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Pali Rohár Oct. 18, 2020, 8:41 p.m. UTC | #1
On Sunday 18 October 2020 21:18:24 Anatolij Gustschin wrote:
> DM_VIDEO conversion deadline has passed, disable VIDEO config.
> 
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Pali Rohár <pali@kernel.org>
> ---
>  configs/nokia_rx51_defconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configs/nokia_rx51_defconfig b/configs/nokia_rx51_defconfig
> index e249dff774..3310bc7ae9 100644
> --- a/configs/nokia_rx51_defconfig
> +++ b/configs/nokia_rx51_defconfig
> @@ -54,8 +54,8 @@ CONFIG_USB_MUSB_HCD=y
>  CONFIG_USB_MUSB_UDC=y
>  CONFIG_USB_OMAP3=y
>  CONFIG_TWL4030_USB=y
> -CONFIG_VIDEO=y
> -CONFIG_CFB_CONSOLE_ANSI=y

Please, do not disable CONFIG_CFB_CONSOLE_ANSI, it will make debugging
on real Nokia N900 very hard...

> +# CONFIG_VIDEO is not set
> +# CONFIG_CFB_CONSOLE_ANSI is not set
>  # CONFIG_VGA_AS_SINGLE_DEVICE is not set
>  CONFIG_SPLASH_SCREEN=y
>  # CONFIG_GZIP is not set
> -- 
> 2.17.1
>
Anatolij Gustschin Oct. 18, 2020, 8:54 p.m. UTC | #2
On Sun, 18 Oct 2020 22:41:30 +0200
Pali Rohár pali@kernel.org wrote:

> > -CONFIG_VIDEO=y
> > -CONFIG_CFB_CONSOLE_ANSI=y  
> 
> Please, do not disable CONFIG_CFB_CONSOLE_ANSI, it will make debugging
> on real Nokia N900 very hard...

the patch completely disables video console support, so there is no
use for CONFIG_CFB_CONSOLE_ANSI. The reason is that it has not been
converted to DM_VIDEO. The conversion deadline was 2019.07 an nobody
cared to do it, so I'm going to apply the patch for v2021.01.
If you need video console support, then please convert to DM_VIDEO.

Thanks,
Anatolij
Pali Rohár Oct. 18, 2020, 8:59 p.m. UTC | #3
On Sunday 18 October 2020 22:54:41 Anatolij Gustschin wrote:
> If you need video console support, then please convert to DM_VIDEO.

Ok, but I'm waiting until other N900 issues are fixed. There are pending
patches which needs to be reviewed and merged.

Without video console support it is hard and probably impossible to
debug on real N900.

So do not disable video console support, it would make fixing and
testing N900 stuff just more complicated.
Tom Rini Oct. 19, 2020, 1:17 a.m. UTC | #4
On Sun, Oct 18, 2020 at 10:59:36PM +0200, Pali Rohár wrote:
> On Sunday 18 October 2020 22:54:41 Anatolij Gustschin wrote:
> > If you need video console support, then please convert to DM_VIDEO.
> 
> Ok, but I'm waiting until other N900 issues are fixed. There are pending
> patches which needs to be reviewed and merged.

Can you please list which?  And is that all of them or are there other
issues still?

> Without video console support it is hard and probably impossible to
> debug on real N900.
> 
> So do not disable video console support, it would make fixing and
> testing N900 stuff just more complicated.

Then please see about converting the video driver, on top of the
other patches.  Thanks!
Pali Rohár Oct. 20, 2020, 9:30 a.m. UTC | #5
Hello!

On Sunday 18 October 2020 21:17:43 Tom Rini wrote:
> On Sun, Oct 18, 2020 at 10:59:36PM +0200, Pali Rohár wrote:
> > On Sunday 18 October 2020 22:54:41 Anatolij Gustschin wrote:
> > > If you need video console support, then please convert to DM_VIDEO.
> > 
> > Ok, but I'm waiting until other N900 issues are fixed. There are pending
> > patches which needs to be reviewed and merged.
> 
> Can you please list which?

U-Boot is crashing and board is automatically rebooted:

https://lists.denx.de/pipermail/u-boot/2020-August/422968.html

Last email in that thread:

https://lists.denx.de/pipermail/u-boot/2020-September/427704.html

> And is that all of them or are there other
> issues still?

Except above, there is another issue with i2c, details are here:

https://lists.denx.de/pipermail/u-boot/2020-April/408526.html

(but even without fixing this issue U-Boot works and can boot kernel,
just it is slower)

> > Without video console support it is hard and probably impossible to
> > debug on real N900.
> > 
> > So do not disable video console support, it would make fixing and
> > testing N900 stuff just more complicated.
> 
> Then please see about converting the video driver, on top of the
> other patches.  Thanks!
> 
> -- 
> Tom
Tom Rini Oct. 20, 2020, 2:17 p.m. UTC | #6
On Tue, Oct 20, 2020 at 11:30:51AM +0200, Pali Rohár wrote:
> Hello!
> 
> On Sunday 18 October 2020 21:17:43 Tom Rini wrote:
> > On Sun, Oct 18, 2020 at 10:59:36PM +0200, Pali Rohár wrote:
> > > On Sunday 18 October 2020 22:54:41 Anatolij Gustschin wrote:
> > > > If you need video console support, then please convert to DM_VIDEO.
> > > 
> > > Ok, but I'm waiting until other N900 issues are fixed. There are pending
> > > patches which needs to be reviewed and merged.
> > 
> > Can you please list which?
> 
> U-Boot is crashing and board is automatically rebooted:
> 
> https://lists.denx.de/pipermail/u-boot/2020-August/422968.html
> 
> Last email in that thread:
> 
> https://lists.denx.de/pipermail/u-boot/2020-September/427704.html

So there's the unresolved MMC issue, but you can work-around that it
sounded like?

> > And is that all of them or are there other
> > issues still?
> 
> Except above, there is another issue with i2c, details are here:
> 
> https://lists.denx.de/pipermail/u-boot/2020-April/408526.html
> 
> (but even without fixing this issue U-Boot works and can boot kernel,
> just it is slower)
> 
> > > Without video console support it is hard and probably impossible to
> > > debug on real N900.
> > > 
> > > So do not disable video console support, it would make fixing and
> > > testing N900 stuff just more complicated.
> > 
> > Then please see about converting the video driver, on top of the
> > other patches.  Thanks!

So, perhaps another way to look at this (and the rest of the series) is,
Anatolij, what needs updating for these platforms?  Is it that no DM
conversion has been done for them, or not enabling CONFIG_DM_VIDEO?  It
looks like for the nokia_rx51 there's no CONFIG_DM conversion done at
all yet, which is the bigger problem.   But what about sunxi?  Is there
some video specific conversions that need to happen, or just enabling
different options once DM is enabled?  Thanks!
Anatolij Gustschin Oct. 20, 2020, 5:34 p.m. UTC | #7
On Tue, 20 Oct 2020 10:17:07 -0400
Tom Rini trini@konsulko.com wrote:
...
> > > > Without video console support it is hard and probably impossible to
> > > > debug on real N900.
> > > > 
> > > > So do not disable video console support, it would make fixing and
> > > > testing N900 stuff just more complicated.  
> > > 
> > > Then please see about converting the video driver, on top of the
> > > other patches.  Thanks!  
> 
> So, perhaps another way to look at this (and the rest of the series) is,
> Anatolij, what needs updating for these platforms?  Is it that no DM
> conversion has been done for them, or not enabling CONFIG_DM_VIDEO?

for at91sam9, ls1021aqds, ls1021atwr, mx6sxsabresd, mx7dsabresd and many
sunxi boards DM_VIDEO conversion is missing.

nokia_rx51 has DM disabled, so this is a bigger problem. And CONFIG_VIDEO
can be disabled for nokia_rx51 if we remove CFB_CONSOLE CONFIG_VIDEO
dependency in Kconfig, it seems. This board doesn't use display controller
driver, it just configures fixed frame buffer address for CFB_CONSOLE.

No DM yet: mx23evk, sansa_fuze_plus, xfi3

> It looks like for the nokia_rx51 there's no CONFIG_DM conversion done at
> all yet, which is the bigger problem.   But what about sunxi?  Is there
> some video specific conversions that need to happen, or just enabling
> different options once DM is enabled?  Thanks!

for many sunxi variants DM_VIDEO conversion is missing. Jagan did
a patch [1], but there are some simplefb related issues with it.

[1] http://patchwork.ozlabs.org/project/uboot/patch/20200617202437.301108-4-jagan@amarulasolutions.com

--
Anatolij
Pali Rohár Oct. 21, 2020, 9:08 a.m. UTC | #8
On Tuesday 20 October 2020 10:17:07 Tom Rini wrote:
> On Tue, Oct 20, 2020 at 11:30:51AM +0200, Pali Rohár wrote:
> > Hello!
> > 
> > On Sunday 18 October 2020 21:17:43 Tom Rini wrote:
> > > On Sun, Oct 18, 2020 at 10:59:36PM +0200, Pali Rohár wrote:
> > > > On Sunday 18 October 2020 22:54:41 Anatolij Gustschin wrote:
> > > > > If you need video console support, then please convert to DM_VIDEO.
> > > > 
> > > > Ok, but I'm waiting until other N900 issues are fixed. There are pending
> > > > patches which needs to be reviewed and merged.
> > > 
> > > Can you please list which?
> > 
> > U-Boot is crashing and board is automatically rebooted:
> > 
> > https://lists.denx.de/pipermail/u-boot/2020-August/422968.html
> > 
> > Last email in that thread:
> > 
> > https://lists.denx.de/pipermail/u-boot/2020-September/427704.html
> 
> So there's the unresolved MMC issue, but you can work-around that it
> sounded like?

Yes, there is mmc issue, I have found which commit caused it and
because nobody was able to debug / understand what is happening I have
sent revert patch, which fixes that issue, until somebody solve issue in
original patch.

But I do not see any progress on either applying revert patch or fixing
original patch.

And I do not like to have custom patch in my local branch (and
periodically rebasing it) as it just another layer of complication.

Could we move somehow in this issue?
Tom Rini Oct. 21, 2020, 12:47 p.m. UTC | #9
On Wed, Oct 21, 2020 at 11:08:37AM +0200, Pali Rohár wrote:
> On Tuesday 20 October 2020 10:17:07 Tom Rini wrote:
> > On Tue, Oct 20, 2020 at 11:30:51AM +0200, Pali Rohár wrote:
> > > Hello!
> > > 
> > > On Sunday 18 October 2020 21:17:43 Tom Rini wrote:
> > > > On Sun, Oct 18, 2020 at 10:59:36PM +0200, Pali Rohár wrote:
> > > > > On Sunday 18 October 2020 22:54:41 Anatolij Gustschin wrote:
> > > > > > If you need video console support, then please convert to DM_VIDEO.
> > > > > 
> > > > > Ok, but I'm waiting until other N900 issues are fixed. There are pending
> > > > > patches which needs to be reviewed and merged.
> > > > 
> > > > Can you please list which?
> > > 
> > > U-Boot is crashing and board is automatically rebooted:
> > > 
> > > https://lists.denx.de/pipermail/u-boot/2020-August/422968.html
> > > 
> > > Last email in that thread:
> > > 
> > > https://lists.denx.de/pipermail/u-boot/2020-September/427704.html
> > 
> > So there's the unresolved MMC issue, but you can work-around that it
> > sounded like?
> 
> Yes, there is mmc issue, I have found which commit caused it and
> because nobody was able to debug / understand what is happening I have
> sent revert patch, which fixes that issue, until somebody solve issue in
> original patch.
> 
> But I do not see any progress on either applying revert patch or fixing
> original patch.
> 
> And I do not like to have custom patch in my local branch (and
> periodically rebasing it) as it just another layer of complication.
> 
> Could we move somehow in this issue?

No, it's probably stuck until you can fix the problem or otherwise add a
"quirk" for your platform.  What does Linux do in this case?
Pali Rohár Oct. 24, 2020, 10:06 a.m. UTC | #10
On Wednesday 21 October 2020 08:47:02 Tom Rini wrote:
> On Wed, Oct 21, 2020 at 11:08:37AM +0200, Pali Rohár wrote:
> > On Tuesday 20 October 2020 10:17:07 Tom Rini wrote:
> > > On Tue, Oct 20, 2020 at 11:30:51AM +0200, Pali Rohár wrote:
> > > > Hello!
> > > > 
> > > > On Sunday 18 October 2020 21:17:43 Tom Rini wrote:
> > > > > On Sun, Oct 18, 2020 at 10:59:36PM +0200, Pali Rohár wrote:
> > > > > > On Sunday 18 October 2020 22:54:41 Anatolij Gustschin wrote:
> > > > > > > If you need video console support, then please convert to DM_VIDEO.
> > > > > > 
> > > > > > Ok, but I'm waiting until other N900 issues are fixed. There are pending
> > > > > > patches which needs to be reviewed and merged.
> > > > > 
> > > > > Can you please list which?
> > > > 
> > > > U-Boot is crashing and board is automatically rebooted:
> > > > 
> > > > https://lists.denx.de/pipermail/u-boot/2020-August/422968.html
> > > > 
> > > > Last email in that thread:
> > > > 
> > > > https://lists.denx.de/pipermail/u-boot/2020-September/427704.html
> > > 
> > > So there's the unresolved MMC issue, but you can work-around that it
> > > sounded like?
> > 
> > Yes, there is mmc issue, I have found which commit caused it and
> > because nobody was able to debug / understand what is happening I have
> > sent revert patch, which fixes that issue, until somebody solve issue in
> > original patch.
> > 
> > But I do not see any progress on either applying revert patch or fixing
> > original patch.
> > 
> > And I do not like to have custom patch in my local branch (and
> > periodically rebasing it) as it just another layer of complication.
> > 
> > Could we move somehow in this issue?
> 
> No, it's probably stuck until you can fix the problem or otherwise add a
> "quirk" for your platform.  What does Linux do in this case?

Well, I provided all requested information, just I'm lacking any new
response from developers / maintainers of particular code.

I have already identified problematic place / commit and I have already
sent revert patch which fixing this issue.

Tom, what else do you need?

I see the main issue now that nobody reviewed / merged patch and nobody
responded to emails which I have sent more then 2 months ago.
Tom Rini Oct. 24, 2020, 12:19 p.m. UTC | #11
On Sat, Oct 24, 2020 at 12:46:45PM +0200, Merlijn Wajer wrote:
> Hi,
> 
> On 24/10/2020 12:06, Pali Rohár wrote:
> > On Wednesday 21 October 2020 08:47:02 Tom Rini wrote:
> >> On Wed, Oct 21, 2020 at 11:08:37AM +0200, Pali Rohár wrote:
> >>> On Tuesday 20 October 2020 10:17:07 Tom Rini wrote:
> >>>> On Tue, Oct 20, 2020 at 11:30:51AM +0200, Pali Rohár wrote:
> <snip>
> >>> Yes, there is mmc issue, I have found which commit caused it and
> >>> because nobody was able to debug / understand what is happening I have
> >>> sent revert patch, which fixes that issue, until somebody solve issue in
> >>> original patch.
> >>>
> >>> But I do not see any progress on either applying revert patch or fixing
> >>> original patch.
> >>>
> >>> And I do not like to have custom patch in my local branch (and
> >>> periodically rebasing it) as it just another layer of complication.
> >>>
> >>> Could we move somehow in this issue?
> >>
> >> No, it's probably stuck until you can fix the problem or otherwise add a
> >> "quirk" for your platform.  What does Linux do in this case?
> > 
> > Well, I provided all requested information, just I'm lacking any new
> > response from developers / maintainers of particular code.
> > 
> > I have already identified problematic place / commit and I have already
> > sent revert patch which fixing this issue.
> > 
> > Tom, what else do you need?
> > 
> > I see the main issue now that nobody reviewed / merged patch and nobody
> > responded to emails which I have sent more then 2 months ago.
> 
> I would like to add my voice for reverting the patches that break the
> support, and work from that point to improve support and eventually
> migrate to DT.
> 
> Maemo Leste has a lot of Nokia N900 users, and this is blocking us from
> moving to mainline u-boot. Is it possible to get the opinion of the
> original patch authors on this?
> 
> I am set up with a serial module on the Nokia N900, so I can help
> provide specific debug info.

Let me add in the TI folks that might be able to look in to any of this
today.  But the next problem is that the rx51 needs to be converted to
use DM in U-Boot.  It's throwing up a ton of "you need to convert to X
by <some release in 2019> or this board may be removed" warnings at
build.  I really really want to see some of this start to be addressed.
Pali Rohár Oct. 25, 2020, 11:04 p.m. UTC | #12
On Saturday 24 October 2020 08:19:31 Tom Rini wrote:
> Let me add in the TI folks that might be able to look in to any of this
> today.  But the next problem is that the rx51 needs to be converted to
> use DM in U-Boot.  It's throwing up a ton of "you need to convert to X
> by <some release in 2019> or this board may be removed" warnings at
> build.  I really really want to see some of this start to be addressed.

Well, I do not see any warnings at build, I'm building U-Boot by command:

$ make nokia_rx51_defconfig && make SOURCE_DATE_EPOCH=0 ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- u-boot.bin

Maybe I'm doing something wrong that I do not see it? Or is there any
other way to "list all issues for N900" which needs to be addressed?

Anyway, I'm looking at DM and as the first step I will do conversion of
code to CONFIG_DM_I2C. It is OK for you? Maybe it brings some light to
non-working second i2c bus.

I hope that TI (or other) developers look at that mmc issue as this is
blocking all N900 users.
Tom Rini Oct. 25, 2020, 11:55 p.m. UTC | #13
On Mon, Oct 26, 2020 at 12:04:54AM +0100, Pali Rohár wrote:
> On Saturday 24 October 2020 08:19:31 Tom Rini wrote:
> > Let me add in the TI folks that might be able to look in to any of this
> > today.  But the next problem is that the rx51 needs to be converted to
> > use DM in U-Boot.  It's throwing up a ton of "you need to convert to X
> > by <some release in 2019> or this board may be removed" warnings at
> > build.  I really really want to see some of this start to be addressed.
> 
> Well, I do not see any warnings at build, I'm building U-Boot by command:
> 
> $ make nokia_rx51_defconfig && make SOURCE_DATE_EPOCH=0 ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- u-boot.bin

Note that ARCH=arm is meaningless in U-Boot.

> Maybe I'm doing something wrong that I do not see it? Or is there any
> other way to "list all issues for N900" which needs to be addressed?

Yes, the "all" target.

> Anyway, I'm looking at DM and as the first step I will do conversion of
> code to CONFIG_DM_I2C. It is OK for you? Maybe it brings some light to
> non-working second i2c bus.
> 
> I hope that TI (or other) developers look at that mmc issue as this is
> blocking all N900 users.

Maybe converting to DM_MMC will also clear up or shed more light on the
problem you have there as well.
Anatolij Gustschin Oct. 25, 2020, 11:59 p.m. UTC | #14
On Mon, 26 Oct 2020 00:04:54 +0100
Pali Rohár pali@kernel.org wrote:
...
> Maybe I'm doing something wrong that I do not see it? Or is there any
> other way to "list all issues for N900" which needs to be addressed?

$ ./tools/buildman/buildman nokia_rx51
Building current source for 1 boards (1 thread, 12 jobs per thread)
       arm:  w+   nokia_rx51                
+===================== WARNING ======================
+This board does not use CONFIG_DM. CONFIG_DM will be
+compulsory starting with the v2020.01 release.
+Failure to update may result in board removal.
+See doc/driver-model/migration.rst for more info.
+====================================================
+This board does not use CONFIG_DM_MMC. Please update
+the board to use CONFIG_DM_MMC before the v2019.04 release.
+Failure to update by the deadline may result in board removal.
+This board does not use CONFIG_DM_USB. Please update
+the board to use CONFIG_DM_USB before the v2019.07 release.
+This board does not use CONFIG_DM_VIDEO Please update
+the board to use CONFIG_DM_VIDEO before the v2019.07 release.
+This board does not use CONFIG_WDT (DM watchdog support).
+Please update the board to use CONFIG_WDT before the
+v2019.10 release.
    0    1    0 /1              nokia_rx51
Completed: 1 total built, duration 0:00:04, rate 0.25

--
Anatolij
Pali Rohár Oct. 26, 2020, 12:19 a.m. UTC | #15
On Sunday 25 October 2020 19:55:28 Tom Rini wrote:
> On Mon, Oct 26, 2020 at 12:04:54AM +0100, Pali Rohár wrote:
> > On Saturday 24 October 2020 08:19:31 Tom Rini wrote:
> > > Let me add in the TI folks that might be able to look in to any of this
> > > today.  But the next problem is that the rx51 needs to be converted to
> > > use DM in U-Boot.  It's throwing up a ton of "you need to convert to X
> > > by <some release in 2019> or this board may be removed" warnings at
> > > build.  I really really want to see some of this start to be addressed.
> > 
> > Well, I do not see any warnings at build, I'm building U-Boot by command:
> > 
> > $ make nokia_rx51_defconfig && make SOURCE_DATE_EPOCH=0 ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- u-boot.bin
> 
> Note that ARCH=arm is meaningless in U-Boot.
> 
> > Maybe I'm doing something wrong that I do not see it? Or is there any
> > other way to "list all issues for N900" which needs to be addressed?
> 
> Yes, the "all" target.

Ok, now I see them! I used in all my scripts only u-boot.bin target (as
I needed only this one binary), so basically all warnings were perfectly
hidden also in past and I did not know about it...

Maybe there are more people who do not know about these warnings? What
about printing them as part of u-boot.bin target?

> > Anyway, I'm looking at DM and as the first step I will do conversion of
> > code to CONFIG_DM_I2C. It is OK for you? Maybe it brings some light to
> > non-working second i2c bus.
> > 
> > I hope that TI (or other) developers look at that mmc issue as this is
> > blocking all N900 users.
> 
> Maybe converting to DM_MMC will also clear up or shed more light on the
> problem you have there as well.
> 
> -- 
> Tom
Tom Rini Oct. 26, 2020, 12:25 a.m. UTC | #16
On Mon, Oct 26, 2020 at 01:19:43AM +0100, Pali Rohár wrote:
> On Sunday 25 October 2020 19:55:28 Tom Rini wrote:
> > On Mon, Oct 26, 2020 at 12:04:54AM +0100, Pali Rohár wrote:
> > > On Saturday 24 October 2020 08:19:31 Tom Rini wrote:
> > > > Let me add in the TI folks that might be able to look in to any of this
> > > > today.  But the next problem is that the rx51 needs to be converted to
> > > > use DM in U-Boot.  It's throwing up a ton of "you need to convert to X
> > > > by <some release in 2019> or this board may be removed" warnings at
> > > > build.  I really really want to see some of this start to be addressed.
> > > 
> > > Well, I do not see any warnings at build, I'm building U-Boot by command:
> > > 
> > > $ make nokia_rx51_defconfig && make SOURCE_DATE_EPOCH=0 ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- u-boot.bin
> > 
> > Note that ARCH=arm is meaningless in U-Boot.
> > 
> > > Maybe I'm doing something wrong that I do not see it? Or is there any
> > > other way to "list all issues for N900" which needs to be addressed?
> > 
> > Yes, the "all" target.
> 
> Ok, now I see them! I used in all my scripts only u-boot.bin target (as
> I needed only this one binary), so basically all warnings were perfectly
> hidden also in past and I did not know about it...
> 
> Maybe there are more people who do not know about these warnings? What
> about printing them as part of u-boot.bin target?

I was wondering about that too, but I'm not sure.
Lokesh Vutla Oct. 29, 2020, 8:36 a.m. UTC | #17
On 24/10/20 5:49 pm, Tom Rini wrote:
> On Sat, Oct 24, 2020 at 12:46:45PM +0200, Merlijn Wajer wrote:
>> Hi,
>>
>> On 24/10/2020 12:06, Pali Rohár wrote:
>>> On Wednesday 21 October 2020 08:47:02 Tom Rini wrote:
>>>> On Wed, Oct 21, 2020 at 11:08:37AM +0200, Pali Rohár wrote:
>>>>> On Tuesday 20 October 2020 10:17:07 Tom Rini wrote:
>>>>>> On Tue, Oct 20, 2020 at 11:30:51AM +0200, Pali Rohár wrote:
>> <snip>
>>>>> Yes, there is mmc issue, I have found which commit caused it and
>>>>> because nobody was able to debug / understand what is happening I have
>>>>> sent revert patch, which fixes that issue, until somebody solve issue in
>>>>> original patch.
>>>>>
>>>>> But I do not see any progress on either applying revert patch or fixing
>>>>> original patch.
>>>>>
>>>>> And I do not like to have custom patch in my local branch (and
>>>>> periodically rebasing it) as it just another layer of complication.
>>>>>
>>>>> Could we move somehow in this issue?
>>>>
>>>> No, it's probably stuck until you can fix the problem or otherwise add a
>>>> "quirk" for your platform.  What does Linux do in this case?
>>>
>>> Well, I provided all requested information, just I'm lacking any new
>>> response from developers / maintainers of particular code.
>>>
>>> I have already identified problematic place / commit and I have already
>>> sent revert patch which fixing this issue.
>>>
>>> Tom, what else do you need?
>>>
>>> I see the main issue now that nobody reviewed / merged patch and nobody
>>> responded to emails which I have sent more then 2 months ago.
>>
>> I would like to add my voice for reverting the patches that break the
>> support, and work from that point to improve support and eventually
>> migrate to DT.
>>
>> Maemo Leste has a lot of Nokia N900 users, and this is blocking us from
>> moving to mainline u-boot. Is it possible to get the opinion of the
>> original patch authors on this?
>>
>> I am set up with a serial module on the Nokia N900, so I can help
>> provide specific debug info.
> 
> Let me add in the TI folks that might be able to look in to any of this
> today.  But the next problem is that the rx51 needs to be converted to
> use DM in U-Boot.  It's throwing up a ton of "you need to convert to X
> by <some release in 2019> or this board may be removed" warnings at
> build.  I really really want to see some of this start to be addressed.


IIUC, the breakage is happening in non-DM code. I don't think non-DM code is
maintained anymore for mmc. As Tom suggested we should start using DM for Nokia RX51

Thanks and regards,
Lokesh
>
Pali Rohár Oct. 30, 2020, 7:09 p.m. UTC | #18
On Thursday 29 October 2020 14:06:30 Lokesh Vutla wrote:
> On 24/10/20 5:49 pm, Tom Rini wrote:
> > On Sat, Oct 24, 2020 at 12:46:45PM +0200, Merlijn Wajer wrote:
> >> Hi,
> >>
> >> On 24/10/2020 12:06, Pali Rohár wrote:
> >>> On Wednesday 21 October 2020 08:47:02 Tom Rini wrote:
> >>>> On Wed, Oct 21, 2020 at 11:08:37AM +0200, Pali Rohár wrote:
> >>>>> On Tuesday 20 October 2020 10:17:07 Tom Rini wrote:
> >>>>>> On Tue, Oct 20, 2020 at 11:30:51AM +0200, Pali Rohár wrote:
> >> <snip>
> >>>>> Yes, there is mmc issue, I have found which commit caused it and
> >>>>> because nobody was able to debug / understand what is happening I have
> >>>>> sent revert patch, which fixes that issue, until somebody solve issue in
> >>>>> original patch.
> >>>>>
> >>>>> But I do not see any progress on either applying revert patch or fixing
> >>>>> original patch.
> >>>>>
> >>>>> And I do not like to have custom patch in my local branch (and
> >>>>> periodically rebasing it) as it just another layer of complication.
> >>>>>
> >>>>> Could we move somehow in this issue?
> >>>>
> >>>> No, it's probably stuck until you can fix the problem or otherwise add a
> >>>> "quirk" for your platform.  What does Linux do in this case?
> >>>
> >>> Well, I provided all requested information, just I'm lacking any new
> >>> response from developers / maintainers of particular code.
> >>>
> >>> I have already identified problematic place / commit and I have already
> >>> sent revert patch which fixing this issue.
> >>>
> >>> Tom, what else do you need?
> >>>
> >>> I see the main issue now that nobody reviewed / merged patch and nobody
> >>> responded to emails which I have sent more then 2 months ago.
> >>
> >> I would like to add my voice for reverting the patches that break the
> >> support, and work from that point to improve support and eventually
> >> migrate to DT.
> >>
> >> Maemo Leste has a lot of Nokia N900 users, and this is blocking us from
> >> moving to mainline u-boot. Is it possible to get the opinion of the
> >> original patch authors on this?
> >>
> >> I am set up with a serial module on the Nokia N900, so I can help
> >> provide specific debug info.
> > 
> > Let me add in the TI folks that might be able to look in to any of this
> > today.  But the next problem is that the rx51 needs to be converted to
> > use DM in U-Boot.  It's throwing up a ton of "you need to convert to X
> > by <some release in 2019> or this board may be removed" warnings at
> > build.  I really really want to see some of this start to be addressed.
> 
> 
> IIUC, the breakage is happening in non-DM code.

No, this code is not non-DM specific. It is used also for DM builds.
diff mbox series

Patch

diff --git a/configs/nokia_rx51_defconfig b/configs/nokia_rx51_defconfig
index e249dff774..3310bc7ae9 100644
--- a/configs/nokia_rx51_defconfig
+++ b/configs/nokia_rx51_defconfig
@@ -54,8 +54,8 @@  CONFIG_USB_MUSB_HCD=y
 CONFIG_USB_MUSB_UDC=y
 CONFIG_USB_OMAP3=y
 CONFIG_TWL4030_USB=y
-CONFIG_VIDEO=y
-CONFIG_CFB_CONSOLE_ANSI=y
+# CONFIG_VIDEO is not set
+# CONFIG_CFB_CONSOLE_ANSI is not set
 # CONFIG_VGA_AS_SINGLE_DEVICE is not set
 CONFIG_SPLASH_SCREEN=y
 # CONFIG_GZIP is not set