| Message ID | 1602859382-19505-11-git-send-email-spujar@nvidia.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Audio graph card updates and usage with Tegra210 audio | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Fri, Oct 16, 2020 at 08:12:57PM +0530, Sameer Pujar wrote: > Add device tree binding properties of generic graph to ASoC component > devices. This allows to define audio ports out of these components or > DAIs and audio graph based sound card can be realised with this. > > Signed-off-by: Sameer Pujar <spujar@nvidia.com> > --- > Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml | 7 +++++++ > .../devicetree/bindings/sound/nvidia,tegra210-admaif.yaml | 7 +++++++ > Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml | 7 +++++++ > Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml | 7 +++++++ > Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml | 7 +++++++ > 5 files changed, 35 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml > index ed2fb32..23875b1 100644 > --- a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml > @@ -55,6 +55,13 @@ properties: > The name can be "DSPK1" or "DSPKx", where x depends on the maximum > available instances on a Tegra SoC. > > + ports: > + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/ports > + > +patternProperties: > + "^port(@[0-9a-f]+)?$": > + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/port You should have either 'ports' or a single 'port' (yes, the graph binding allowed multiple port nodes without 'ports', but that should be deprecated IMO)
>> Add device tree binding properties of generic graph to ASoC component >> devices. This allows to define audio ports out of these components or >> DAIs and audio graph based sound card can be realised with this. >> >> Signed-off-by: Sameer Pujar <spujar@nvidia.com> >> --- >> Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml | 7 +++++++ >> .../devicetree/bindings/sound/nvidia,tegra210-admaif.yaml | 7 +++++++ >> Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml | 7 +++++++ >> Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml | 7 +++++++ >> Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml | 7 +++++++ >> 5 files changed, 35 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml >> index ed2fb32..23875b1 100644 >> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml >> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml >> @@ -55,6 +55,13 @@ properties: >> The name can be "DSPK1" or "DSPKx", where x depends on the maximum >> available instances on a Tegra SoC. >> >> + ports: >> + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/ports >> + >> +patternProperties: >> + "^port(@[0-9a-f]+)?$": >> + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/port > You should have either 'ports' or a single 'port' (yes, the graph > binding allowed multiple port nodes without 'ports', but that should be > deprecated IMO) OK, will drop this and just use 'port' here.
diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml index ed2fb32..23875b1 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml @@ -55,6 +55,13 @@ properties: The name can be "DSPK1" or "DSPKx", where x depends on the maximum available instances on a Tegra SoC. + ports: + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/ports + +patternProperties: + "^port(@[0-9a-f]+)?$": + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/port + required: - compatible - reg diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml index c028b25..26ba725 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml @@ -37,6 +37,13 @@ properties: dma-names: true + ports: + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/ports + +patternProperties: + "^port(@[0-9a-f]+)?$": + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/port + if: properties: compatible: diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml index d772197..d6aa849 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml @@ -56,6 +56,13 @@ properties: ranges: true + ports: + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/ports + +patternProperties: + "^port(@[0-9a-f]+)?$": + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/port + required: - compatible - reg diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml index 2a3207b..36232ed 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml @@ -56,6 +56,13 @@ properties: The name can be "DMIC1" or "DMIC2" ... "DMICx", where x depends on the maximum available instances on a Tegra SoC. + ports: + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/ports + +patternProperties: + "^port(@[0-9a-f]+)?$": + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/port + required: - compatible - reg diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml index dfc1bf7..f5cdf33 100644 --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml @@ -74,6 +74,13 @@ properties: The name can be "I2S1" or "I2S2" ... "I2Sx", where x depends on the maximum available instances on a Tegra SoC. + ports: + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/ports + +patternProperties: + "^port(@[0-9a-f]+)?$": + $ref: /schemas/sound/audio-graph-card.yaml#/definitions/port + required: - compatible - reg
Add device tree binding properties of generic graph to ASoC component devices. This allows to define audio ports out of these components or DAIs and audio graph based sound card can be realised with this. Signed-off-by: Sameer Pujar <spujar@nvidia.com> --- Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml | 7 +++++++ .../devicetree/bindings/sound/nvidia,tegra210-admaif.yaml | 7 +++++++ Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml | 7 +++++++ Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml | 7 +++++++ Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml | 7 +++++++ 5 files changed, 35 insertions(+)