diff mbox series

syscalls: semop: Increase timeout for semop03

Message ID 4bec407cc82038233c8977104ccd03b97ae3fc4c.1602048976.git.viresh.kumar@linaro.org
State Accepted
Headers show
Series syscalls: semop: Increase timeout for semop03 | expand

Commit Message

Viresh Kumar Oct. 7, 2020, 5:37 a.m. UTC
Sometimes the timeout happens before the signal is received and it
causes the test to fail with following error:

 semop03.c:55: TFAIL: unexpected failure: EAGAIN/EWOULDBLOCK (11)

Fix this by increasing the timeout to a sufficiently large value.

Reported-by: Rachel Sibley <rasibley@redhat.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 testcases/kernel/syscalls/ipc/semop/semop03.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Stancek Oct. 7, 2020, 11:06 a.m. UTC | #1
----- Original Message -----
> Sometimes the timeout happens before the signal is received and it
> causes the test to fail with following error:
> 
>  semop03.c:55: TFAIL: unexpected failure: EAGAIN/EWOULDBLOCK (11)
> 
> Fix this by increasing the timeout to a sufficiently large value.
> 
> Reported-by: Rachel Sibley <rasibley@redhat.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  testcases/kernel/syscalls/ipc/semop/semop03.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/syscalls/ipc/semop/semop03.c
> b/testcases/kernel/syscalls/ipc/semop/semop03.c
> index 89603f19d651..3a79ed38a904 100644
> --- a/testcases/kernel/syscalls/ipc/semop/semop03.c
> +++ b/testcases/kernel/syscalls/ipc/semop/semop03.c
> @@ -71,7 +71,7 @@ static void setup(void)
>  	semop_supported_by_kernel(tv);
>  
>  	timeout.type = tv->ts_type;
> -	tst_ts_set_sec(&timeout, 0);
> +	tst_ts_set_sec(&timeout, 2);
>  	tst_ts_set_nsec(&timeout, 10000000);
>  
>  	SAFE_SIGNAL(SIGHUP, sighandler);
> --
> 2.25.0.rc1.19.g042ed3e048af

Acked-by: Jan Stancek <jstancek@redhat.com>

pointer to arm thread:
  https://lore.kernel.org/linux-arm-kernel/20201007053345.4xbyjx4u4ccwkep5@vireshk-i7/T/#t

I see it sporadically on ppc kvm guests too.
Li Wang Oct. 9, 2020, 8:57 a.m. UTC | #2
On Wed, Oct 7, 2020 at 7:06 PM Jan Stancek <jstancek@redhat.com> wrote:

>
>
> ----- Original Message -----
> > Sometimes the timeout happens before the signal is received and it
> > causes the test to fail with following error:
> >
> >  semop03.c:55: TFAIL: unexpected failure: EAGAIN/EWOULDBLOCK (11)
> >
> > Fix this by increasing the timeout to a sufficiently large value.
> >
> > Reported-by: Rachel Sibley <rasibley@redhat.com>
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> >  testcases/kernel/syscalls/ipc/semop/semop03.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/testcases/kernel/syscalls/ipc/semop/semop03.c
> > b/testcases/kernel/syscalls/ipc/semop/semop03.c
> > index 89603f19d651..3a79ed38a904 100644
> > --- a/testcases/kernel/syscalls/ipc/semop/semop03.c
> > +++ b/testcases/kernel/syscalls/ipc/semop/semop03.c
> > @@ -71,7 +71,7 @@ static void setup(void)
> >       semop_supported_by_kernel(tv);
> >
> >       timeout.type = tv->ts_type;
> > -     tst_ts_set_sec(&timeout, 0);
> > +     tst_ts_set_sec(&timeout, 2);
> >       tst_ts_set_nsec(&timeout, 10000000);
> >
> >       SAFE_SIGNAL(SIGHUP, sighandler);
> > --
> > 2.25.0.rc1.19.g042ed3e048af
>
> Acked-by: Jan Stancek <jstancek@redhat.com>
>

Patch applied.
diff mbox series

Patch

diff --git a/testcases/kernel/syscalls/ipc/semop/semop03.c b/testcases/kernel/syscalls/ipc/semop/semop03.c
index 89603f19d651..3a79ed38a904 100644
--- a/testcases/kernel/syscalls/ipc/semop/semop03.c
+++ b/testcases/kernel/syscalls/ipc/semop/semop03.c
@@ -71,7 +71,7 @@  static void setup(void)
 	semop_supported_by_kernel(tv);
 
 	timeout.type = tv->ts_type;
-	tst_ts_set_sec(&timeout, 0);
+	tst_ts_set_sec(&timeout, 2);
 	tst_ts_set_nsec(&timeout, 10000000);
 
 	SAFE_SIGNAL(SIGHUP, sighandler);