| Message ID | e994b27b4732a21a571cf09bd5071f583d85dd89.1601960644.git.thehajime@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [RFC,v7,01/21] um: split build in kernel and host parts | expand |
On Tue, 2020-10-06 at 18:44 +0900, Hajime Tazaki wrote: > This commit fixes numbers of warning messages about leaked CONFIG > options. No it doesn't ... it suppresses them, not a fan at all. > nommu mode of UML requires copies of kernel headers to offer > syscall-like API for the library users. Thus, the warnings are to be > avoided to function this exposure of API. I don't see that here, so maybe make that part of the patch where it actually happens, with a big comment, and maybe only when actually building for NOMMU/LKL? johannes
On Thu, 08 Oct 2020 00:24:17 +0900, Johannes Berg wrote: > > On Tue, 2020-10-06 at 18:44 +0900, Hajime Tazaki wrote: > > This commit fixes numbers of warning messages about leaked CONFIG > > options. > > No it doesn't ... it suppresses them, not a fan at all. Agree to rewrite the description. > > nommu mode of UML requires copies of kernel headers to offer > > syscall-like API for the library users. Thus, the warnings are to be > > avoided to function this exposure of API. > > I don't see that here, so maybe make that part of the patch where it > actually happens, with a big comment, Although I didn't, this patch should Cc the maintainer of ./scripts/headers_install.sh. I thought this should be as a separate one, but I can Cc (in the commit message) to the commit that actual build happens if that helps to understand. > and maybe only when actually building for NOMMU/LKL? The standalone UML doesn't use the headers_install.sh script (AFAIK), so I think this would be okay. -- Hajime
On Fri, 2020-10-09 at 10:13 +0900, Hajime Tazaki wrote: > > > and maybe only when actually building for NOMMU/LKL? > > The standalone UML doesn't use the headers_install.sh script (AFAIK), > so I think this would be okay. Yes, I was more thinking in terms of documenting the purpose in the code, similar really to the argument I made elsewhere about "NOMMU" vs "LKL mode". johannes
diff --git a/scripts/headers_install.sh b/scripts/headers_install.sh index dd554bd436cc..8890a0147012 100755 --- a/scripts/headers_install.sh +++ b/scripts/headers_install.sh @@ -93,6 +93,10 @@ include/uapi/linux/pktcdvd.h:CONFIG_CDROM_PKTCDVD_WCACHE for c in $configs do + if [ "$SRCARCH" = "um" ] ; then + break + fi + leak_error=1 for ignore in $config_leak_ignores
This commit fixes numbers of warning messages about leaked CONFIG options. nommu mode of UML requires copies of kernel headers to offer syscall-like API for the library users. Thus, the warnings are to be avoided to function this exposure of API. Signed-off-by: Hajime Tazaki <thehajime@gmail.com> --- scripts/headers_install.sh | 4 ++++ 1 file changed, 4 insertions(+)