diff mbox series

[1/1] package/sentry-cli: pass HOST_LDFLAGS

Message ID 20201004184157.1488521-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [1/1] package/sentry-cli: pass HOST_LDFLAGS | expand

Commit Message

Fabrice Fontaine Oct. 4, 2020, 6:41 p.m. UTC
Pass HOST_LDFLAGS to avoid the following build failure due to missing
RPATH:

*** ERROR: package host-sentry-cli installs executables without proper RPATH:
***   /srv/storage/autobuild/run/instance-3/output-1/host/bin/sentry-cli

Fixes:
 - http://autobuild.buildroot.org/results/d52638baefec961ff693aecf833af7adfc482fe4

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/sentry-cli/sentry-cli.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Yann E. MORIN Oct. 4, 2020, 9:19 p.m. UTC | #1
Fabrice, All,

On 2020-10-04 20:41 +0200, Fabrice Fontaine spake thusly:
> Pass HOST_LDFLAGS to avoid the following build failure due to missing
> RPATH:
> 
> *** ERROR: package host-sentry-cli installs executables without proper RPATH:
> ***   /srv/storage/autobuild/run/instance-3/output-1/host/bin/sentry-cli
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/d52638baefec961ff693aecf833af7adfc482fe4
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/sentry-cli/sentry-cli.mk | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/sentry-cli/sentry-cli.mk b/package/sentry-cli/sentry-cli.mk
> index c4dbc5ebfd..7e53f16026 100644
> --- a/package/sentry-cli/sentry-cli.mk
> +++ b/package/sentry-cli/sentry-cli.mk
> @@ -11,7 +11,9 @@ SENTRY_CLI_LICENSE_FILES = LICENSE
>  
>  HOST_SENTRY_CLI_DEPENDENCIES = host-rustc host-zlib
>  
> -HOST_SENTRY_CLI_CARGO_ENV = CARGO_HOME=$(HOST_DIR)/share/cargo
> +HOST_SENTRY_CLI_CARGO_ENV = \
> +	CARGO_HOME=$(HOST_DIR)/share/cargo \
> +	RUSTFLAGS="$(addprefix -C link-args=,$(HOST_LDFLAGS))"
>  
>  HOST_SENTRY_CLI_CARGO_OPTS = \
>  	--release \
> -- 
> 2.28.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/package/sentry-cli/sentry-cli.mk b/package/sentry-cli/sentry-cli.mk
index c4dbc5ebfd..7e53f16026 100644
--- a/package/sentry-cli/sentry-cli.mk
+++ b/package/sentry-cli/sentry-cli.mk
@@ -11,7 +11,9 @@  SENTRY_CLI_LICENSE_FILES = LICENSE
 
 HOST_SENTRY_CLI_DEPENDENCIES = host-rustc host-zlib
 
-HOST_SENTRY_CLI_CARGO_ENV = CARGO_HOME=$(HOST_DIR)/share/cargo
+HOST_SENTRY_CLI_CARGO_ENV = \
+	CARGO_HOME=$(HOST_DIR)/share/cargo \
+	RUSTFLAGS="$(addprefix -C link-args=,$(HOST_LDFLAGS))"
 
 HOST_SENTRY_CLI_CARGO_OPTS = \
 	--release \