diff mbox series

[5/5] network/ipneigh01: use ROD when deleting the entries

Message ID 20200924071740.6963-5-alexey.kodanev@oracle.com
State Accepted
Headers show
Series [1/5] network/ipsec: fix warning when using wrong option for ipv4 | expand

Commit Message

Alexey Kodanev Sept. 24, 2020, 7:17 a.m. UTC
Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
---
 testcases/network/tcp_cmds/ipneigh/ipneigh01.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Petr Vorel Sept. 30, 2020, 8:07 a.m. UTC | #1
Hi Alexey,

sorry for late review.

For whole patchset.
Reviewed-by: Petr Vorel <pvorel@suse.cz>

I'm going to merge it so it gets into the release (should be done today).

Kind regards,
Petr
Alexey Kodanev Sept. 30, 2020, 9:45 a.m. UTC | #2
On 30.09.2020 11:07, Petr Vorel wrote:
> Hi Alexey,
> 
> sorry for late review.
> 
> For whole patchset.
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> 
> I'm going to merge it so it gets into the release (should be done today).

Thank you Petr!

> 
> Kind regards,
> Petr
>
diff mbox series

Patch

diff --git a/testcases/network/tcp_cmds/ipneigh/ipneigh01.sh b/testcases/network/tcp_cmds/ipneigh/ipneigh01.sh
index e15dd708c..6ad987c49 100755
--- a/testcases/network/tcp_cmds/ipneigh/ipneigh01.sh
+++ b/testcases/network/tcp_cmds/ipneigh/ipneigh01.sh
@@ -20,14 +20,14 @@  do_setup()
 	case $CMD in
 	ip)
 		SHOW_CMD="ip neigh show"
-		DEL_CMD="ip neigh del $(tst_ipaddr rhost) dev $(tst_iface)"
+		DEL_CMD="ROD ip neigh del $(tst_ipaddr rhost) dev $(tst_iface)"
 		;;
 	arp)
 		if [ -n "$TST_IPV6" ]; then
 			tst_brk TCONF "'arp' doesn't support IPv6"
 		fi
 		SHOW_CMD="arp -a"
-		DEL_CMD="arp -d $(tst_ipaddr rhost) -i $(tst_iface)"
+		DEL_CMD="ROD arp -d $(tst_ipaddr rhost) -i $(tst_iface)"
 		;;
 	*)
 		tst_brk TBROK "unknown or missing command, use -c [ arp | ip ]"
@@ -75,7 +75,7 @@  do_test()
 		[ "$ret" -ne 0 ] && \
 			tst_brk TFAIL "$entry_name entry '$(tst_ipaddr rhost)' not listed"
 
-		$DEL_CMD || tst_brk TFAIL "fail to delete entry"
+		$DEL_CMD
 
 		$SHOW_CMD | grep -q "$(tst_ipaddr rhost).*$(tst_hwaddr rhost)" && \
 			tst_brk TFAIL "'$DEL_CMD' failed, entry has " \