| Message ID | 71a9108f3472ba9af4bead01b1b770d1e73eb08e.1600707235.git.agx@sigxcpu.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | drm/panel: mantix panel reset fixes | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
Hi Guido, On Mon, Sep 21, 2020 at 1:56 PM Guido Günther <agx@sigxcpu.org> wrote: > > We need to reset both for the panel to show an image. There is a typo in "resets" in the Subject line.
Hi, On Mon, Sep 21, 2020 at 02:05:55PM -0300, Fabio Estevam wrote: > Hi Guido, > > On Mon, Sep 21, 2020 at 1:56 PM Guido Günther <agx@sigxcpu.org> wrote: > > > > We need to reset both for the panel to show an image. > > There is a typo in "resets" in the Subject line. Fix queued for v2. Thanks! -- Guido
Hi Guido. On Mon, Sep 21, 2020 at 06:55:52PM +0200, Guido Günther wrote: > We need to reset both for the panel to show an image. > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > --- > .../bindings/display/panel/mantix,mlaf057we51-x.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml > index 937323cc9aaa..ba5a18fac9f9 100644 > --- a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml > +++ b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml > @@ -35,7 +35,9 @@ properties: > vddi-supply: > description: 1.8V I/O voltage supply > > - reset-gpios: true > + reset-gpios: > + minItems: 2 > + maxItems: 2 reset-gpios is, as you already wrote, defined in panel-common.yaml. Do not try to change it here. It would be much better, I think, to introduce a mantix,reset-gpios property. This would avoid that we had two different reset-gpios definitions. Sam > > backlight: true > > @@ -62,7 +64,8 @@ examples: > avdd-supply = <®_avdd>; > avee-supply = <®_avee>; > vddi-supply = <®_1v8_p>; > - reset-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>; > + reset-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>, > + <&gpio1 24 GPIO_ACTIVE_LOW>; > backlight = <&backlight>; > }; > }; > -- > 2.26.2
On Thu, Sep 24, 2020 at 09:38:07PM +0200, Sam Ravnborg wrote: > Hi Guido. > > On Mon, Sep 21, 2020 at 06:55:52PM +0200, Guido Günther wrote: > > We need to reset both for the panel to show an image. > > > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > > --- > > .../bindings/display/panel/mantix,mlaf057we51-x.yaml | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml > > index 937323cc9aaa..ba5a18fac9f9 100644 > > --- a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml > > @@ -35,7 +35,9 @@ properties: > > vddi-supply: > > description: 1.8V I/O voltage supply > > > > - reset-gpios: true > > + reset-gpios: > > + minItems: 2 > > + maxItems: 2 > > reset-gpios is, as you already wrote, defined in panel-common.yaml. > Do not try to change it here. > It would be much better, I think, to introduce a mantix,reset-gpios > property. > > This would avoid that we had two different reset-gpios definitions. My understanding is that this will only override the defaults defined in panel-common.yaml. So everything else about the panel-common.yaml#/properties/reset-gpios definition remains valid and all this does is say that when this matched on "mantix,mlaf057we51-x", then the "reset-gpios" property is expected to contain two entries as opposed to the single entry that is expected by default. Thierry
Hi Thierry, On Mon, Sep 28, 2020 at 08:50:39AM +0200, Thierry Reding wrote: > On Thu, Sep 24, 2020 at 09:38:07PM +0200, Sam Ravnborg wrote: > > Hi Guido. > > > > On Mon, Sep 21, 2020 at 06:55:52PM +0200, Guido Günther wrote: > > > We need to reset both for the panel to show an image. > > > > > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > > > --- > > > .../bindings/display/panel/mantix,mlaf057we51-x.yaml | 7 +++++-- > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml > > > index 937323cc9aaa..ba5a18fac9f9 100644 > > > --- a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml > > > +++ b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml > > > @@ -35,7 +35,9 @@ properties: > > > vddi-supply: > > > description: 1.8V I/O voltage supply > > > > > > - reset-gpios: true > > > + reset-gpios: > > > + minItems: 2 > > > + maxItems: 2 > > > > reset-gpios is, as you already wrote, defined in panel-common.yaml. > > Do not try to change it here. > > It would be much better, I think, to introduce a mantix,reset-gpios > > property. > > > > This would avoid that we had two different reset-gpios definitions. > > My understanding is that this will only override the defaults defined in > panel-common.yaml. So everything else about the > panel-common.yaml#/properties/reset-gpios definition remains valid and > all this does is say that when this matched on "mantix,mlaf057we51-x", > then the "reset-gpios" property is expected to contain two entries as > opposed to the single entry that is expected by default. I thought so too but I get: linux/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.example.dt.yaml: panel@0: reset-gpios: [[4294967295, 29, 1], [4294967295, 24, 1]] is too long From schema: /.../linux/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml It seems to bepossible to *extend* reset-gpios though because when i use an example like: reset-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>, <&gpio1 24 GPIO_ACTIVE_LOW>; i correctly get linux/linux/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.example.dt.yaml: panel@0: reset-gpios: [[4294967295, 29, 1]] is too short From schema: /.../linux/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml so the `minItems: 2` is being picked up. This mens i can add properties but i can't overwrite the existing `maxItems: 2` - that's why i was wondering how that is supposed to work (if properties should be overrideable from common files or not). Cheers, -- Guido > > Thierry
On Thu, Sep 24, 2020 at 09:38:07PM +0200, Sam Ravnborg wrote: > Hi Guido. > > On Mon, Sep 21, 2020 at 06:55:52PM +0200, Guido Günther wrote: > > We need to reset both for the panel to show an image. > > > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > > --- > > .../bindings/display/panel/mantix,mlaf057we51-x.yaml | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml > > index 937323cc9aaa..ba5a18fac9f9 100644 > > --- a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml > > @@ -35,7 +35,9 @@ properties: > > vddi-supply: > > description: 1.8V I/O voltage supply > > > > - reset-gpios: true > > + reset-gpios: > > + minItems: 2 > > + maxItems: 2 > > reset-gpios is, as you already wrote, defined in panel-common.yaml. > Do not try to change it here. > It would be much better, I think, to introduce a mantix,reset-gpios > property. Yes. You also need to define what each reset entry corresponds to as the assertion/deassertion order could be important. You might just do 2 properties with <pinname>-gpios. Rob
diff --git a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml index 937323cc9aaa..ba5a18fac9f9 100644 --- a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml +++ b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml @@ -35,7 +35,9 @@ properties: vddi-supply: description: 1.8V I/O voltage supply - reset-gpios: true + reset-gpios: + minItems: 2 + maxItems: 2 backlight: true @@ -62,7 +64,8 @@ examples: avdd-supply = <®_avdd>; avee-supply = <®_avee>; vddi-supply = <®_1v8_p>; - reset-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>; + reset-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>, + <&gpio1 24 GPIO_ACTIVE_LOW>; backlight = <&backlight>; }; };
We need to reset both for the panel to show an image. Signed-off-by: Guido Günther <agx@sigxcpu.org> --- .../bindings/display/panel/mantix,mlaf057we51-x.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)