| Message ID | 20200925170323.GA20546@embeddedor |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [next] dpaa2-mac: Fix potential null pointer dereference | expand |
From: "Gustavo A. R. Silva" <gustavoars@kernel.org> Date: Fri, 25 Sep 2020 12:03:23 -0500 > There is a null-check for _pcs_, but it is being dereferenced > prior to this null-check. So, if _pcs_ can actually be null, > then there is a potential null pointer dereference that should > be fixed by null-checking _pcs_ before being dereferenced. > > Addresses-Coverity-ID: 1497159 ("Dereference before null check") > Fixes: 94ae899b2096 ("dpaa2-mac: add PCS support through the Lynx module") > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Applied, thanks.
On Fri, Sep 25, 2020 at 05:15:54PM -0700, David Miller wrote: > From: "Gustavo A. R. Silva" <gustavoars@kernel.org> > Date: Fri, 25 Sep 2020 12:03:23 -0500 > > > There is a null-check for _pcs_, but it is being dereferenced > > prior to this null-check. So, if _pcs_ can actually be null, > > then there is a potential null pointer dereference that should > > be fixed by null-checking _pcs_ before being dereferenced. > > > > Addresses-Coverity-ID: 1497159 ("Dereference before null check") > > Fixes: 94ae899b2096 ("dpaa2-mac: add PCS support through the Lynx module") > > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > > Applied, thanks. Thanks, Dave. -- Gustavo
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c index 6ff64dd1cf27..283c5b1dbaad 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c @@ -291,9 +291,9 @@ static int dpaa2_pcs_create(struct dpaa2_mac *mac, static void dpaa2_pcs_destroy(struct dpaa2_mac *mac) { struct lynx_pcs *pcs = mac->pcs; - struct device *dev = &pcs->mdio->dev; if (pcs) { + struct device *dev = &pcs->mdio->dev; lynx_pcs_destroy(pcs); put_device(dev); mac->pcs = NULL;
There is a null-check for _pcs_, but it is being dereferenced prior to this null-check. So, if _pcs_ can actually be null, then there is a potential null pointer dereference that should be fixed by null-checking _pcs_ before being dereferenced. Addresses-Coverity-ID: 1497159 ("Dereference before null check") Fixes: 94ae899b2096 ("dpaa2-mac: add PCS support through the Lynx module") Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)