| Message ID | 20200921121628.3954746-1-thierry.reding@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [GIT,PULL] clk: tegra: Changes for v5.10-rc1 | expand |
On Mon, Sep 21, 2020 at 02:16:28PM +0200, Thierry Reding wrote: > Hi Mike, Stephen, > > The following changes since commit 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5: > > Linux 5.9-rc1 (2020-08-16 13:04:57 -0700) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git tags/for-5.10-clk > > for you to fetch changes up to 2f878d04218c8b26f6d0ab26955ca6b03848a1ad: > > clk: tegra: Fix missing prototype for tegra210_clk_register_emc() (2020-09-21 14:09:10 +0200) > > Thanks, > Thierry > > ---------------------------------------------------------------- > clk: tegra: Changes for v5.10-rc1 > > This is a set of small fixes for the Tegra clock driver. > > ---------------------------------------------------------------- > Thierry Reding (3): > clk: tegra: Capitalization fixes > clk: tegra: Always program PLL_E when enabled > clk: tegra: Fix missing prototype for tegra210_clk_register_emc() > > drivers/clk/tegra/clk-pll.c | 7 ++----- > drivers/clk/tegra/clk-tegra210-emc.c | 2 ++ > 2 files changed, 4 insertions(+), 5 deletions(-) I just realized after sending this out that this is all really tiny and minor fixes, so perhaps it makes sense to even apply this for v5.9? Thierry
Quoting Thierry Reding (2020-09-21 05:18:42) > On Mon, Sep 21, 2020 at 02:16:28PM +0200, Thierry Reding wrote: > > Hi Mike, Stephen, > > > > The following changes since commit 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5: > > > > Linux 5.9-rc1 (2020-08-16 13:04:57 -0700) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git tags/for-5.10-clk > > > > for you to fetch changes up to 2f878d04218c8b26f6d0ab26955ca6b03848a1ad: > > > > clk: tegra: Fix missing prototype for tegra210_clk_register_emc() (2020-09-21 14:09:10 +0200) > > > > Thanks, > > Thierry > > > > ---------------------------------------------------------------- > > clk: tegra: Changes for v5.10-rc1 > > > > This is a set of small fixes for the Tegra clock driver. > > > > ---------------------------------------------------------------- > > Thierry Reding (3): > > clk: tegra: Capitalization fixes > > clk: tegra: Always program PLL_E when enabled > > clk: tegra: Fix missing prototype for tegra210_clk_register_emc() > > > > drivers/clk/tegra/clk-pll.c | 7 ++----- > > drivers/clk/tegra/clk-tegra210-emc.c | 2 ++ > > 2 files changed, 4 insertions(+), 5 deletions(-) > > I just realized after sending this out that this is all really tiny and > minor fixes, so perhaps it makes sense to even apply this for v5.9? > Is something critical? If so then it's OK to merge for v5.9, otherwise I'd rather let it cook in -next for a while. Being small doesn't really make a difference here. What matters is that it fixes some critical problem, preferably introduced this merge window but if it's annoying enough that rule can be broken.
On Mon, Sep 21, 2020 at 02:00:58PM -0700, Stephen Boyd wrote: > Quoting Thierry Reding (2020-09-21 05:18:42) > > On Mon, Sep 21, 2020 at 02:16:28PM +0200, Thierry Reding wrote: > > > Hi Mike, Stephen, > > > > > > The following changes since commit 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5: > > > > > > Linux 5.9-rc1 (2020-08-16 13:04:57 -0700) > > > > > > are available in the Git repository at: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git tags/for-5.10-clk > > > > > > for you to fetch changes up to 2f878d04218c8b26f6d0ab26955ca6b03848a1ad: > > > > > > clk: tegra: Fix missing prototype for tegra210_clk_register_emc() (2020-09-21 14:09:10 +0200) > > > > > > Thanks, > > > Thierry > > > > > > ---------------------------------------------------------------- > > > clk: tegra: Changes for v5.10-rc1 > > > > > > This is a set of small fixes for the Tegra clock driver. > > > > > > ---------------------------------------------------------------- > > > Thierry Reding (3): > > > clk: tegra: Capitalization fixes > > > clk: tegra: Always program PLL_E when enabled > > > clk: tegra: Fix missing prototype for tegra210_clk_register_emc() > > > > > > drivers/clk/tegra/clk-pll.c | 7 ++----- > > > drivers/clk/tegra/clk-tegra210-emc.c | 2 ++ > > > 2 files changed, 4 insertions(+), 5 deletions(-) > > > > I just realized after sending this out that this is all really tiny and > > minor fixes, so perhaps it makes sense to even apply this for v5.9? > > > > Is something critical? If so then it's OK to merge for v5.9, otherwise > I'd rather let it cook in -next for a while. Being small doesn't really > make a difference here. What matters is that it fixes some critical > problem, preferably introduced this merge window but if it's annoying > enough that rule can be broken. This is actually a subset of a set of patches that I had sitting on a for-5.9/clk branch but for which I forgot to send a pull request. This was pointed out to me on IRC yesterday. So this should already be soft- boiled. The first patch is just a tiny bit of cleanup, but the second patch fixes a real problem with SATA that can happen depending on how the bootloader has set up the PLL_E. The third patch fixes a build warning, which admittedly isn't critical, but certainly nice to have. Given that the latter two are the only known issues with the clock driver I think it would be nice to have them in v5.9, especially since that's going to be an LTS and we'll end up back-porting at least two of these patches to it anyway. Thierry
Quoting Thierry Reding (2020-09-22 00:39:39) > On Mon, Sep 21, 2020 at 02:00:58PM -0700, Stephen Boyd wrote: > > Quoting Thierry Reding (2020-09-21 05:18:42) > > > On Mon, Sep 21, 2020 at 02:16:28PM +0200, Thierry Reding wrote: > > > > Hi Mike, Stephen, > > > > > > > > The following changes since commit 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5: > > > > > > > > Linux 5.9-rc1 (2020-08-16 13:04:57 -0700) > > > > > > > > are available in the Git repository at: > > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git tags/for-5.10-clk > > > > > > > > for you to fetch changes up to 2f878d04218c8b26f6d0ab26955ca6b03848a1ad: > > > > > > > > clk: tegra: Fix missing prototype for tegra210_clk_register_emc() (2020-09-21 14:09:10 +0200) > > > > > > > > Thanks, > > > > Thierry > > > > > > > > ---------------------------------------------------------------- > > > > clk: tegra: Changes for v5.10-rc1 > > > > > > > > This is a set of small fixes for the Tegra clock driver. > > > > > > > > ---------------------------------------------------------------- > > > > Thierry Reding (3): > > > > clk: tegra: Capitalization fixes > > > > clk: tegra: Always program PLL_E when enabled > > > > clk: tegra: Fix missing prototype for tegra210_clk_register_emc() > > > > > > > > drivers/clk/tegra/clk-pll.c | 7 ++----- > > > > drivers/clk/tegra/clk-tegra210-emc.c | 2 ++ > > > > 2 files changed, 4 insertions(+), 5 deletions(-) > > > > > > I just realized after sending this out that this is all really tiny and > > > minor fixes, so perhaps it makes sense to even apply this for v5.9? > > > > > > > Is something critical? If so then it's OK to merge for v5.9, otherwise > > I'd rather let it cook in -next for a while. Being small doesn't really > > make a difference here. What matters is that it fixes some critical > > problem, preferably introduced this merge window but if it's annoying > > enough that rule can be broken. > > This is actually a subset of a set of patches that I had sitting on a > for-5.9/clk branch but for which I forgot to send a pull request. This > was pointed out to me on IRC yesterday. So this should already be soft- > boiled. > > The first patch is just a tiny bit of cleanup, but the second patch > fixes a real problem with SATA that can happen depending on how the > bootloader has set up the PLL_E. The third patch fixes a build > warning, which admittedly isn't critical, but certainly nice to have. > Given that the latter two are the only known issues with the clock > driver I think it would be nice to have them in v5.9, especially since > that's going to be an LTS and we'll end up back-porting at least two of > these patches to it anyway. > Ok. Is the bootloader problem happening right now?
On Tue, Sep 22, 2020 at 12:08:45PM -0700, Stephen Boyd wrote: > Quoting Thierry Reding (2020-09-22 00:39:39) > > On Mon, Sep 21, 2020 at 02:00:58PM -0700, Stephen Boyd wrote: > > > Quoting Thierry Reding (2020-09-21 05:18:42) > > > > On Mon, Sep 21, 2020 at 02:16:28PM +0200, Thierry Reding wrote: > > > > > Hi Mike, Stephen, > > > > > > > > > > The following changes since commit 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5: > > > > > > > > > > Linux 5.9-rc1 (2020-08-16 13:04:57 -0700) > > > > > > > > > > are available in the Git repository at: > > > > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git tags/for-5.10-clk > > > > > > > > > > for you to fetch changes up to 2f878d04218c8b26f6d0ab26955ca6b03848a1ad: > > > > > > > > > > clk: tegra: Fix missing prototype for tegra210_clk_register_emc() (2020-09-21 14:09:10 +0200) > > > > > > > > > > Thanks, > > > > > Thierry > > > > > > > > > > ---------------------------------------------------------------- > > > > > clk: tegra: Changes for v5.10-rc1 > > > > > > > > > > This is a set of small fixes for the Tegra clock driver. > > > > > > > > > > ---------------------------------------------------------------- > > > > > Thierry Reding (3): > > > > > clk: tegra: Capitalization fixes > > > > > clk: tegra: Always program PLL_E when enabled > > > > > clk: tegra: Fix missing prototype for tegra210_clk_register_emc() > > > > > > > > > > drivers/clk/tegra/clk-pll.c | 7 ++----- > > > > > drivers/clk/tegra/clk-tegra210-emc.c | 2 ++ > > > > > 2 files changed, 4 insertions(+), 5 deletions(-) > > > > > > > > I just realized after sending this out that this is all really tiny and > > > > minor fixes, so perhaps it makes sense to even apply this for v5.9? > > > > > > > > > > Is something critical? If so then it's OK to merge for v5.9, otherwise > > > I'd rather let it cook in -next for a while. Being small doesn't really > > > make a difference here. What matters is that it fixes some critical > > > problem, preferably introduced this merge window but if it's annoying > > > enough that rule can be broken. > > > > This is actually a subset of a set of patches that I had sitting on a > > for-5.9/clk branch but for which I forgot to send a pull request. This > > was pointed out to me on IRC yesterday. So this should already be soft- > > boiled. > > > > The first patch is just a tiny bit of cleanup, but the second patch > > fixes a real problem with SATA that can happen depending on how the > > bootloader has set up the PLL_E. The third patch fixes a build > > warning, which admittedly isn't critical, but certainly nice to have. > > Given that the latter two are the only known issues with the clock > > driver I think it would be nice to have them in v5.9, especially since > > that's going to be an LTS and we'll end up back-porting at least two of > > these patches to it anyway. > > > > Ok. Is the bootloader problem happening right now? Yes, SATA (and in some cases apparently Ethernet as well) is currently broken on at least one platform (Jetson TK1). See this bug report for details: https://lkml.org/lkml/2020/3/19/82 Thierry
Hi Mike, Stephen, The following changes since commit 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5: Linux 5.9-rc1 (2020-08-16 13:04:57 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git tags/for-5.10-clk for you to fetch changes up to 2f878d04218c8b26f6d0ab26955ca6b03848a1ad: clk: tegra: Fix missing prototype for tegra210_clk_register_emc() (2020-09-21 14:09:10 +0200) Thanks, Thierry ---------------------------------------------------------------- clk: tegra: Changes for v5.10-rc1 This is a set of small fixes for the Tegra clock driver. ---------------------------------------------------------------- Thierry Reding (3): clk: tegra: Capitalization fixes clk: tegra: Always program PLL_E when enabled clk: tegra: Fix missing prototype for tegra210_clk_register_emc() drivers/clk/tegra/clk-pll.c | 7 ++----- drivers/clk/tegra/clk-tegra210-emc.c | 2 ++ 2 files changed, 4 insertions(+), 5 deletions(-)