| Message ID | 20191025185448.32633-6-asafka7@gmail.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [v2,1/1] package/python-reentry: add host variant | expand |
Am Fri, 25 Oct 2019 21:54:48 +0300 schrieb Asaf Kahlon: > Packages which use reentry will have setup_requires=['reentry'] and > reentry_register=True in their setup.py. > A host variant is needed in order to invoke reentry when building the > package and register the entrypoints. Hi, as you pointed out in http://patchwork.ozlabs.org/project/buildroot/patch/ 20191020190142.18672-2-asafka7@gmail.com/ "I don't see any Buildroot package which uses reentry..." I think that your patch should not be applied to buildroot atm. Regards, Bernd
Asaf, All, On 2020-09-23 07:08 +0200, Bernd Kuhls spake thusly: > Am Fri, 25 Oct 2019 21:54:48 +0300 schrieb Asaf Kahlon: > > Packages which use reentry will have setup_requires=['reentry'] and > > reentry_register=True in their setup.py. > > A host variant is needed in order to invoke reentry when building the > > package and register the entrypoints. > as you pointed out in http://patchwork.ozlabs.org/project/buildroot/patch/ > 20191020190142.18672-2-asafka7@gmail.com/ > > "I don't see any Buildroot package which uses reentry..." > > I think that your patch should not be applied to buildroot atm. I concur, so I have now marked that patch as rejected in patchwork. If in the future we introduce a package that needs it, then will be the time to eventually add the host variant for reentry. Thanks! Regards, Yann E. MORIN.
diff --git a/package/python-click/python-click.mk b/package/python-click/python-click.mk index 12539f557b..1c8c28449a 100644 --- a/package/python-click/python-click.mk +++ b/package/python-click/python-click.mk @@ -12,3 +12,4 @@ PYTHON_CLICK_LICENSE_FILES = LICENSE.rst PYTHON_CLICK_SETUP_TYPE = setuptools $(eval $(python-package)) +$(eval $(host-python-package)) diff --git a/package/python-pathlib2/python-pathlib2.mk b/package/python-pathlib2/python-pathlib2.mk index d813b77d7e..5fa885235b 100644 --- a/package/python-pathlib2/python-pathlib2.mk +++ b/package/python-pathlib2/python-pathlib2.mk @@ -12,3 +12,4 @@ PYTHON_PATHLIB2_LICENSE_FILES = LICENSE.rst PYTHON_PATHLIB2_SETUP_TYPE = setuptools $(eval $(python-package)) +$(eval $(host-python-package)) diff --git a/package/python-reentry/python-reentry.mk b/package/python-reentry/python-reentry.mk index 428dbf2b1b..b4bd33d846 100644 --- a/package/python-reentry/python-reentry.mk +++ b/package/python-reentry/python-reentry.mk @@ -10,5 +10,10 @@ PYTHON_REENTRY_SITE = https://files.pythonhosted.org/packages/ee/3f/a90789e01c4d PYTHON_REENTRY_SETUP_TYPE = setuptools PYTHON_REENTRY_LICENSE = MIT PYTHON_REENTRY_LICENSE_FILES = LICENSE +HOST_PYTHON_REENTRY_DEPENDENCIES = \ + host-python-six + host-python-click + $(if $(BR2_PACKAGE_PYTHON),host-python-pathlib2,) $(eval $(python-package)) +$(eval $(host-python-package))
Packages which use reentry will have setup_requires=['reentry'] and reentry_register=True in their setup.py. A host variant is needed in order to invoke reentry when building the package and register the entrypoints. Signed-off-by: Asaf Kahlon <asafka7@gmail.com> --- package/python-click/python-click.mk | 1 + package/python-pathlib2/python-pathlib2.mk | 1 + package/python-reentry/python-reentry.mk | 5 +++++ 3 files changed, 7 insertions(+)