| Message ID | 20200716145319.53773-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v1] i2c: nvidia-gpu: Use put_unaligned_be24() | expand |
On Thu, Jul 16, 2020 at 05:53:19PM +0300, Andy Shevchenko wrote: > This makes the driver code slightly easier to read. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- Ajay, any comments? > drivers/i2c/busses/i2c-nvidia-gpu.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c > index f480105000b8..f9a69b109e5c 100644 > --- a/drivers/i2c/busses/i2c-nvidia-gpu.c > +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c > @@ -125,8 +125,7 @@ static int gpu_i2c_read(struct gpu_i2c_dev *i2cd, u8 *data, u16 len) > put_unaligned_be16(val, data); > break; > case 3: > - put_unaligned_be16(val >> 8, data); > - data[2] = val; > + put_unaligned_be24(val, data); > break; > case 4: > put_unaligned_be32(val, data); > -- > 2.27.0 >
Hi Wolfram, > -----Original Message----- > From: Wolfram Sang <wsa+renesas@sang-engineering.com> > Sent: Wednesday, August 5, 2020 2:29 AM > To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Ajay Gupta <ajayg@nvidia.com>; linux-i2c@vger.kernel.org > Subject: Re: [PATCH v1] i2c: nvidia-gpu: Use put_unaligned_be24() > > On Thu, Jul 16, 2020 at 05:53:19PM +0300, Andy Shevchenko wrote: > > This makes the driver code slightly easier to read. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > Ajay, any comments? The change looks good to me. Reviewed-by: Ajay Gupta <ajayg@nvidia.com> Thanks > nvpublic > > > drivers/i2c/busses/i2c-nvidia-gpu.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c- > nvidia-gpu.c > > index f480105000b8..f9a69b109e5c 100644 > > --- a/drivers/i2c/busses/i2c-nvidia-gpu.c > > +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c > > @@ -125,8 +125,7 @@ static int gpu_i2c_read(struct gpu_i2c_dev *i2cd, u8 > *data, u16 len) > > put_unaligned_be16(val, data); > > break; > > case 3: > > - put_unaligned_be16(val >> 8, data); > > - data[2] = val; > > + put_unaligned_be24(val, data); > > break; > > case 4: > > put_unaligned_be32(val, data); > > -- > > 2.27.0 > >
On Thu, Jul 16, 2020 at 05:53:19PM +0300, Andy Shevchenko wrote: > This makes the driver code slightly easier to read. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Applied to for-next, thanks!
diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c index f480105000b8..f9a69b109e5c 100644 --- a/drivers/i2c/busses/i2c-nvidia-gpu.c +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c @@ -125,8 +125,7 @@ static int gpu_i2c_read(struct gpu_i2c_dev *i2cd, u8 *data, u16 len) put_unaligned_be16(val, data); break; case 3: - put_unaligned_be16(val >> 8, data); - data[2] = val; + put_unaligned_be24(val, data); break; case 4: put_unaligned_be32(val, data);
This makes the driver code slightly easier to read. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/i2c/busses/i2c-nvidia-gpu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)