| Message ID | 20200909130113.28228-1-juergh@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | [SRU,G/raspi,F/raspi] UBUNTU: [Config] raspi: Disable BRCM_TRACING | expand |
On 09/09/2020 14:01, Juerg Haefliger wrote: > BugLink: https://bugs.launchpad.net/bugs/1893905 > > BRCM_TRACING is a debugging option with the side effect that some regular > information is being printed as errors. Using pr_err for things which are > not errors is a bad idea and might confuse users. It will also drop the > plymouth bootsplash screen back to the text console so that users can see > the (bogus) error. So disable the option. > > Signed-off-by: Juerg Haefliger <juergh@canonical.com> > --- > debian.raspi/config/config.common.ubuntu | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/debian.raspi/config/config.common.ubuntu b/debian.raspi/config/config.common.ubuntu > index 1d28c51c8226..2a0875f4425d 100644 > --- a/debian.raspi/config/config.common.ubuntu > +++ b/debian.raspi/config/config.common.ubuntu > @@ -866,7 +866,7 @@ CONFIG_BRCMSMAC=m > CONFIG_BRCMSTB_GISB_ARB=y > CONFIG_BRCMUTIL=m > CONFIG_BRCM_CHAR_DRIVERS=y > -CONFIG_BRCM_TRACING=y > +# CONFIG_BRCM_TRACING is not set > CONFIG_BRIDGE=m > CONFIG_BRIDGE_EBT_802_3=m > CONFIG_BRIDGE_EBT_AMONG=m > Makes sense to me. Should make the kernel smaller too I hope. Acked-by: Colin Ian King <colin.king@canonical.com>
On Wed, Sep 09, 2020 at 03:01:13PM +0200, Juerg Haefliger wrote: > BugLink: https://bugs.launchpad.net/bugs/1893905 > > BRCM_TRACING is a debugging option with the side effect that some regular > information is being printed as errors. Using pr_err for things which are > not errors is a bad idea and might confuse users. It will also drop the > plymouth bootsplash screen back to the text console so that users can see > the (bogus) error. So disable the option. > > Signed-off-by: Juerg Haefliger <juergh@canonical.com> Sounds reasonable to me. Acked-by: Andrea Righi <andrea.righi@canonical.com>
On 2020-09-09 15:01:13 , Juerg Haefliger wrote: > BugLink: https://bugs.launchpad.net/bugs/1893905 > > BRCM_TRACING is a debugging option with the side effect that some regular > information is being printed as errors. Using pr_err for things which are > not errors is a bad idea and might confuse users. It will also drop the > plymouth bootsplash screen back to the text console so that users can see > the (bogus) error. So disable the option. > > Signed-off-by: Juerg Haefliger <juergh@canonical.com> > --- > debian.raspi/config/config.common.ubuntu | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/debian.raspi/config/config.common.ubuntu b/debian.raspi/config/config.common.ubuntu > index 1d28c51c8226..2a0875f4425d 100644 > --- a/debian.raspi/config/config.common.ubuntu > +++ b/debian.raspi/config/config.common.ubuntu > @@ -866,7 +866,7 @@ CONFIG_BRCMSMAC=m > CONFIG_BRCMSTB_GISB_ARB=y > CONFIG_BRCMUTIL=m > CONFIG_BRCM_CHAR_DRIVERS=y > -CONFIG_BRCM_TRACING=y > +# CONFIG_BRCM_TRACING is not set > CONFIG_BRIDGE=m > CONFIG_BRIDGE_EBT_802_3=m > CONFIG_BRIDGE_EBT_AMONG=m > -- > 2.25.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On Wed, 9 Sep 2020 15:01:13 +0200 Juerg Haefliger <juerg.haefliger@canonical.com> wrote: > BugLink: https://bugs.launchpad.net/bugs/1893905 > > BRCM_TRACING is a debugging option with the side effect that some regular > information is being printed as errors. Using pr_err for things which are > not errors is a bad idea and might confuse users. It will also drop the > plymouth bootsplash screen back to the text console so that users can see > the (bogus) error. So disable the option. > > Signed-off-by: Juerg Haefliger <juergh@canonical.com> > --- > debian.raspi/config/config.common.ubuntu | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/debian.raspi/config/config.common.ubuntu b/debian.raspi/config/config.common.ubuntu > index 1d28c51c8226..2a0875f4425d 100644 > --- a/debian.raspi/config/config.common.ubuntu > +++ b/debian.raspi/config/config.common.ubuntu > @@ -866,7 +866,7 @@ CONFIG_BRCMSMAC=m > CONFIG_BRCMSTB_GISB_ARB=y > CONFIG_BRCMUTIL=m > CONFIG_BRCM_CHAR_DRIVERS=y > -CONFIG_BRCM_TRACING=y > +# CONFIG_BRCM_TRACING is not set > CONFIG_BRIDGE=m > CONFIG_BRIDGE_EBT_802_3=m > CONFIG_BRIDGE_EBT_AMONG=m
diff --git a/debian.raspi/config/config.common.ubuntu b/debian.raspi/config/config.common.ubuntu index 1d28c51c8226..2a0875f4425d 100644 --- a/debian.raspi/config/config.common.ubuntu +++ b/debian.raspi/config/config.common.ubuntu @@ -866,7 +866,7 @@ CONFIG_BRCMSMAC=m CONFIG_BRCMSTB_GISB_ARB=y CONFIG_BRCMUTIL=m CONFIG_BRCM_CHAR_DRIVERS=y -CONFIG_BRCM_TRACING=y +# CONFIG_BRCM_TRACING is not set CONFIG_BRIDGE=m CONFIG_BRIDGE_EBT_802_3=m CONFIG_BRIDGE_EBT_AMONG=m
BugLink: https://bugs.launchpad.net/bugs/1893905 BRCM_TRACING is a debugging option with the side effect that some regular information is being printed as errors. Using pr_err for things which are not errors is a bad idea and might confuse users. It will also drop the plymouth bootsplash screen back to the text console so that users can see the (bogus) error. So disable the option. Signed-off-by: Juerg Haefliger <juergh@canonical.com> --- debian.raspi/config/config.common.ubuntu | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)