| Message ID | 20200918092030.3855438-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [-next] tty: hvc: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (27e2fbcd815a088d7d83c7158f76b6e95ab07c50) |
| snowpatch_ozlabs/build-ppc64le | warning | Upstream build failed, couldn't test patch |
| snowpatch_ozlabs/build-ppc64be | warning | Upstream build failed, couldn't test patch |
| snowpatch_ozlabs/build-ppc64e | warning | Upstream build failed, couldn't test patch |
| snowpatch_ozlabs/build-pmac32 | warning | Upstream build failed, couldn't test patch |
| snowpatch_ozlabs/checkpatch | warning | total: 0 errors, 1 warnings, 0 checks, 7 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
On Fri, Sep 18, 2020 at 05:20:30PM +0800, Yang Yingliang wrote: > Fix the link error by selecting SERIAL_CORE_CONSOLE. > > aarch64-linux-gnu-ld: drivers/tty/hvc/hvc_dcc.o: in function `dcc_early_write': > hvc_dcc.c:(.text+0x164): undefined reference to `uart_console_write' > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/tty/hvc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/tty/hvc/Kconfig b/drivers/tty/hvc/Kconfig > index d1b27b0522a3..8d60e0ff67b4 100644 > --- a/drivers/tty/hvc/Kconfig > +++ b/drivers/tty/hvc/Kconfig > @@ -81,6 +81,7 @@ config HVC_DCC > bool "ARM JTAG DCC console" > depends on ARM || ARM64 > select HVC_DRIVER > + select SERIAL_CORE_CONSOLE > help > This console uses the JTAG DCC on ARM to create a console under the HVC > driver. This console is used through a JTAG only on ARM. If you don't have > -- > 2.25.1 > Same question here, what caused this problem to happen? thanks, greg k-h
On 2020/9/18 19:17, Greg KH wrote: > On Fri, Sep 18, 2020 at 05:20:30PM +0800, Yang Yingliang wrote: >> Fix the link error by selecting SERIAL_CORE_CONSOLE. >> >> aarch64-linux-gnu-ld: drivers/tty/hvc/hvc_dcc.o: in function `dcc_early_write': >> hvc_dcc.c:(.text+0x164): undefined reference to `uart_console_write' >> >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> >> --- >> drivers/tty/hvc/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/tty/hvc/Kconfig b/drivers/tty/hvc/Kconfig >> index d1b27b0522a3..8d60e0ff67b4 100644 >> --- a/drivers/tty/hvc/Kconfig >> +++ b/drivers/tty/hvc/Kconfig >> @@ -81,6 +81,7 @@ config HVC_DCC >> bool "ARM JTAG DCC console" >> depends on ARM || ARM64 >> select HVC_DRIVER >> + select SERIAL_CORE_CONSOLE >> help >> This console uses the JTAG DCC on ARM to create a console under the HVC >> driver. This console is used through a JTAG only on ARM. If you don't have >> -- >> 2.25.1 >> > Same question here, what caused this problem to happen? Fixes: d1a1af2cdf19 ("hvc: dcc: Add earlycon support") > > thanks, > > greg k-h > .
On Sat, Sep 19, 2020 at 10:48:41AM +0800, Yang Yingliang wrote: > > On 2020/9/18 19:17, Greg KH wrote: > > On Fri, Sep 18, 2020 at 05:20:30PM +0800, Yang Yingliang wrote: > > > Fix the link error by selecting SERIAL_CORE_CONSOLE. > > > > > > aarch64-linux-gnu-ld: drivers/tty/hvc/hvc_dcc.o: in function `dcc_early_write': > > > hvc_dcc.c:(.text+0x164): undefined reference to `uart_console_write' > > > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > > > --- > > > drivers/tty/hvc/Kconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/tty/hvc/Kconfig b/drivers/tty/hvc/Kconfig > > > index d1b27b0522a3..8d60e0ff67b4 100644 > > > --- a/drivers/tty/hvc/Kconfig > > > +++ b/drivers/tty/hvc/Kconfig > > > @@ -81,6 +81,7 @@ config HVC_DCC > > > bool "ARM JTAG DCC console" > > > depends on ARM || ARM64 > > > select HVC_DRIVER > > > + select SERIAL_CORE_CONSOLE > > > help > > > This console uses the JTAG DCC on ARM to create a console under the HVC > > > driver. This console is used through a JTAG only on ARM. If you don't have > > > -- > > > 2.25.1 > > > > > Same question here, what caused this problem to happen? > Fixes: d1a1af2cdf19 ("hvc: dcc: Add earlycon support") Great, can you resend with that added please? thanks, greg k-h
diff --git a/drivers/tty/hvc/Kconfig b/drivers/tty/hvc/Kconfig index d1b27b0522a3..8d60e0ff67b4 100644 --- a/drivers/tty/hvc/Kconfig +++ b/drivers/tty/hvc/Kconfig @@ -81,6 +81,7 @@ config HVC_DCC bool "ARM JTAG DCC console" depends on ARM || ARM64 select HVC_DRIVER + select SERIAL_CORE_CONSOLE help This console uses the JTAG DCC on ARM to create a console under the HVC driver. This console is used through a JTAG only on ARM. If you don't have
Fix the link error by selecting SERIAL_CORE_CONSOLE. aarch64-linux-gnu-ld: drivers/tty/hvc/hvc_dcc.o: in function `dcc_early_write': hvc_dcc.c:(.text+0x164): undefined reference to `uart_console_write' Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/tty/hvc/Kconfig | 1 + 1 file changed, 1 insertion(+)