diff mbox series

[2/9] system_data_types.7: srcfix: Add FIXME note: Add descriptions

Message ID 20200918170442.94920-3-colomar.6.4.3@gmail.com
State New
Headers show
Series Document aiocb, sigevent, siginfo_t | expand

Commit Message

Alejandro Colomar Sept. 18, 2020, 5:04 p.m. UTC
Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
---
 man7/system_data_types.7 | 2 ++
 1 file changed, 2 insertions(+)

Comments

Michael Kerrisk \(man-pages\) Sept. 18, 2020, 8:50 p.m. UTC | #1
On 9/18/20 7:04 PM, Alejandro Colomar wrote:
> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>


Thanks, Alex. Patch applied.

Cheers,

Michael


> ---
>  man7/system_data_types.7 | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/man7/system_data_types.7 b/man7/system_data_types.7
> index 5352f3ef2..48871e4eb 100644
> --- a/man7/system_data_types.7
> +++ b/man7/system_data_types.7
> @@ -96,6 +96,8 @@ typedef struct {
>                          * the end of substring */
>  } regmatch_t;
>  .EE
> +.\".IP
> +.\" FIXME: Add a description?
>  .IP
>  Conforming to: POSIX.1-2001 and later.
>  .IP
>
Michael Kerrisk \(man-pages\) Sept. 18, 2020, 9:03 p.m. UTC | #2
Hi Alex,

On 9/18/20 10:50 PM, Michael Kerrisk (man-pages) wrote:
> On 9/18/20 7:04 PM, Alejandro Colomar wrote:
>> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
> 
> 
> Thanks, Alex. Patch applied.

Sorry -- I misspoke. This pach doesn't apply. It wasn't obvious why.

But, yes, I think adding a description would be good.

Thanks,

Michael

>> ---
>>  man7/system_data_types.7 | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/man7/system_data_types.7 b/man7/system_data_types.7
>> index 5352f3ef2..48871e4eb 100644
>> --- a/man7/system_data_types.7
>> +++ b/man7/system_data_types.7
>> @@ -96,6 +96,8 @@ typedef struct {
>>                          * the end of substring */
>>  } regmatch_t;
>>  .EE
>> +.\".IP
>> +.\" FIXME: Add a description?
>>  .IP
>>  Conforming to: POSIX.1-2001 and later.
>>  .IP
>>
> 
>
Alejandro Colomar Sept. 18, 2020, 9:35 p.m. UTC | #3
Hi Michael,

On 2020-09-18 23:03, Michael Kerrisk (man-pages) wrote:
> Hi Alex,
> 
> On 9/18/20 10:50 PM, Michael Kerrisk (man-pages) wrote:
>> On 9/18/20 7:04 PM, Alejandro Colomar wrote:
>>> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
>>
>>
>> Thanks, Alex. Patch applied.
> 
> Sorry -- I misspoke. This pach doesn't apply. It wasn't obvious why.
> 
> But, yes, I think adding a description would be good.
> 
> Thanks,
> 
> Michael
> 
>>> ---
>>>   man7/system_data_types.7 | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/man7/system_data_types.7 b/man7/system_data_types.7
>>> index 5352f3ef2..48871e4eb 100644
>>> --- a/man7/system_data_types.7
>>> +++ b/man7/system_data_types.7
>>> @@ -96,6 +96,8 @@ typedef struct {
>>>                           * the end of substring */
>>>   } regmatch_t;
>>>   .EE
>>> +.\".IP
>>> +.\" FIXME: Add a description?
>>>   .IP
>>>   Conforming to: POSIX.1-2001 and later.
>>>   .IP

I added that comment to every type that lacks a description so that we 
can see them easier.  In other types I embedded that comment in the 
patch with the documentation, but in this case, the type was already 
documented, so I had to add an extra commit.

Cheers,

Alex
diff mbox series

Patch

diff --git a/man7/system_data_types.7 b/man7/system_data_types.7
index 5352f3ef2..48871e4eb 100644
--- a/man7/system_data_types.7
+++ b/man7/system_data_types.7
@@ -96,6 +96,8 @@  typedef struct {
                         * the end of substring */
 } regmatch_t;
 .EE
+.\".IP
+.\" FIXME: Add a description?
 .IP
 Conforming to: POSIX.1-2001 and later.
 .IP