diff mbox series

[1/4] system_data_types.7: wfix

Message ID 20200918124554.46308-2-colomar.6.4.3@gmail.com
State New
Headers show
Series Document regoff_t (and a few minor patches) | expand

Commit Message

Alejandro Colomar Sept. 18, 2020, 12:45 p.m. UTC
Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
---
 man7/system_data_types.7 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Michael Kerrisk \(man-pages\) Sept. 18, 2020, 8:27 p.m. UTC | #1
Hello Alex,

On 9/18/20 2:45 PM, Alejandro Colomar wrote:
> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
> ---
>  man7/system_data_types.7 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/man7/system_data_types.7 b/man7/system_data_types.7
> index dba80cf6f..8969ee966 100644
> --- a/man7/system_data_types.7
> +++ b/man7/system_data_types.7
> @@ -350,7 +350,7 @@ struct timespec {
>  };
>  .EE
>  .IP
> -Describes times in seconds and nanoseconds.
> +Describes elapsed time in seconds and nanoseconds.
>  .IP
>  Conforming to: C11 and later; POSIX.1-2001 and later.
>  .IP
> @@ -379,7 +379,7 @@ struct timeval {
>  };
>  .EE
>  .IP
> -Describes times in seconds and microseconds.
> +Describes elapsed time in seconds and microseconds.
>  .IP
>  Conforming to: POSIX.1-2001 and later.
>  .IP

I don;t think this patch is correct. At the least, it needs 
more explanation. As far as I can see, 'timespec' is not just 
about elapsed time. It really is just time, expressed as secs + 
nanosecs. For example, see utimensat(2), which set file timestamps
with nanosec precision.

For the moment, I'm not applying this (and I hope not doing so
doesn't break any following patch).

Thanks,

Michael
Alejandro Colomar Sept. 18, 2020, 9:32 p.m. UTC | #2
Hello Michael,

On 2020-09-18 22:27, Michael Kerrisk (man-pages) wrote:
>> -Describes times in seconds and microseconds.
>> +Describes elapsed time in seconds and microseconds.
>>   .IP
>>   Conforming to: POSIX.1-2001 and later.
>>   .IP
> 
> I don;t think this patch is correct. At the least, it needs
> more explanation. As far as I can see, 'timespec' is not just
> about elapsed time. It really is just time, expressed as secs +
> nanosecs. For example, see utimensat(2), which set file timestamps
> with nanosec precision.

I took that wording from timeval.3bsd. But I think you're correct.

> 
> For the moment, I'm not applying this (and I hope not doing so
> doesn't break any following patch).

That's fine.  It shouldn't break anything.

> 
> Thanks,
> 
> Michael
> 


Cheers,

Alex
diff mbox series

Patch

diff --git a/man7/system_data_types.7 b/man7/system_data_types.7
index dba80cf6f..8969ee966 100644
--- a/man7/system_data_types.7
+++ b/man7/system_data_types.7
@@ -350,7 +350,7 @@  struct timespec {
 };
 .EE
 .IP
-Describes times in seconds and nanoseconds.
+Describes elapsed time in seconds and nanoseconds.
 .IP
 Conforming to: C11 and later; POSIX.1-2001 and later.
 .IP
@@ -379,7 +379,7 @@  struct timeval {
 };
 .EE
 .IP
-Describes times in seconds and microseconds.
+Describes elapsed time in seconds and microseconds.
 .IP
 Conforming to: POSIX.1-2001 and later.
 .IP